Re: svn commit: r29986 - trunk/subversion/libsvn_ra_serf

[Karl Fogel <kf...@red-bean.com>]

lgo@tigris.org writes:

> --- trunk/subversion/libsvn_ra_serf/util.c	Fri Mar 21 14:42:28 2008	(r29985)
> +++ trunk/subversion/libsvn_ra_serf/util.c	Fri Mar 21 14:58:52 2008	(r29986)
> @@ -181,6 +181,33 @@ ssl_server_cert(void *baton, int failure
>  
>    return server_creds ? APR_SUCCESS : SVN_ERR_RA_SERF_SSL_CERT_UNTRUSTED;
>  }
> +
> +static svn_error_t *
> +load_authorities(svn_ra_serf__connection_t *conn, const char *authorities,
> +                 apr_pool_t *pool)
> +{

Documentation for new internal function?  (I know the ra_serf code is
documentation-deficient, but let's not make the problem worse.)

> @@ -222,6 +249,19 @@ svn_ra_serf__conn_setup(apr_socket_t *so
>              {
>                serf_ssl_use_default_certificates(conn->ssl_context);
>              }
> +          /* Are there custom CAs to load? */
> +          if (conn->session->ssl_authorities)
> +            {
> +              svn_error_t *err;
> +              err = load_authorities(conn, conn->session->ssl_authorities,
> +                                     conn->session->pool);
> +              if (err) 
> +                {
> +                  /* TODO: we need a way to pass this error back to the 
> +                     caller */
> +                  svn_error_clear(err);
> +                }
> +            }
>  #endif

Yes, we do need a way to return an error.

What about setting conn->session->pending_error?  I'm no expert in the
conventions of the serf code, but it seems like that field might be
intended for exactly this purpose...

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org