You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Mark Hobson (JIRA)" <ji...@codehaus.org> on 2005/09/28 10:46:10 UTC

[jira] Created: (MNG-1037) Add war:exploded and war:inplace goals

Add war:exploded and war:inplace goals
--------------------------------------

         Key: MNG-1037
         URL: http://jira.codehaus.org/browse/MNG-1037
     Project: Maven 2
        Type: Improvement
  Components: maven-war-plugin  
    Versions: 2.0-beta-2    
 Reporter: Mark Hobson


Need to add war:exploded and war:inplace goals to replace the depreciated war:war mode config parameter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-1037) Add war:exploded and war:inplace goals

Posted by "allan ramirez (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-1037?page=all ]

allan ramirez updated MNG-1037:
-------------------------------

    Remaining Estimate: 8 hours
     Original Estimate: 28800

> Add war:exploded and war:inplace goals
> --------------------------------------
>
>          Key: MNG-1037
>          URL: http://jira.codehaus.org/browse/MNG-1037
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-war-plugin
>     Versions: 2.0-beta-2
>     Reporter: Mark Hobson
>     Assignee: allan ramirez
>      Fix For: 2.0-beta-4

>
> Original Estimate: 8 hours
>         Remaining: 8 hours
>
> Need to add war:exploded and war:inplace goals to replace the depreciated war:war mode config parameter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-1037) Add war:exploded and war:inplace goals

Posted by "allan ramirez (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-1037?page=all ]

allan ramirez updated MNG-1037:
-------------------------------

    Attachment: MNG-1037.patch

Converted the inplace and exploded mode parameters into goals

invoking goals

 - m2 war:exploded

 - m2 war:inplace

> Add war:exploded and war:inplace goals
> --------------------------------------
>
>          Key: MNG-1037
>          URL: http://jira.codehaus.org/browse/MNG-1037
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-war-plugin
>     Versions: 2.0-beta-2
>     Reporter: Mark Hobson
>     Assignee: allan ramirez
>      Fix For: 2.0-beta-4
>  Attachments: MNG-1037.patch
>
> Original Estimate: 8 hours
>         Remaining: 8 hours
>
> Need to add war:exploded and war:inplace goals to replace the depreciated war:war mode config parameter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MWAR-11) Add war:exploded and war:inplace goals

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MWAR-11?page=all ]
     
Stephane Nicoll closed MWAR-11:
-------------------------------

     Resolution: Fixed
    Fix Version: 2.0

> Add war:exploded and war:inplace goals
> --------------------------------------
>
>          Key: MWAR-11
>          URL: http://jira.codehaus.org/browse/MWAR-11
>      Project: Maven 2.x War Plugin
>         Type: Improvement

>     Reporter: Mark Hobson
>     Assignee: Allan Ramirez
>      Fix For: 2.0
>  Attachments: MNG-1037.patch, MNG-1037_b.patch
>
> Original Estimate: 8 hours
>        Time Spent: 8 hours
>         Remaining: 0 minutes
>
> Need to add war:exploded and war:inplace goals to replace the depreciated war:war mode config parameter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MNG-1037) Add war:exploded and war:inplace goals

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-1037?page=all ]
     
Brett Porter closed MNG-1037:
-----------------------------

    Resolution: Fixed

> Add war:exploded and war:inplace goals
> --------------------------------------
>
>          Key: MNG-1037
>          URL: http://jira.codehaus.org/browse/MNG-1037
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-war-plugin
>     Versions: 2.0-beta-2
>     Reporter: Mark Hobson
>     Assignee: allan ramirez
>      Fix For: 2.0-beta-4
>  Attachments: MNG-1037.patch, MNG-1037_b.patch
>
> Original Estimate: 8 hours
>        Time Spent: 8 hours
>         Remaining: 0 minutes
>
> Need to add war:exploded and war:inplace goals to replace the depreciated war:war mode config parameter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-1037) Add war:exploded and war:inplace goals

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-1037?page=all ]

Brett Porter updated MNG-1037:
------------------------------

    Fix Version: 2.0-beta-4

> Add war:exploded and war:inplace goals
> --------------------------------------
>
>          Key: MNG-1037
>          URL: http://jira.codehaus.org/browse/MNG-1037
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-war-plugin
>     Versions: 2.0-beta-2
>     Reporter: Mark Hobson
>      Fix For: 2.0-beta-4

>
>
> Need to add war:exploded and war:inplace goals to replace the depreciated war:war mode config parameter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-1037) Add war:exploded and war:inplace goals

Posted by "allan ramirez (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-1037?page=all ]

allan ramirez updated MNG-1037:
-------------------------------

    Attachment: MNG-1037_b.patch

-Created AbstractWarMojo for common fields, annotations, setters/getters.

Kenney,

Please let me know if I did get your point. :)

Thanks

> Add war:exploded and war:inplace goals
> --------------------------------------
>
>          Key: MNG-1037
>          URL: http://jira.codehaus.org/browse/MNG-1037
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-war-plugin
>     Versions: 2.0-beta-2
>     Reporter: Mark Hobson
>     Assignee: allan ramirez
>      Fix For: 2.0-beta-4
>  Attachments: MNG-1037.patch, MNG-1037_b.patch
>
> Original Estimate: 8 hours
>        Time Spent: 8 hours
>         Remaining: 0 minutes
>
> Need to add war:exploded and war:inplace goals to replace the depreciated war:war mode config parameter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Reopened: (MWAR-11) Add war:exploded and war:inplace goals

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MWAR-11?page=all ]
     
Stephane Nicoll reopened MWAR-11:
---------------------------------


> Add war:exploded and war:inplace goals
> --------------------------------------
>
>          Key: MWAR-11
>          URL: http://jira.codehaus.org/browse/MWAR-11
>      Project: Maven 2.x War Plugin
>         Type: Improvement

>     Reporter: Mark Hobson
>     Assignee: Allan Ramirez
>  Attachments: MNG-1037.patch, MNG-1037_b.patch
>
> Original Estimate: 8 hours
>        Time Spent: 8 hours
>         Remaining: 0 minutes
>
> Need to add war:exploded and war:inplace goals to replace the depreciated war:war mode config parameter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1037) Add war:exploded and war:inplace goals

Posted by "Kenney Westerhof (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1037?page=comments#action_47953 ] 

Kenney Westerhof commented on MNG-1037:
---------------------------------------

Hi Allan,

Nice patch, except for the solution. I guess you don't know this, but if you have 2 classes in a plugin, 
and one extends the other, both can have /** @parameter */ annotations - that works even for abstract
base classes.

I suggest you create an AbstractWarMojo baseclass, move all the common code (including setters/getters/fields/@parameter annotations)
there, and let the mojo's extend that common baseclass. 

That way the 3 mojo's will be very small and will be more maintainable - f.i. adding a parameter now has impact at 3 classes,
when you use the abstract base class there's just one class to modify, etc..

Thanks a lot!

> Add war:exploded and war:inplace goals
> --------------------------------------
>
>          Key: MNG-1037
>          URL: http://jira.codehaus.org/browse/MNG-1037
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-war-plugin
>     Versions: 2.0-beta-2
>     Reporter: Mark Hobson
>     Assignee: allan ramirez
>      Fix For: 2.0-beta-4
>  Attachments: MNG-1037.patch
>
> Original Estimate: 8 hours
>        Time Spent: 8 hours
>         Remaining: 0 minutes
>
> Need to add war:exploded and war:inplace goals to replace the depreciated war:war mode config parameter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1037) Add war:exploded and war:inplace goals

Posted by "allan ramirez (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1037?page=comments#action_47990 ] 

allan ramirez commented on MNG-1037:
------------------------------------

Hi Kenney,

Thanks for suggestion, I'll do it right away and submit another patch.. thanks





> Add war:exploded and war:inplace goals
> --------------------------------------
>
>          Key: MNG-1037
>          URL: http://jira.codehaus.org/browse/MNG-1037
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-war-plugin
>     Versions: 2.0-beta-2
>     Reporter: Mark Hobson
>     Assignee: allan ramirez
>      Fix For: 2.0-beta-4
>  Attachments: MNG-1037.patch
>
> Original Estimate: 8 hours
>        Time Spent: 8 hours
>         Remaining: 0 minutes
>
> Need to add war:exploded and war:inplace goals to replace the depreciated war:war mode config parameter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org