You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/08/28 18:20:56 UTC
Review Request 61952: Fixed the communication between old masters and
new agents.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61952/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Repository: mesos
Description
-------
A 1.4 agent used to send the resources to the master in
the "post-reservation-refinement" format, which is incompatible
for pre-1.4 masters. The new agent now always downgrades
the resources to the "pre-reservation-refinement" format, and
the 1.4 master unconditionally upgrades the resources to
"post-reservation-refinement" format.
Diffs
-----
src/master/master.cpp a9d2191d92d0a56c8a137cb28f41a3632db54fe9
src/slave/slave.cpp 3e880b3ad54dbad46f71c335c2a93edb9a546176
Diff: https://reviews.apache.org/r/61952/diff/1/
Testing
-------
Thanks,
Michael Park
Re: Review Request 61952: Fixed the communication between old masters
and new agents.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61952/#review183992
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Aug. 28, 2017, 8:46 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61952/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2017, 8:46 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-7922
> https://issues.apache.org/jira/browse/MESOS-7922
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For re-registration, 1.4 agents used to send the resources in tasks
> and executors to the master in the "post-reservation-refinement" format,
> which is incompatible for pre-1.4 masters. This patch changes the agent
> such that it always downgrades the resources to
> the "pre-reservation-refinement" format, and the master unconditionally
> upgrades the resources to "post-reservation-refinement" format.
>
>
> Diffs
> -----
>
> src/master/master.cpp a9d2191d92d0a56c8a137cb28f41a3632db54fe9
> src/slave/slave.cpp 3e880b3ad54dbad46f71c335c2a93edb9a546176
>
>
> Diff: https://reviews.apache.org/r/61952/diff/3/
>
>
> Testing
> -------
>
> - Started 1.3.1 master, agent.
> - Ran a persistent volume framework with the task commands changed to have `sleep 1000000`.
> - Upgraded the agent from 1.3.1 to `master`.
> - Observed the following message:
> > W0828 12:48:22.066509 40596 master.cpp:5702] Dropping re-registration of agent
> at slave(1)@10.0.49.2:5051 because it sent an invalid re-registration: Task uses
> invalid resources: Invalid DiskInfo: Persistent volumes cannot be created from
> unreserved resources
>
> ---
>
> - Started 1.3.1 master, agent.
> - Ran a persistent volume framework with the task commands changed to have `sleep 1000000`.
> - Upgraded the agent from 1.3.1 to `master` + this patch.
> - The agent was able to register successfully.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 61952: Fixed the communication between old masters
and new agents.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61952/#review183993
-----------------------------------------------------------
Should we also update the upgrade guide in the documentation with information about reservation refinement in the context of upgrades?
- Greg Mann
On Aug. 28, 2017, 8:46 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61952/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2017, 8:46 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-7922
> https://issues.apache.org/jira/browse/MESOS-7922
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For re-registration, 1.4 agents used to send the resources in tasks
> and executors to the master in the "post-reservation-refinement" format,
> which is incompatible for pre-1.4 masters. This patch changes the agent
> such that it always downgrades the resources to
> the "pre-reservation-refinement" format, and the master unconditionally
> upgrades the resources to "post-reservation-refinement" format.
>
>
> Diffs
> -----
>
> src/master/master.cpp a9d2191d92d0a56c8a137cb28f41a3632db54fe9
> src/slave/slave.cpp 3e880b3ad54dbad46f71c335c2a93edb9a546176
>
>
> Diff: https://reviews.apache.org/r/61952/diff/3/
>
>
> Testing
> -------
>
> - Started 1.3.1 master, agent.
> - Ran a persistent volume framework with the task commands changed to have `sleep 1000000`.
> - Upgraded the agent from 1.3.1 to `master`.
> - Observed the following message:
> > W0828 12:48:22.066509 40596 master.cpp:5702] Dropping re-registration of agent
> at slave(1)@10.0.49.2:5051 because it sent an invalid re-registration: Task uses
> invalid resources: Invalid DiskInfo: Persistent volumes cannot be created from
> unreserved resources
>
> ---
>
> - Started 1.3.1 master, agent.
> - Ran a persistent volume framework with the task commands changed to have `sleep 1000000`.
> - Upgraded the agent from 1.3.1 to `master` + this patch.
> - The agent was able to register successfully.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 61952: Fixed the communication between old masters
and new agents.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61952/
-----------------------------------------------------------
(Updated Aug. 28, 2017, 1:46 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Added manual testing.
Bugs: MESOS-7922
https://issues.apache.org/jira/browse/MESOS-7922
Repository: mesos
Description
-------
For re-registration, 1.4 agents used to send the resources in tasks
and executors to the master in the "post-reservation-refinement" format,
which is incompatible for pre-1.4 masters. This patch changes the agent
such that it always downgrades the resources to
the "pre-reservation-refinement" format, and the master unconditionally
upgrades the resources to "post-reservation-refinement" format.
Diffs
-----
src/master/master.cpp a9d2191d92d0a56c8a137cb28f41a3632db54fe9
src/slave/slave.cpp 3e880b3ad54dbad46f71c335c2a93edb9a546176
Diff: https://reviews.apache.org/r/61952/diff/2/
Testing (updated)
-------
- Started 1.3.1 master, agent.
- Ran a persistent volume framework with the task commands changed to have `sleep 1000000`.
- Upgraded the agent from 1.3.1 to `master`.
- Observed the following message:
> W0828 12:48:22.066509 40596 master.cpp:5702] Dropping re-registration of agent
at slave(1)@10.0.49.2:5051 because it sent an invalid re-registration: Task uses
invalid resources: Invalid DiskInfo: Persistent volumes cannot be created from
unreserved resources
---
- Started 1.3.1 master, agent.
- Ran a persistent volume framework with the task commands changed to have `sleep 1000000`.
- Upgraded the agent from 1.3.1 to `master` + this patch.
- The agent was able to register successfully.
Thanks,
Michael Park
Re: Review Request 61952: Fixed the communication between old masters
and new agents.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61952/#review183969
-----------------------------------------------------------
This change LGTM, one small nit below. Could you also verify this fix with a manual upgrade test - maybe our 'support/test-upgrade.py' script could be used?
src/slave/slave.cpp
Lines 1591-1592 (patched)
<https://reviews.apache.org/r/61952/#comment260008>
Looks like your linebreak is a bit early here on L1591?
- Greg Mann
On Aug. 28, 2017, 6:31 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61952/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2017, 6:31 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-7922
> https://issues.apache.org/jira/browse/MESOS-7922
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For re-registration, 1.4 agents used to send the resources in tasks
> and executors to the master in the "post-reservation-refinement" format,
> which is incompatible for pre-1.4 masters. This patch changes the agent
> such that it always downgrades the resources to
> the "pre-reservation-refinement" format, and the master unconditionally
> upgrades the resources to "post-reservation-refinement" format.
>
>
> Diffs
> -----
>
> src/master/master.cpp a9d2191d92d0a56c8a137cb28f41a3632db54fe9
> src/slave/slave.cpp 3e880b3ad54dbad46f71c335c2a93edb9a546176
>
>
> Diff: https://reviews.apache.org/r/61952/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 61952: Fixed the communication between old masters
and new agents.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61952/#review183986
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61952]
Logs available here: http://104.210.40.105/logs/master/61952
- Mesos Reviewbot Windows
On Aug. 28, 2017, 6:31 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61952/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2017, 6:31 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-7922
> https://issues.apache.org/jira/browse/MESOS-7922
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For re-registration, 1.4 agents used to send the resources in tasks
> and executors to the master in the "post-reservation-refinement" format,
> which is incompatible for pre-1.4 masters. This patch changes the agent
> such that it always downgrades the resources to
> the "pre-reservation-refinement" format, and the master unconditionally
> upgrades the resources to "post-reservation-refinement" format.
>
>
> Diffs
> -----
>
> src/master/master.cpp a9d2191d92d0a56c8a137cb28f41a3632db54fe9
> src/slave/slave.cpp 3e880b3ad54dbad46f71c335c2a93edb9a546176
>
>
> Diff: https://reviews.apache.org/r/61952/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 61952: Fixed the communication between old masters
and new agents.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61952/
-----------------------------------------------------------
(Updated Aug. 28, 2017, 11:31 a.m.)
Review request for mesos and Greg Mann.
Bugs: MESOS-7922
https://issues.apache.org/jira/browse/MESOS-7922
Repository: mesos
Description
-------
For re-registration, 1.4 agents used to send the resources in tasks
and executors to the master in the "post-reservation-refinement" format,
which is incompatible for pre-1.4 masters. This patch changes the agent
such that it always downgrades the resources to
the "pre-reservation-refinement" format, and the master unconditionally
upgrades the resources to "post-reservation-refinement" format.
Diffs
-----
src/master/master.cpp a9d2191d92d0a56c8a137cb28f41a3632db54fe9
src/slave/slave.cpp 3e880b3ad54dbad46f71c335c2a93edb9a546176
Diff: https://reviews.apache.org/r/61952/diff/2/
Testing
-------
Thanks,
Michael Park