You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wangyum <gi...@git.apache.org> on 2018/10/04 16:05:32 UTC
[GitHub] spark pull request #22632: [SPARK-25606][TESTS] Reduce DateExpressionsSuite ...
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/22632
[SPARK-25606][TESTS] Reduce DateExpressionsSuite test time costs in Jenkins
## What changes were proposed in this pull request?
Reduce `DateExpressionsSuite.Hour` test time costs in Jenkins by reduce iteration times.
## How was this patch tested?
Manual tests on my local machine.
before:
```
- Hour (34 seconds, 54 milliseconds)
```
after:
```
- Hour (2 seconds, 697 milliseconds)
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangyum/spark SPARK-25606
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22632.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22632
----
commit 3256100d8f37df25ad7e57e246201deed24c1137
Author: Yuming Wang <yu...@...>
Date: 2018-10-04T15:46:01Z
Reduce iteration times
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22632: [SPARK-25606][TEST] Reduce DateExpressionsSuite test tim...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22632
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96946/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22632: [SPARK-25606][TESTS] Reduce DateExpressionsSuite test ti...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22632
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22632: [SPARK-25606][TESTS] Reduce DateExpressionsSuite test ti...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22632
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3682/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22632: [SPARK-25606][TEST] Reduce DateExpressionsSuite t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22632
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22632: [SPARK-25606][TEST] Reduce DateExpressionsSuite test tim...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22632
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22632: [SPARK-25606][TEST] Reduce DateExpressionsSuite test tim...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22632
**[Test build #96946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96946/testReport)** for PR 22632 at commit [`3256100`](https://github.com/apache/spark/commit/3256100d8f37df25ad7e57e246201deed24c1137).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22632: [SPARK-25606][TEST] Reduce DateExpressionsSuite test tim...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22632
cc @gatorsmile @dongjoon-hyun
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22632: [SPARK-25606][TEST] Reduce DateExpressionsSuite test tim...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22632
@gatorsmile I have some confusion. Is this
https://github.com/apache/spark/blob/58c55cb4a6d72d72df908e37aa63f617b3cc5587/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala#L118-L122
should be
```scala
(0 to 24).foreach { h =>
c.add(Calendar.HOUR_OF_DAY, h)
checkEvaluation(Quarter(Literal(new Date(c.getTimeInMillis))),
c.get(Calendar.MONTH) / 3 + 1)
}
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22632: [SPARK-25606][TESTS] Reduce DateExpressionsSuite test ti...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22632
**[Test build #96946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96946/testReport)** for PR 22632 at commit [`3256100`](https://github.com/apache/spark/commit/3256100d8f37df25ad7e57e246201deed24c1137).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org