[jira] [Commented] (DOXIA-670) Remove code duplication in XdocSink

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DOXIA-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575625#comment-17575625 ] 

ASF GitHub Bot commented on DOXIA-670:
--------------------------------------

michael-o commented on PR #116:
URL: https://github.com/apache/maven-doxia/pull/116#issuecomment-1206155487

   Note: This change requires to drop: https://github.com/apache/maven-doxia/blob/3b1499d0572718fa4dcb7c6b775bedbe757d46c5/doxia-modules/doxia-module-xdoc/src/main/resources/xdoc-2.0.xsd#L2923-L2935 and release a new version. Alternatively, we'd translate source to `<div class="source"><pre>...`




> Remove code duplication in XdocSink
> -----------------------------------
>
>                 Key: DOXIA-670
>                 URL: https://issues.apache.org/jira/browse/DOXIA-670
>             Project: Maven Doxia
>          Issue Type: Task
>          Components: Module - Xhtml
>    Affects Versions: 2.0.0-M3
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 2.0.0-M4
>
>
> {{XdocSink}} duplicates code from the parent class. That code can be removed. It has one caveat: The {{source}} element cannot be retained at all because it has a completely different meaning in HTML5: https://www.tutorialrepublic.com/html-reference/html5-source-tag.php and since only the {{XHTML5Parser}} can properly detect the new construct {{verbatim(boxed)}} will always be parsed as unboxed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)