You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2024/04/16 19:17:02 UTC
[PR] Revert #30877 and #30915 to fix Java IOs PreCommit - Kafka upgrade test [beam]
Abacn opened a new pull request, #31001:
URL: https://github.com/apache/beam/pull/31001
Fix #30941; mitigate #30997 - we'll need to redo this change in a way that not breaking transform upgrade
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert #30877 and #30915 to fix Java IOs PreCommit - Kafka upgrade test [beam]
Posted by "xianhualiu (via GitHub)" <gi...@apache.org>.
xianhualiu commented on PR #31001:
URL: https://github.com/apache/beam/pull/31001#issuecomment-2060188882
please hold on merging this PR if possible. The https://github.com/apache/beam/pull/30998 will fix the test issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert #30877 and #30915 to fix Java IOs PreCommit - Kafka upgrade test [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #31001:
URL: https://github.com/apache/beam/pull/31001#issuecomment-2059957502
> we need to do the forward fix on this.
Yep, agreed (chatted offline about this already as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert #30877 and #30915 to fix Java IOs PreCommit - Kafka upgrade test [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #31001:
URL: https://github.com/apache/beam/pull/31001#issuecomment-2059772229
CC: @xianhualiu @damccorm In case the two linked Issues not resolved by release cut let's get this in so the release branch is green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert #30877 and #30915 to fix Java IOs PreCommit - Kafka upgrade test [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #31001:
URL: https://github.com/apache/beam/pull/31001#issuecomment-2059947840
we need to do the forward fix on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert #30877 and #30915 to fix Java IOs PreCommit - Kafka upgrade test [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #31001: Revert #30877 and #30915 to fix Java IOs PreCommit - Kafka upgrade test
URL: https://github.com/apache/beam/pull/31001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert #30877 and #30915 to fix Java IOs PreCommit - Kafka upgrade test [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31001:
URL: https://github.com/apache/beam/pull/31001#issuecomment-2059839186
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @liferoad for label python.
R: @robertwb for label java.
R: @chamikaramj for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert #30877 and #30915 to fix Java IOs PreCommit - Kafka upgrade test [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #31001:
URL: https://github.com/apache/beam/pull/31001#issuecomment-2061221248
Closing since https://github.com/apache/beam/pull/30998 went in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org