You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/08 10:58:58 UTC
[jira] [Commented] (BEAM-931) Findbugs doesn't pass in Flink runner
[ https://issues.apache.org/jira/browse/BEAM-931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15647224#comment-15647224 ]
ASF GitHub Bot commented on BEAM-931:
-------------------------------------
GitHub user aljoscha opened a pull request:
https://github.com/apache/incubator-beam/pull/1311
[BEAM-931] Fix Findbugs Warnings in Flink Runner
I manually checked via `mvn findbugs:check`. This is not currently activated in the pre-commit hook, is it?
R: @dhalperi
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/incubator-beam flink-fix-findbugs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1311.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1311
----
commit 3757cbd20beaf7db2849aa4c182f0dd059a8a755
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2016-11-08T10:56:45Z
[BEAM-931] Fix Findbugs Warnings in Flink Runner
----
> Findbugs doesn't pass in Flink runner
> -------------------------------------
>
> Key: BEAM-931
> URL: https://issues.apache.org/jira/browse/BEAM-931
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Daniel Halperin
> Assignee: Aljoscha Krettek
>
> {code}
> [INFO] --- findbugs-maven-plugin:3.0.1:check (default) @ beam-runners-flink_2.10 ---
> [INFO] BugInstance size is 9
> [INFO] Error size is 0
> [INFO] Total bugs: 9
> [INFO] Class org.apache.beam.runners.flink.FlinkRunner$StreamingViewAsMap defines non-transient non-serializable instance field runner [org.apache.beam.runners.flink.FlinkRunner$StreamingViewAsMap] In FlinkRunner.java
> [INFO] Class org.apache.beam.runners.flink.FlinkRunner$StreamingViewAsMultimap defines non-transient non-serializable instance field runner [org.apache.beam.runners.flink.FlinkRunner$StreamingViewAsMultimap] In FlinkRunner.java
> [INFO] Return value of org.apache.beam.sdk.io.Read$Bounded.getSource() ignored, but method has no side effect [org.apache.beam.runners.flink.translation.FlinkStreamingTransformTranslators$BoundedReadSourceTranslator] At FlinkStreamingTransformTranslators.java:[line 282]
> [INFO] Return value of org.apache.beam.sdk.io.Read$Unbounded.getSource() ignored, but method has no side effect [org.apache.beam.runners.flink.translation.FlinkStreamingTransformTranslators$UnboundedReadSourceTranslator] At FlinkStreamingTransformTranslators.java:[line 252]
> [INFO] org.apache.beam.runners.flink.translation.wrappers.SerializableFnAggregatorWrapper.clone() does not call super.clone() [org.apache.beam.runners.flink.translation.wrappers.SerializableFnAggregatorWrapper] At SerializableFnAggregatorWrapper.java:[lines 84-89]
> [INFO] Class org.apache.beam.runners.flink.translation.wrappers.streaming.WindowDoFnOperator defines non-transient non-serializable instance field stateInternals [org.apache.beam.runners.flink.translation.wrappers.streaming.WindowDoFnOperator] In WindowDoFnOperator.java
> [INFO] Class org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSocketSource$UnboundedSocketReader defines non-transient non-serializable instance field reader [org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSocketSource$UnboundedSocketReader] In UnboundedSocketSource.java
> [INFO] Class org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSocketSource$UnboundedSocketReader defines non-transient non-serializable instance field socket [org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSocketSource$UnboundedSocketReader] In UnboundedSocketSource.java
> [INFO] Unconditional wait in org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(SourceFunction$SourceContext) [org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper] At UnboundedSourceWrapper.java:[line 243]
> [INFO]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)