[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #1938: [KYUUBI #1883] Support max result rows for Flink queries

[GitBox <gi...@apache.org>]

SteNicholas commented on a change in pull request #1938:
URL: https://github.com/apache/incubator-kyuubi/pull/1938#discussion_r810715345



##########
File path: externals/kyuubi-flink-sql-engine/src/test/scala/org/apache/kyuubi/engine/flink/operation/FlinkOperationSuite.scala
##########
@@ -761,4 +761,16 @@ class FlinkOperationSuite extends WithFlinkSQLEngine with HiveJDBCTestHelper {
         .getStringVal.getValues.get(0) === "tmp.hello")
     }
   }
+
+  test("ensure result max rows") {

Review comment:
       Could you please add the test case for setting the `ENGINE_FLINK_MAX_ROWS`?

##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -1199,4 +1199,13 @@ object KyuubiConf {
       .version("1.5.0")
       .stringConf
       .createOptional
+
+  val ENGINE_FLINK_MAX_ROWS: ConfigEntry[Int] =
+    buildConf("engine.flink.max.rows")
+      .doc("Max rows of Flink query results. For batch queries, rows that exceeds the limit " +
+        "would be ignored. For streaming queries, the query would be canceled if the limit " +
+        "is reached.")
+      .version("1.5.0")
+      .intConf
+      .createWithDefault(500)

Review comment:
       IMO, this could refer to the default value of the `SqlClientOptions#EXECUTION_MAX_TABLE_RESULT_ROWS` option.

##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -1199,4 +1199,13 @@ object KyuubiConf {
       .version("1.5.0")
       .stringConf
       .createOptional
+
+  val ENGINE_FLINK_MAX_ROWS: ConfigEntry[Int] =
+    buildConf("engine.flink.max.rows")

Review comment:
       ```suggestion
       buildConf("session.engine.flink.max.rows")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org