You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ddev (Jira)" <ji...@apache.org> on 2022/01/31 17:41:00 UTC
[jira] [Comment Edited] (OFBIZ-12548) placeholder text has been implemented but seems to do nothing
[ https://issues.apache.org/jira/browse/OFBIZ-12548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484812#comment-17484812 ]
ddev edited comment on OFBIZ-12548 at 1/31/22, 5:40 PM:
--------------------------------------------------------
{quote}Actually it works as expected by OFBIZ-5341.
{quote}
Thanks. I see the one line patch in OFBIZ-5341, which is exactly what I was asking for:
{code:java}
--- specialpurpose/example/widget/example/ExampleForms.xml (revision 1530184)
+++ specialpurpose/example/widget/example/ExampleForms.xml (working copy)
@@ -124,7 +124,7 @@
- <field name="exampleName" required-field="true" widget-style="required"></field>
+ <field name="exampleName" required-field="true" widget-style="required"><text placeholder="${uiLabelMap.FormFieldTitle_exampleName}"/></field>
{code}
However, this patch does not appear to have be in the example/widget/example/ExampleForms.xml file from [https://github.com/apache/ofbiz-plugins.git] (release18.12 or trunk). (which I did check for a example of placeholder text before posting)
*Could that patch be applied for the next person?* (reopening)
Also note that changing the example plugin to match the patch *does* work for me, so I now have a working case that I can start working from. Thanks
was (Author: ddev):
The one line patch in OFBIZ-5341:
{code:java}
--- specialpurpose/example/widget/example/ExampleForms.xml (revision 1530184)
+++ specialpurpose/example/widget/example/ExampleForms.xml (working copy)
@@ -124,7 +124,7 @@
- <field name="exampleName" required-field="true" widget-style="required"></field>
+ <field name="exampleName" required-field="true" widget-style="required"><text placeholder="${uiLabelMap.FormFieldTitle_exampleName}"/></field>
{code}
Does satisfy the request, however, this patch does not appear to have be in the example/widget/example/ExampleForms.xml file from [https://github.com/apache/ofbiz-plugins.git] (release18.12 or trunk). (which I did check for a example of placeholder text before posting)
Can the patch be applied so the next person can find the example?
> placeholder text has been implemented but seems to do nothing
> -------------------------------------------------------------
>
> Key: OFBIZ-12548
> URL: https://issues.apache.org/jira/browse/OFBIZ-12548
> Project: OFBiz
> Issue Type: Bug
> Affects Versions: 18.12.05
> Reporter: ddev
> Assignee: Jacques Le Roux
> Priority: Major
>
> adding this to a form in a widget/somethingForms.xml file:
> <field name="description" title="${uiLabelMap.CommonDescription}" required-field="true"><text placeholder="This is placeholder text"/></field>
> Does not throw a error, but when the form is displayed, no placeholder text appears. I've checked the html code in the browser to confirm that it wasn't white placeholder text on a white background, and it does not define the placeholder property in the generated html.
> Are there any cases where placeholder text does work? If so, it would be nice if a working example could be added somewhere (like someone in ofbiz, or maybe in the "example" plugin)
> Here is a closed past issue implying that it's supposed to work now: OFBIZ-7024
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)