You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "royfengsss (via GitHub)" <gi...@apache.org> on 2025/03/06 01:11:08 UTC

[PR] lpc31xx: typo fix in board olimex-lpc-h3131 document [nuttx]

royfengsss opened a new pull request, #15947:
URL: https://github.com/apache/nuttx/pull/15947

   *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
   
   ## Summary
   in `Documentation/platforms/arm/lpc31xx/boards/olimex-lpc-h3131/README.txt:809`
   `NSH_DISABLE_NSFMOUNT` should be `NSH_DISABLE_NFSMOUNT`
   
   The corresponding change in `nuttx-app` repo is https://github.com/apache/nuttx-apps/pull/3019
   
   
   ## Impact
   
   Document upate. 
   
   ## Testing
   
   Document has been updated.
   See https://github.com/apache/nuttx-apps/pull/3019
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Documentation: lpc31xx: typo fix in board olimex-lpc-h3131 document [nuttx]

Posted by "royfengsss (via GitHub)" <gi...@apache.org>.
royfengsss commented on PR #15947:
URL: https://github.com/apache/nuttx/pull/15947#issuecomment-2705305747

   Thanks @jerpelea .
   
   I will pay more attention to the title of PRs in futhre contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] lpc31xx: typo fix in board olimex-lpc-h3131 document [nuttx]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #15947:
URL: https://github.com/apache/nuttx/pull/15947#issuecomment-2702517279

   @royfengsss Please remember to remove this line from the PR Summary: `Note: Please adhere to Contributing Guidelines.` Thanks :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] lpc31xx: typo fix in board olimex-lpc-h3131 document [nuttx]

Posted by "royfengsss (via GitHub)" <gi...@apache.org>.
royfengsss commented on PR #15947:
URL: https://github.com/apache/nuttx/pull/15947#issuecomment-2702824469

   > @royfengsss Please remember to remove this line from the PR Summary: Note: Please adhere to Contributing Guidelines. Thanks :-)
   
   Thanks for the advise. It is updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Documentation: lpc31xx: typo fix in board olimex-lpc-h3131 document [nuttx]

Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea commented on PR #15947:
URL: https://github.com/apache/nuttx/pull/15947#issuecomment-2703260956

   @acassis PR merged without proper PR and commit title !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] lpc31xx: typo fix in board olimex-lpc-h3131 document [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #15947:
URL: https://github.com/apache/nuttx/pull/15947


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org