[jira] [Updated] (ZOOKEEPER-756) some cleanup and improvements for zooinspector

["Thomas Koch (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Koch updated ZOOKEEPER-756:
----------------------------------

    Attachment: ZOOKEEPER-756.patch

This patch reworks the icon handling and replaces the eclipse icons with icons from the Tango project from freedesktop.org. (Tango icons are Public Domain) This was easier then trying to figure out the source of the eclipse icons. This also makes ZooInspector a bit more compliant to freedesktop standards and easier to package.

The JToaster jar has been replaced with its source code. - It was just one java file. JToaster is abandoned, not available in maven and really trivial code that should be replaced.

I added a TODO file to suggest further improvements to ZooInspector. ZooInspector would be a nice project for a student.

> some cleanup and improvements for zooinspector
> ----------------------------------------------
>
>                 Key: ZOOKEEPER-756
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-756
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: contrib
>    Affects Versions: 3.3.0
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>              Labels: zooinspector
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-756.patch, ZOOKEEPER-756.patch, Zooinspector-patch.patch, zooInspectorChanges.patch, zooInspectorChanges.patch
>
>
> Copied from the already closed ZOOKEEPER-678:
> * specify the exact URL, where the icons are from. It's best to include the link also in the NOTICE.txt file.
> It seems, that zooinspector finds it's icons only if the icons folder is in the current path. But when I install zooinspector as part of the Zookeeper Debian package, I want to be able to call it regardless of the current path.
> Could you use getRessources or something so that I can point to the icons location from the wrapper shell script?
> Can I place the zooinspector config files in /etc/zookeeper/zooinspector/ ? Could I give zooinspector a property to point to the config file location?
> There are several places, where viewers is missspelled as "Veiwers". Please do a case insensitive search for "veiw" to correct these. Even the config file "defaultNodeVeiwers.cfg" is missspelled like this. This has the potential to confuse the hell out of people when debugging something!

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira