[GitHub] [ozone] errose28 commented on a diff in pull request #3262: HDDS-5909. EC: Onboard EC into upgrade framework

[GitBox <gi...@apache.org>]

errose28 commented on code in PR #3262:
URL: https://github.com/apache/ozone/pull/3262#discussion_r842005684


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java:
##########
@@ -378,6 +387,30 @@ private InfoBucketResponse infoBucket(InfoBucketRequest request)
     return resp.build();
   }
 
+  @RequestFeatureValidator(
+      conditions = ValidationCondition.OLDER_CLIENT_REQUESTS,
+      processingPhase = RequestProcessingPhase.POST_PROCESS,
+      requestType = Type.InfoBucket
+  )
+  public static OMResponse disallowInfoBucketResponseWithECReplicationConfig(

Review Comment:
   Right, this looks like a new optional field added to the BucketInfo proto. If the old client gets it I would think protobuf would ignore the field and not throw an error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org