You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/11 01:13:03 UTC

[GitHub] [spark] viirya commented on a change in pull request #31547: [SPARK-34420][SQL] Throw exception if non-streaming Deduplicate is not replaced by aggregate

viirya commented on a change in pull request #31547:
URL: https://github.com/apache/spark/pull/31547#discussion_r574195363



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanSuite.scala
##########
@@ -97,4 +98,13 @@ class SparkPlanSuite extends QueryTest with SharedSparkSession {
       }
     }
   }
+
+  test("SPARK-34420: Throw exception if non-streaming Deduplicate is not replaced by aggregate") {
+    val df = spark.range(10)
+    val planner = spark.sessionState.planner
+    val deduplicate = Deduplicate(df.queryExecution.analyzed.output, df.queryExecution.analyzed)
+    intercept[IllegalStateException] {
+      planner.plan(deduplicate)
+    }

Review comment:
       okay. added the check of error message.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org