You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2016/09/14 09:14:38 UTC
[Bug 60131] New: [PATCH] D* functions refactor, use OperandResolver
https://bz.apache.org/bugzilla/show_bug.cgi?id=60131
Bug ID: 60131
Summary: [PATCH] D* functions refactor, use OperandResolver
Product: POI
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: SS Common
Assignee: dev@poi.apache.org
Reporter: patrick.zimmermann@haltec.de
Created attachment 34246
--> https://bz.apache.org/bugzilla/attachment.cgi?id=34246&action=edit
dstar_OperandResolver_refactor.patch
Non functionality changing refactor of DStarRunner.java to not use custom
implementations to resolve references or coerce to string, but use the
OperandResolver static methods instead.
Tests still all pass.
Also removes an unused method.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 60131] [PATCH] D* functions refactor, use OperandResolver
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60131
--- Comment #2 from Patrick Zimmermann <pa...@haltec.de> ---
(In reply to Nick Burch from comment #1)
> With this patch applied to trunk, but not your other patch, the unit tests
> fail with:
>
> ...
>
> Do we need to get your other patch fixed and applied first? Or do we need to
> fix the current tests for this patch?
I messed up a bit. Sorry for that.
Both patches together work fine.
There is a fix relating to error values in the D* database headers in here I
overlooked while preparing the patches. Because of that the new DGet.xls (which
tests that behavior) fails without this patch.
Also the DGet.xls has a false-positive test now <skip>ed which this patch
relies on.
Easiest way forward: Just apply both patches and the DGet.xls.
Alternative: I prepare another intermediate DGet.xls so one can apply the
patches one after the other.
What do you think?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 60131] [PATCH] D* functions refactor, use OperandResolver
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60131
Patrick Zimmermann <pa...@haltec.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 60131] [PATCH] D* functions refactor, use OperandResolver
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60131
--- Comment #3 from Javen O'Neal <on...@apache.org> ---
Together is fine.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 60131] [PATCH] D* functions refactor, use OperandResolver
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60131
Nick Burch <ap...@gagravarr.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #1 from Nick Burch <ap...@gagravarr.org> ---
With this patch applied to trunk, but not your other patch, the unit tests fail
with:
Testcase: processFunctionRow[strange types as headers - wrong number] took
0.001 sec
Caused an ERROR
Error evaluating cell DGet!B98
org.apache.poi.ss.formula.eval.NotImplementedException: Error evaluating cell
DGet!B98
at
org.apache.poi.ss.formula.WorkbookEvaluator.addExceptionInfo(WorkbookEvaluator.java:386)
at
org.apache.poi.ss.formula.WorkbookEvaluator.evaluateAny(WorkbookEvaluator.java:327)
at
org.apache.poi.ss.formula.WorkbookEvaluator.evaluate(WorkbookEvaluator.java:259)
at
org.apache.poi.hssf.usermodel.HSSFFormulaEvaluator.evaluateFormulaCellValue(HSSFFormulaEvaluator.java:200)
at
org.apache.poi.ss.formula.BaseFormulaEvaluator.evaluate(BaseFormulaEvaluator.java:101)
at
org.apache.poi.ss.formula.functions.BaseTestFunctionsFromSpreadsheet.processFunctionRow(BaseTestFunctionsFromSpreadsheet.java:151)
Caused by: org.apache.poi.ss.formula.eval.NotImplementedException: D* function
with formula conditions
at
org.apache.poi.ss.formula.functions.DStarRunner.fullfillsConditions(DStarRunner.java:227)
at
org.apache.poi.ss.formula.functions.DStarRunner.evaluate(DStarRunner.java:102)
at
org.apache.poi.ss.formula.functions.DStarRunner.evaluate(DStarRunner.java:55)
at
org.apache.poi.ss.formula.OperationEvaluatorFactory.evaluate(OperationEvaluatorFactory.java:132)
at
org.apache.poi.ss.formula.WorkbookEvaluator.evaluateFormula(WorkbookEvaluator.java:550)
at
org.apache.poi.ss.formula.WorkbookEvaluator.evaluateAny(WorkbookEvaluator.java:317)
Do we need to get your other patch fixed and applied first? Or do we need to
fix the current tests for this patch?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 60131] [PATCH] D* functions refactor, use OperandResolver
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60131
Nick Burch <ap...@gagravarr.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEEDINFO |RESOLVED
--- Comment #4 from Nick Burch <ap...@gagravarr.org> ---
Patch applied in r1760717, thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org