You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/05/29 20:18:10 UTC

[GitHub] [iceberg] rdblue opened a new pull request #1079: Exclude Guava from the compile classpath

rdblue opened a new pull request #1079:
URL: https://github.com/apache/iceberg/pull/1079


   This excludes Guava from `compileClasspath` so that Iceberg cannot use the classes directly, but tests will still pass because the `testRuntime` classpath does have transitive Guava classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] massdosage commented on a change in pull request #1079: Exclude Guava from the compile classpath

Posted by GitBox <gi...@apache.org>.
massdosage commented on a change in pull request #1079:
URL: https://github.com/apache/iceberg/pull/1079#discussion_r433131302



##########
File path: build.gradle
##########
@@ -59,6 +59,15 @@ subprojects {
 
   configurations {
     testCompile.extendsFrom compileOnly
+
+    compileClasspath {
+      // do not exclude Guava so the bundle project can reference classes.

Review comment:
       +1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] shardulm94 commented on pull request #1079: Exclude Guava from the compile classpath

Posted by GitBox <gi...@apache.org>.
shardulm94 commented on pull request #1079:
URL: https://github.com/apache/iceberg/pull/1079#issuecomment-636203799


   +1 LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue merged pull request #1079: Exclude Guava from the compile classpath

Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1079:
URL: https://github.com/apache/iceberg/pull/1079


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] massdosage commented on a change in pull request #1079: Exclude Guava from the compile classpath

Posted by GitBox <gi...@apache.org>.
massdosage commented on a change in pull request #1079:
URL: https://github.com/apache/iceberg/pull/1079#discussion_r433132132



##########
File path: build.gradle
##########
@@ -59,6 +59,15 @@ subprojects {
 
   configurations {
     testCompile.extendsFrom compileOnly
+
+    compileClasspath {

Review comment:
       This is better than enforcing the exclusion via Checkstyle as this will now be evident at compile time rather than when building the project. Nice.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdsr commented on a change in pull request #1079: Exclude Guava from the compile classpath

Posted by GitBox <gi...@apache.org>.
rdsr commented on a change in pull request #1079:
URL: https://github.com/apache/iceberg/pull/1079#discussion_r432751953



##########
File path: build.gradle
##########
@@ -59,6 +59,15 @@ subprojects {
 
   configurations {
     testCompile.extendsFrom compileOnly
+
+    compileClasspath {
+      // do not exclude Guava so the bundle project can reference classes.

Review comment:
       nit: slight rewording? . Exclude guava from iceberg modules except ... ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on pull request #1079: Exclude Guava from the compile classpath

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1079:
URL: https://github.com/apache/iceberg/pull/1079#issuecomment-636173802


   FYI @rdsr, @shardulm94, @massdosage.
   
   This also fixes the classes added in #1064 that were not updated by #1076.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on pull request #1079: Exclude Guava from the compile classpath

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1079:
URL: https://github.com/apache/iceberg/pull/1079#issuecomment-636208751


   Merging to fix master. I'll clarify the comment in a follow-up.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org