You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2026/09/17 07:32:58 UTC
[PR] Stop provider tests leaking AF2 global TI session [airflow]
amoghrajesh opened a new pull request, #73272:
URL: https://github.com/apache/airflow/pull/73272
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
Found in https://github.com/apache/airflow/actions/runs/35172746956/job/105090194086
Error:
```
___________________________________________________________________ TestDockerDecorator.test_skip_docker_operator[kwargs10-0-success] ____________________________________________________________________
providers/docker/tests/unit/docker/decorators/test_docker.py:181: in test_skip_docker_operator
dag_maker.run_ti("f", dr)
/usr/python/lib/python3.10/site-packages/tests_common/pytest_plugin.py:1483: in run_ti
ti.run(**kwargs)
/usr/python/lib/python3.10/site-packages/airflow/utils/session.py:97: in wrapper
return func(*args, session=session, **kwargs)
/usr/python/lib/python3.10/site-packages/airflow/models/taskinstance.py:3262: in run
self._run_raw_task(
/usr/python/lib/python3.10/site-packages/airflow/utils/session.py:94: in wrapper
return func(*args, **kwargs)
/usr/python/lib/python3.10/site-packages/airflow/models/taskinstance.py:3029: in _run_raw_task
return _run_raw_task(
/usr/python/lib/python3.10/site-packages/airflow/models/taskinstance.py:276: in _run_raw_task
with set_current_task_instance_session(session=session):
/usr/python/lib/python3.10/contextlib.py:135: in __enter__
return next(self.gen)
/usr/python/lib/python3.10/site-packages/airflow/utils/task_instance_session.py:60: in set_current_task_instance_session
raise RuntimeError(
E RuntimeError: Session already set for this task. You can only have one 'set_current_task_session' context manager active at a time.
```
On AF2, `get_current_task_instance_session` falls back to opening a session and parking it in a module global that only `_run_raw_task` ever clears again. Anything reaching it outside a task run poisons the whole pytest process, and every later `ti.run()` dies with "Session already set for this task" which is what broke the 2.11.1 compatibility job once a
`cncf.kubernetes` test started rendering a mapped operator's template fields. Resetting it per test in the shared plugin makes that a property of the harness rather than something each test file has to remember, which is why the standard provider's local copy of the workaround goes away with it.
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Stop provider tests leaking AF2 global TI session [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #73272:
URL: https://github.com/apache/airflow/pull/73272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org