You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/14 10:22:02 UTC

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #11931: Fix cannot save processDefinition

SbloodyS commented on code in PR #11931:
URL: https://github.com/apache/dolphinscheduler/pull/11931#discussion_r970617218


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java:
##########
@@ -893,6 +893,7 @@ protected int createComplementDependentCommand(List<Schedule> schedules, Command
 
         try {
             dependentCommand = (Command) BeanUtils.cloneBean(command);
+            dependentCommand.setId(null);

Review Comment:
   I found it's duplicated with #11929. cc @stalary 



##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java:
##########
@@ -893,6 +893,7 @@ protected int createComplementDependentCommand(List<Schedule> schedules, Command
 
         try {
             dependentCommand = (Command) BeanUtils.cloneBean(command);
+            dependentCommand.setId(null);

Review Comment:
   I found that it's duplicated with #11929. cc @stalary 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org