Re: svn commit: r9686 - trunk/www

[kf...@collab.net]

josander@tigris.org writes:
> This commeit is approvedby kfogel

IMHO no need to put that.

For an actual code change, it's probably good to say "reviewed by
so-and-so", but this is a doc change.  You did all the work here -- I
feel guilty getting any credit :-).

Your call, of course.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r9686 - trunk/www

[Erik Huelsmann <e....@gmx.net>]

> josander@tigris.org writes:
> > This commeit is approvedby kfogel
> 
> IMHO no need to put that.
> 
> For an actual code change, it's probably good to say "reviewed by
> so-and-so", but this is a doc change.  You did all the work here -- I
> feel guilty getting any credit :-).
> 
> Your call, of course.

It must have been because of the weather... it must be much nicer where you
are then where I am. I was very strict about changes outside the commit area
of partial committers. (And jostein was very strict at interpreting his
'various')

Anyway: jostein I agree with Karl; ask when you feel uncertain and just do
it when you feel confident.

bye,


Erik.

-- 
NEU : GMX Internet.FreeDSL
Ab sofort DSL-Tarif ohne Grundgeb�hr: http://www.gmx.net/dsl


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org