You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/04/05 15:34:41 UTC
[kudu-CR](branch-1.17.x) [Python] Add support for comment in ColumnSchema
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19694
to review the following change.
Change subject: [Python] Add support for comment in ColumnSchema
......................................................................
[Python] Add support for comment in ColumnSchema
This change adds support for column comments in the Python client.
It is a followup change to: e2870925f9a07da43658447248a4e64acde398b4.
Change-Id: I28a9f650bd1bf686244070151419d0a93b9a499c
Reviewed-on: http://gerrit.cloudera.org:8080/19581
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/common.py
M python/kudu/tests/test_client.py
M python/kudu/tests/test_schema.py
5 files changed, 54 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/19694/1
--
To view, visit http://gerrit.cloudera.org:8080/19694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I28a9f650bd1bf686244070151419d0a93b9a499c
Gerrit-Change-Number: 19694
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.17.x) [Python] Add support for comment in ColumnSchema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19694
to look at the new patch set (#3).
Change subject: [Python] Add support for comment in ColumnSchema
......................................................................
[Python] Add support for comment in ColumnSchema
This change adds support for column comments in the Python client.
It is a followup change to: e2870925f9a07da43658447248a4e64acde398b4.
Change-Id: I28a9f650bd1bf686244070151419d0a93b9a499c
Reviewed-on: http://gerrit.cloudera.org:8080/19581
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/common.py
M python/kudu/tests/test_client.py
M python/kudu/tests/test_schema.py
5 files changed, 54 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/19694/3
--
To view, visit http://gerrit.cloudera.org:8080/19694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28a9f650bd1bf686244070151419d0a93b9a499c
Gerrit-Change-Number: 19694
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.17.x) [Python] Add support for comment in ColumnSchema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19694 )
Change subject: [Python] Add support for comment in ColumnSchema
......................................................................
[Python] Add support for comment in ColumnSchema
This change adds support for column comments in the Python client.
It is a followup change to: e2870925f9a07da43658447248a4e64acde398b4.
Change-Id: I28a9f650bd1bf686244070151419d0a93b9a499c
Reviewed-on: http://gerrit.cloudera.org:8080/19581
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-on: http://gerrit.cloudera.org:8080/19694
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/common.py
M python/kudu/tests/test_client.py
M python/kudu/tests/test_schema.py
5 files changed, 54 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Marton Greber: Looks good to me, but someone else must approve
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I28a9f650bd1bf686244070151419d0a93b9a499c
Gerrit-Change-Number: 19694
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [Python] Add support for comment in ColumnSchema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19694
to look at the new patch set (#4).
Change subject: [Python] Add support for comment in ColumnSchema
......................................................................
[Python] Add support for comment in ColumnSchema
This change adds support for column comments in the Python client.
It is a followup change to: e2870925f9a07da43658447248a4e64acde398b4.
Change-Id: I28a9f650bd1bf686244070151419d0a93b9a499c
Reviewed-on: http://gerrit.cloudera.org:8080/19581
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/common.py
M python/kudu/tests/test_client.py
M python/kudu/tests/test_schema.py
5 files changed, 54 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/19694/4
--
To view, visit http://gerrit.cloudera.org:8080/19694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28a9f650bd1bf686244070151419d0a93b9a499c
Gerrit-Change-Number: 19694
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.17.x) [Python] Add support for comment in ColumnSchema
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19694 )
Change subject: [Python] Add support for comment in ColumnSchema
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I28a9f650bd1bf686244070151419d0a93b9a499c
Gerrit-Change-Number: 19694
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 24 May 2023 09:32:16 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [Python] Add support for comment in ColumnSchema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19694 )
Change subject: [Python] Add support for comment in ColumnSchema
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I28a9f650bd1bf686244070151419d0a93b9a499c
Gerrit-Change-Number: 19694
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 25 May 2023 02:24:52 +0000
Gerrit-HasComments: No