You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/29 03:59:54 UTC

[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #14557: [Numpy] fix test_operator_gpu.test_upsampling_bilinear_with_type

reminisce commented on a change in pull request #14557: [Numpy] fix test_operator_gpu.test_upsampling_bilinear_with_type
URL: https://github.com/apache/incubator-mxnet/pull/14557#discussion_r270273217
 
 

 ##########
 File path: src/operator/nn/deconvolution-inl.h
 ##########
 @@ -122,7 +122,7 @@ struct DeconvolutionParam : public dmlc::Parameter<DeconvolutionParam> {
     // Modified by Li.bs
     // Use tag to control the calculation of pad
     bool bCal = false;
-    if (target_shape.ndim() != 0) {
 
 Review comment:
   `target_shape` is default to `mxnet::TShape(0)`, so the original code is correct.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services