[GitHub] [arrow-rs] matthewmturner commented on pull request #984: Add comparison kernels for DictionaryArray

[GitBox <gi...@apache.org>]

matthewmturner commented on pull request #984:
URL: https://github.com/apache/arrow-rs/pull/984#issuecomment-988092550


   @alamb this took me _**much**_ longer than it should have, and im still not even sure if its idiomatic rust / arrow but i _**think**_ i might be close to getting the `eq_dict_scalar` kernel.  this process did definitely help a lot with learning about rust traits / macros and how arrow uses them.
   
   one thing i noticed is that it doesnt seem there is way to create a `DictionaryArray` from a vec of scalars like you can with a vec of str slices.  Is that expected? I also dont see a builder method i can use to construct the `DictionaryArray`.  I guess the main use case for `DictionaryArray` is with strings and not scalars?
   
   Either way, would you be able to see if this update is going in the right direction?  If so, then I can extend to utf8 kernels etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org