You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "lsm1 (via GitHub)" <gi...@apache.org> on 2023/07/10 09:12:07 UTC
[GitHub] [kyuubi] lsm1 opened a new pull request, #5038: [KYUUBI 5035][FEATURE] Spark engine session page display session end time and duration
lsm1 opened a new pull request, #5038:
URL: https://github.com/apache/kyuubi/pull/5038
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
close #5035
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #5038: [KYUUBI #5035] Spark engine session page display session end time and duration
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #5038:
URL: https://github.com/apache/kyuubi/pull/5038#issuecomment-1631791924
Thanks, merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #5038: [KYUUBI #5035] Spark engine session page display session end time and duration
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5038:
URL: https://github.com/apache/kyuubi/pull/5038#issuecomment-1630151378
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5038](https://app.codecov.io/gh/apache/kyuubi/pull/5038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c68fd65) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/e36d5d3fc96569eee8e6f8092b6a2ca4974bb2ab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e36d5d3) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #5038 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 563 563
Lines 31176 31188 +12
Branches 4070 4072 +2
======================================
- Misses 31176 31188 +12
```
| [Impacted Files](https://app.codecov.io/gh/apache/kyuubi/pull/5038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../scala/org/apache/spark/ui/EngineSessionPage.scala](https://app.codecov.io/gh/apache/kyuubi/pull/5038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3BhcmsvdWkvRW5naW5lU2Vzc2lvblBhZ2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/kyuubi/pull/5038/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #5038: [KYUUBI 5035][FEATURE] Spark engine session page display session end time and duration
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #5038:
URL: https://github.com/apache/kyuubi/pull/5038#discussion_r1259145558
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EngineSessionPage.scala:
##########
@@ -80,6 +80,16 @@ case class EngineSessionPage(parent: EngineTab)
IP {sessionStat.ip},
Server {sessionStat.serverIp},
Session created at {formatDate(sessionStat.startTime)},
+ {
+ if (sessionStat.endTime == -1L) {
Review Comment:
Or just <0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #5038: [KYUUBI 5035][FEATURE] Spark engine session page display session end time and duration
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #5038:
URL: https://github.com/apache/kyuubi/pull/5038#issuecomment-1628624578
Any screenshots for comparing the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #5038: [KYUUBI #5035] Spark engine session page display session end time and duration
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #5038:
URL: https://github.com/apache/kyuubi/pull/5038#discussion_r1259212798
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EngineSessionPage.scala:
##########
@@ -80,6 +80,16 @@ case class EngineSessionPage(parent: EngineTab)
IP {sessionStat.ip},
Server {sessionStat.serverIp},
Session created at {formatDate(sessionStat.startTime)},
+ {
+ if (sessionStat.endTime < 0) {
+ ""
+ } else {
+ s"""
+ |Session end at ${formatDate(sessionStat.endTime)},
Review Comment:
```suggestion
| ended at ${formatDate(sessionStat.endTime)},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] lsm1 commented on pull request #5038: [KYUUBI 5035][FEATURE] Spark engine session page display session end time and duration
Posted by "lsm1 (via GitHub)" <gi...@apache.org>.
lsm1 commented on PR #5038:
URL: https://github.com/apache/kyuubi/pull/5038#issuecomment-1629978616
> Any screenshots for comparing the changes?
ok，like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 closed pull request #5038: [KYUUBI #5035] Spark engine session page display session end time and duration
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 closed pull request #5038: [KYUUBI #5035] Spark engine session page display session end time and duration
URL: https://github.com/apache/kyuubi/pull/5038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #5038: [KYUUBI #5035] Spark engine session page display session end time and duration
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #5038:
URL: https://github.com/apache/kyuubi/pull/5038#issuecomment-1631038820
Would you like to update the screenshots in the description? And I think this PR is good to go. @lsm1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #5038: [KYUUBI #5035] Spark engine session page display session end time and duration
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #5038:
URL: https://github.com/apache/kyuubi/pull/5038#issuecomment-1630174377
How about changed to separated lines for connection details and the statistics.
```
<h4>
User {sessionStat.username},
IP {sessionStat.ip},
Server {sessionStat.serverIp},
</h4> ++
<h4>
Session created at {formatDate(sessionStat.startTime)},
if (sessionStat.endTime > 0) {
s"""
| ended at ${formatDate(sessionStat.endTime)},
| after ${formatDuration(sessionStat.duration)}.
|""".stripMargin
}
Total run {sessionStat.totalOperations} SQL
</h4> ++
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] lsm1 commented on pull request #5038: [KYUUBI #5035] Spark engine session page display session end time and duration
Posted by "lsm1 (via GitHub)" <gi...@apache.org>.
lsm1 commented on PR #5038:
URL: https://github.com/apache/kyuubi/pull/5038#issuecomment-1631702567
> Would you like to update the screenshots in the description? And I think this PR is good to go. @lsm1
ok，done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org