You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "krishna-dave206 (via GitHub)" <gi...@apache.org> on 2025/02/13 09:54:29 UTC
[PR] Update index.md [mahout]
krishna-dave206 opened a new pull request, #493:
URL: https://github.com/apache/mahout/pull/493
Updated the Introduction section's index.md file which had some changes to be made. Commented out the examples which are outdated.
### Purpose of PR:
Please give a short description of what this PR is for.
### Important ToDos
Please mark each with an "x"
- [ ] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/]
- [ ] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
- [ ] Created unit tests where appropriate
- [ ] Added licenses correct on newly added files
- [ ] Assigned JIRA to self
- [ ] Added documentation in scala docs/java docs, and to website
- [ ] Successfully built and ran all unit tests, verified that all tests pass locally.
If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"
Does this change break earlier versions?
Is this the beginning of a larger project for which a feature branch should be made?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update index.md [mahout]
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on PR #493:
URL: https://github.com/apache/mahout/pull/493#issuecomment-2656692100
Added some comments, I don' think this should be merged, I take full responsibility for not being clearer in my directions earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update index.md [mahout]
Posted by "krishna-dave206 (via GitHub)" <gi...@apache.org>.
krishna-dave206 commented on PR #493:
URL: https://github.com/apache/mahout/pull/493#issuecomment-2656082652
Hey @andrewmusselman, I have made the changes in the index.md of introduction section of quantum-computing-primer. There were some examples which were outdated, so I commented them out as said by @rawkintrevo. Kindly review it and if everything in that file is well, kindly merge it. Also, if there are any changes to be made by me then do lemme know.
Regards,
Krishna Dave
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update index.md [mahout]
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on PR #493:
URL: https://github.com/apache/mahout/pull/493#issuecomment-2656943843
That's a fair question, and something else we need to address. @andrewmusselman bump to forward the meeting invite to the list again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update index.md [mahout]
Posted by "krishna-dave206 (via GitHub)" <gi...@apache.org>.
krishna-dave206 closed pull request #493: Update index.md
URL: https://github.com/apache/mahout/pull/493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update index.md [mahout]
Posted by "krishna-dave206 (via GitHub)" <gi...@apache.org>.
krishna-dave206 commented on PR #493:
URL: https://github.com/apache/mahout/pull/493#issuecomment-2656711291
@rawkintrevo Thanks for the feedback and apologies for the mistakes. I'll review it once again and make changes accordingly. One query I had related to the community calls. I just wanted ti know that by when would I receive the link of meeting, like is it prior or just few hours before the meet. just wanted to know because of the timezone differences.
Regards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update index.md [mahout]
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on code in PR #493:
URL: https://github.com/apache/mahout/pull/493#discussion_r1954556960
##########
website/quantum-computing-primer/01_introduction/index.md:
##########
@@ -70,16 +76,19 @@ qc.apply_hadamard_gate(0)
# Execute the circuit and measure the result
result = qc.execute_circuit()
-print(result)
-```
+print(result)
+``` -->
In this example, we:
* Created a quantum circuit with 1 qubit.
* Applied a Hadamard gate to put the qubit into a superposition state.
* Measured the qubit to observe the probabilistic outcome.
-This is just the beginning! In the next sections, you'll dive deeper into quantum gates, circuits, and algorithms using qumat.
+# proposed method, does not yet exist
Review Comment:
? not sure what is going on here.
What I meant was in the later examples, let's say to actually do the example we needed some currently unimplemented gate, let's call it `foo_gate`. then in the example, you can re write it to be correct, but call out in the code that `foo_gate` doesn't exist yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update index.md [mahout]
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on code in PR #493:
URL: https://github.com/apache/mahout/pull/493#discussion_r1954554502
##########
website/quantum-computing-primer/01_introduction/index.md:
##########
@@ -70,16 +76,19 @@ qc.apply_hadamard_gate(0)
# Execute the circuit and measure the result
result = qc.execute_circuit()
-print(result)
-```
+print(result)
+``` -->
Review Comment:
I think this example actually works, it doesn't really _do_ anything, but that's OK. It's just dipping your toes in `qumat`.
I should have specified, the examples to comment out are in the later sections (like 8 and 9, maybe 7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update index.md [mahout]
Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman commented on PR #493:
URL: https://github.com/apache/mahout/pull/493#issuecomment-2657642546
@krishna-dave206 are you subscribed to the user and dev lists? Until then here is the info to join Fridays:
Mahout
Friday, February 14 · 1:00 – 2:00pm
Time zone: America/Los_Angeles
Google Meet joining info
Video call link: https://meet.google.com/nuf-fnbx-cpo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org