You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/30 02:57:59 UTC
[GitHub] [airflow] dstandish opened a new pull request #20574: Clarify docstring for `build_pod_request_obj`
dstandish opened a new pull request #20574:
URL: https://github.com/apache/airflow/pull/20574
It's unclear what was referred to by `pod` because there isn't a `pod` parameter. I attempt to replace with clearer (and accurate) information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BasPH commented on a change in pull request #20574: Clarify docstring for `build_pod_request_obj`
Posted by GitBox <gi...@apache.org>.
BasPH commented on a change in pull request #20574:
URL: https://github.com/apache/airflow/pull/20574#discussion_r776641171
##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -491,9 +491,9 @@ def on_kill(self) -> None:
def build_pod_request_obj(self, context=None):
"""
- Creates a V1Pod based on user parameters. Note that a `pod` or `pod_template_file`
- will supersede all other values.
+ Returns V1Pod object based on pod template file, full pod spec, and other operator parameters.
+ Full pod spec overrides pod template, and operator params take highest precedence.
Review comment:
Would reverse the order so that the most important variable is mentioned first:
```suggestion
The V1Pod attributes are selected from (first to last): operator params, full pod spec, pod template file.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #20574: Clarify docstring for `build_pod_request_obj`
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #20574:
URL: https://github.com/apache/airflow/pull/20574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20574: Clarify docstring for `build_pod_request_obj`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20574:
URL: https://github.com/apache/airflow/pull/20574#issuecomment-1003037059
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org