You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/09/10 12:46:59 UTC
[GitHub] [netbeans] sdedic opened a new pull request #2359: commit-validation fixes: code improvements
sdedic opened a new pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359
This PR collects several code improvements for both tests and the implementation itself. The goal is to make `commit-validation` work again. For easier review separated from 'simple' order change / label fixes which are coming in a subsequent PR.
See explanation comments inline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#issuecomment-695834078
> Btw. also Groovy is failing. Probably some ordering issue?
IMHO failing because of the revived `JavaIndexer`; I think I'll need @BradWalker review / assistance for this -- or some other Groovy Guru ? The error was:
```
It differs in the following things:
Number of lines:
Expected: 85
Actual: 87
Actual content contains following lines which are missing in expected content:
CLASS Singleton3() null
CLASS y() null
Log:
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#issuecomment-696664311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#issuecomment-692770245
During further implementation, it turned out that the `MimeRegistration` change may be insufficient: there are folders where the registration order is not important.
And even folders like `UpToDateStatusProvider`, where **multiple** service types are registered; such folders should not define ordering at all (it does not make sense to specify linear order between two different service kinds, right ?)
So I am tempted to extend the API with `MimeLocation.Ordered(true/false)` that would determine whether the Processor will auto-generate positions. By default all FS-based Lookups are order-sensitive, so it may make sense to explicitly declare the opposite.
@jtulach ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491694477
##########
File path: enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/ddloaders/SunDescriptorDataObject.java
##########
@@ -107,7 +108,7 @@ protected int getXMLMultiViewIndex() {
private DDType descriptorType;
private final int xmlIndex;
- public SunDescriptorDataObject(FileObject pf, SunDescriptorDataLoader loader) throws DataObjectExistsException {
+ public SunDescriptorDataObject(FileObject pf, MultiFileLoader loader) throws DataObjectExistsException {
Review comment:
Failure in [sigtest check](https://travis-ci.org/github/apache/netbeans/jobs/728712948):
```
Class org.netbeans.modules.j2ee.sun.ddloaders.SunDescriptorDataObject
"E5.4 - Removing constructor" : constructor public org.netbeans.modules.j2ee.sun.ddloaders.SunDescriptorDataObject.init(org.openide.filesystems.FileObject,org.netbeans.modules.j2ee.sun.ddloaders.SunDescriptorDataLoader)
```
Keep both constructors, if possible. Alternatively let's investigate why this is broken at all: what is the actual failure with the old constructor signature?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic edited a comment on pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic edited a comment on pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#issuecomment-695834078
> Btw. also Groovy is failing. Probably some ordering issue?
IMHO failing because of the revived `JavaIndexer`; I think I'll need @BradWalker review / assistance for this -- or some other Groovy Guru ? The error was:
```
It differs in the following things:
Number of lines:
Expected: 85
Actual: 87
Actual content contains following lines which are missing in expected content:
CLASS Singleton3() null
CLASS y() null
Log:
...
```
When I removed the java indexer's `shadow` file, test passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491906900
##########
File path: enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/ddloaders/SunDescriptorDataObject.java
##########
@@ -107,7 +108,7 @@ protected int getXMLMultiViewIndex() {
private DDType descriptorType;
private final int xmlIndex;
- public SunDescriptorDataObject(FileObject pf, SunDescriptorDataLoader loader) throws DataObjectExistsException {
+ public SunDescriptorDataObject(FileObject pf, MultiFileLoader loader) throws DataObjectExistsException {
Review comment:
Strangely enough, the `@DataObject.Registration` on `PayaraDescriptorDataObject` could have never worked, IMHO: `MimeFactory` passes in an instance created by `DataLoaderPool.getDefaultFileLoader()`, which is definitely not a SunDDwhatever. Maybe I could save the API change entirely by removing the extra (not effectively used) registration completely, leaving the registration on `PayaraDescriptorDataLoader` only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491694477
##########
File path: enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/ddloaders/SunDescriptorDataObject.java
##########
@@ -107,7 +108,7 @@ protected int getXMLMultiViewIndex() {
private DDType descriptorType;
private final int xmlIndex;
- public SunDescriptorDataObject(FileObject pf, SunDescriptorDataLoader loader) throws DataObjectExistsException {
+ public SunDescriptorDataObject(FileObject pf, MultiFileLoader loader) throws DataObjectExistsException {
Review comment:
Failure in [sigtest check](https://travis-ci.org/github/apache/netbeans/jobs/728712948):
```
Class org.netbeans.modules.j2ee.sun.ddloaders.SunDescriptorDataObject
"E5.4 - Removing constructor" : constructor public org.netbeans.modules.j2ee.sun.ddloaders.SunDescriptorDataObject.init(org.openide.filesystems.FileObject,org.netbeans.modules.j2ee.sun.ddloaders.SunDescriptorDataLoader)
```
Keep both constructors, if possible. Alternatively let's investigate why this is broken at all: what is the actual failure with the old constructor signature?
##########
File path: nbbuild/cluster.properties
##########
@@ -717,8 +717,6 @@ nb.cluster.java=\
maven.search,\
maven.spring,\
nashorn.execution,\
- performance,\
Review comment:
This change probably results in [following failure](https://travis-ci.org/github/apache/netbeans/jobs/728712951):
```
[nb-javac] /home/travis/build/apache/netbeans/enterprise/performance.javaee/test/unit/src/org/netbeans/performance/j2ee/startup/MeasureJ2EEStartupTime.java:23: error: package org.netbeans.modules.performance.utilities does not exist
[nb-javac] import org.netbeans.modules.performance.utilities.MeasureStartupTimeTestCase;
[nb-javac] ^
[nb-javac] /home/travis/build/apache/netbeans/enterprise/performance.javaee/test/unit/src/org/netbeans/performance/j2ee/startup/MeasureJ2EEStartupTime.java:30: error: cannot find symbol
[nb-javac] public class MeasureJ2EEStartupTime extends MeasureStartupTimeTestCase {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#issuecomment-695765765
We didn't came to an agreement really w.r.t. how to generate or handle positions. There's an open discussion on mailing list, but no conclusion so far (and @jtulach didn't participated so far either). So I'll update this PR to:
- fix issues relevant to code: that may affect the execution
- **revert** the MIME processor NOT to generate positions automatically (the previous state)
Plus add a PR to *disable part of position checking (temporarily ! hopefully). The collection of all those PR should make the commit-validation work quickly, we can debate about how / if automatic positions should be generated later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491673380
##########
File path: enterprise/spring.webmvc/src/org/netbeans/modules/spring/webmvc/resources/spring-webmvc-5.0.xml
##########
@@ -25,7 +25,7 @@
<localizing-bundle>org.netbeans.modules.spring.webmvc.resources.Bundle</localizing-bundle>
<volume>
<type>classpath</type>
- <resource>jar:nbinst://org.netbeans.libs.springframework/modules/ext/spring-5/spring-webmvc-5.2.2.RELEASE.jar!/</resource>
+ <resource>jar:nbinst://org.netbeans.libs.springframework/modules/ext/spring-5/spring-webmvc-5.2.9.RELEASE.jar!/</resource>
Review comment:
`Srpingmvc` module actually delivers 5.2.9 version; I've updated. @hectorespert to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r486313371
##########
File path: platform/editor.mimelookup/src/org/netbeans/modules/editor/mimelookup/CreateRegistrationProcessor.java
##########
@@ -145,7 +147,17 @@ private void process(Element toRegister, AnnotationMirror mimeRegistration) thro
}
instantiableClassOrMethod(toRegister, apiTE);
- layer(toRegister).instanceFile("Editors" + mimeType + folder, null, null).position(position).stringvalue("instanceOf", processingEnv.getElementUtils().getBinaryName(apiTE).toString()).write(); //NOI18N
+ File f = layer(toRegister).instanceFile("Editors" + mimeType + folder, null, null);
+ if (position == Integer.MAX_VALUE && !"".equals(folder)) {
Review comment:
The problem is that with MIME being hierarchical, a single `position` defined in `text/x-java` means, that if anyone registers a general service (in `/`):
- if `position` is not specified, that service faisl commit-validation as the sequence text/x-java/* + /* contains both defined and undefined positions
- if general service **does** define position, then all MIMEs **other than java** must start to provide positions.
So as discussed with @JaroslavTulach, it's far more safer to generate some positions always.
The goal is to:
- generate position
- prefer more specific (lower in the folder hierarchy) registrations
- define _some_ stable order
- generate different numbers :-)
Note the exclusion of the `""` (none) subfolder: various services are registered in `Editors/` (or relevant MIME) directly which do NOT have position at the moment, and are registerd manually (entries in layers.xml, ...). Tons of changes would happen if positions would be generated by the annotation processor there. So this change only affect "named" service subfolders.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#issuecomment-696664311
Updated. Rebased on later master, so @hectorespert changes got in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic edited a comment on pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic edited a comment on pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#issuecomment-695834078
> Btw. also Groovy is failing. Probably some ordering issue?
IMHO failing because of the revived `JavaIndexer`; I think I'll need @BradWalker review / assistance for this -- or some other Groovy Guru ? The error was:
```
It differs in the following things:
Number of lines:
Expected: 85
Actual: 87
Actual content contains following lines which are missing in expected content:
CLASS Singleton3() null
CLASS y() null
Log:
...
```
When I removed the java indexer's `shadow` file, test passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r492663963
##########
File path: enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/ddloaders/SunDescriptorDataObject.java
##########
@@ -107,7 +108,7 @@ protected int getXMLMultiViewIndex() {
private DDType descriptorType;
private final int xmlIndex;
- public SunDescriptorDataObject(FileObject pf, SunDescriptorDataLoader loader) throws DataObjectExistsException {
+ public SunDescriptorDataObject(FileObject pf, MultiFileLoader loader) throws DataObjectExistsException {
Review comment:
I have reverted the SunDescriptorDataObject, and removed the extra (and non-working) registration in Payara. Filed [NETBEANS-4828](https://issues.apache.org/jira/browse/NETBEANS-4828).
##########
File path: webcommon/javascript2.jquery/test/unit/src/org/netbeans/modules/javascript2/jquery/JQueryCodeCompletionSelectorsTest.java
##########
@@ -190,6 +191,7 @@ public void testAttributeName_05() throws Exception {
}
public void checkAppliedCompletion(final String file, final String caretLine, final String expectedLine, final String itemToComplete, final boolean includeModifiers) throws Exception {
+ RepositoryUpdater.getDefault().waitUntilFinished(10000);
Review comment:
`checkCompletion` waits for Updater to finish, this check's variant did not. Caused spurious errors / race conditions locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491673806
##########
File path: platform/core.startup/src/org/netbeans/core/startup/ConsistencyVerifier.java
##########
@@ -152,7 +152,7 @@ private ConsistencyVerifier() {}
for (Object prob : probs) {
if (prob instanceof Dependency) {
Dependency d = (Dependency) prob;
- if (Dependency.TYPE_JAVA == d.getType() && m.isAutoload()) {
+ if (Dependency.TYPE_JAVA == d.getType() && (m.isEager() || m.isAutoload())) {
Review comment:
Ignnores unsatisfied Java dependencies for both `eager` and `autoload` modules: when tests run on JDK8 dependencies on JDK9/11 makes the module to fail. If it is eager, it's OK to ignore, it's just enhancing something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491673614
##########
File path: ide/gsf.testrunner/src/org/netbeans/modules/gsf/testrunner/TestCreatorProviderProcessor.java
##########
@@ -47,12 +47,19 @@ protected boolean handleProcess(Set<? extends TypeElement> annotations, RoundEnv
if(registration == null) {
continue;
}
- File f = layer(e).instanceFile("Services", null);
+ File f = layer(e).instanceFile("Services/TestCreatorProviders", null);
f.stringvalue("instanceOf", TestCreatorProvider.class.getName());
f.bundlevalue("displayName", registration.displayName());
f.bundlevalue("identifier", registration.identifier());
- if (registration.position() != -1) {
- f.intvalue("position", registration.position());
+ int pos = registration.position();
+ if (pos != -1) {
+ if (pos == Integer.MAX_VALUE) {
Review comment:
Even junit has positional info, let's generate automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491673717
##########
File path: nbbuild/cluster.properties
##########
@@ -717,8 +717,6 @@ nb.cluster.java=\
maven.search,\
maven.spring,\
nashorn.execution,\
- performance,\
Review comment:
This is somewhat controversial; @jlahoda or @jtulach to review: performance tests are not really used now, and the performance* modules contain just testing code, yet they appear in the release distribution. And fail commit-validation tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r486313785
##########
File path: platform/o.n.core/test/qa-functional/src/org/netbeans/core/validation/ValidateLayerConsistencyTest.java
##########
@@ -905,7 +905,11 @@ private boolean skipFile(FileObject fo) {
public void testKeymapOverrides() throws Exception { // #170677
List<String> warnings = new ArrayList<String>();
- FileObject[] keymaps = FileUtil.getConfigFile("Keymaps").getChildren();
+ FileObject keymapRoot = FileUtil.getConfigFile("Keymaps");
Review comment:
Turned out to be a problem when `commit-validation` was run on `clustrer.config=platform` (no keymaps there)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r492665000
##########
File path: webcommon/javascript2.jquery/test/unit/src/org/netbeans/modules/javascript2/jquery/JQueryCodeCompletionSelectorsTest.java
##########
@@ -190,6 +191,7 @@ public void testAttributeName_05() throws Exception {
}
public void checkAppliedCompletion(final String file, final String caretLine, final String expectedLine, final String itemToComplete, final boolean includeModifiers) throws Exception {
+ RepositoryUpdater.getDefault().waitUntilFinished(10000);
Review comment:
`checkCompletion` waits for Updater to finish, this check's variant did not. Caused spurious errors / race conditions locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
hectorespert commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491673881
##########
File path: enterprise/spring.webmvc/src/org/netbeans/modules/spring/webmvc/resources/spring-webmvc-5.0.xml
##########
@@ -25,7 +25,7 @@
<localizing-bundle>org.netbeans.modules.spring.webmvc.resources.Bundle</localizing-bundle>
<volume>
<type>classpath</type>
- <resource>jar:nbinst://org.netbeans.libs.springframework/modules/ext/spring-5/spring-webmvc-5.2.2.RELEASE.jar!/</resource>
+ <resource>jar:nbinst://org.netbeans.libs.springframework/modules/ext/spring-5/spring-webmvc-5.2.9.RELEASE.jar!/</resource>
Review comment:
Please, rebase the last changes from master, I just merged the fix for that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic merged pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491703231
##########
File path: nbbuild/cluster.properties
##########
@@ -717,8 +717,6 @@ nb.cluster.java=\
maven.search,\
maven.spring,\
nashorn.execution,\
- performance,\
Review comment:
ah ! Strange I didn't get this one running build. So perhaps remove `performance.javaee` as well ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#issuecomment-696665675
Removed completely the (long broken) reference to Java Indexer. Filed [NETBEANS-4826](https://issues.apache.org/jira/browse/NETBEANS-4826) to invent appropriate fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491673202
##########
File path: enterprise/javaee.api/src/org/netbeans/modules/javaee/api/javaee-endorsed-api-6.0.xml
##########
@@ -20,8 +20,7 @@
under the License.
-->
-<!DOCTYPE library PUBLIC "-//NetBeans//DTD Library Declaration 1.0//EN" "http://www.netbeans.org/dtds/library-declaration-1_0.dtd">
-<library version="1.0">
+<library version="3.0" xmlns="http://www.netbeans.org/ns/library-declaration/3">
Review comment:
Validation was failing on the dtd ... and there's a new version of the declaration anyway, so I've updated. @jGauravGupta to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r486309580
##########
File path: ide/gsf.testrunner/src/org/netbeans/modules/gsf/testrunner/TestCreatorProviderProcessor.java
##########
@@ -47,11 +47,11 @@ protected boolean handleProcess(Set<? extends TypeElement> annotations, RoundEnv
if(registration == null) {
continue;
}
- File f = layer(e).instanceFile("Services", null);
+ File f = layer(e).instanceFile("Services/TestCreatorProviders", null);
f.stringvalue("instanceOf", TestCreatorProvider.class.getName());
f.bundlevalue("displayName", registration.displayName());
f.bundlevalue("identifier", registration.identifier());
- if (registration.position() != -1) {
+ if (registration.position() != -1 && registration.position() != Integer.MAX_VALUE) {
Review comment:
The Processor generates same position for all position-less registrations, which fails commit-validationtest.
##########
File path: java/java.project.ui/src/org/netbeans/modules/java/project/ui/NewJavaFileWizardIterator.java
##########
@@ -241,17 +242,28 @@ private void addRequires(FileObject createdFile, Set<String> requiredModuleNames
final JavaSource src = JavaSource.forFileObject(createdFile);
if (src != null) {
final Set<String> mNames = requiredModuleNames;
- src.runModificationTask((WorkingCopy copy) -> {
- copy.toPhase(JavaSource.Phase.RESOLVED);
Review comment:
Surprisingly this Lambda caused the test to fail on CNFE when instantiating the Iterator (test checks if the instanceCreate works), as nbjavac's *Element were not available at test time. Moving to a subclass delayed linkage (the task actually never runs during test)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491673284
##########
File path: enterprise/payara.eecommon/src/org/netbeans/modules/payara/eecommon/dd/loader/PayaraDescriptorDataObject.java
##########
@@ -113,7 +114,7 @@
),
@ActionReference(
path = DD_ACTION_PATH,
- id = @ActionID(category = "Edit", id = "org.openide.actions.RenameAction"),
+ id = @ActionID(category = "System", id = "org.openide.actions.RenameAction"),
Review comment:
Apparently a typo, but please review, @jGauravGupta
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491673202
##########
File path: enterprise/javaee.api/src/org/netbeans/modules/javaee/api/javaee-endorsed-api-6.0.xml
##########
@@ -20,8 +20,7 @@
under the License.
-->
-<!DOCTYPE library PUBLIC "-//NetBeans//DTD Library Declaration 1.0//EN" "http://www.netbeans.org/dtds/library-declaration-1_0.dtd">
-<library version="1.0">
+<library version="3.0" xmlns="http://www.netbeans.org/ns/library-declaration/3">
Review comment:
Validation was failing on the dtd ... and there's a new version of the declaration anyway, so I've updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491673156
##########
File path: enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/ddloaders/SunDescriptorDataObject.java
##########
@@ -107,7 +108,7 @@ protected int getXMLMultiViewIndex() {
private DDType descriptorType;
private final int xmlIndex;
- public SunDescriptorDataObject(FileObject pf, SunDescriptorDataLoader loader) throws DataObjectExistsException {
+ public SunDescriptorDataObject(FileObject pf, MultiFileLoader loader) throws DataObjectExistsException {
Review comment:
The more specific type caused reflection errors when instantiated from OpenIDE's `MimeFactory`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#issuecomment-690631421
@jtulach not completely ready yet; just cluster.config=basic seems to be fixed, release is to be done soon (hopefully). Will enable then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic merged pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r489214743
##########
File path: ide/gsf.testrunner/src/org/netbeans/modules/gsf/testrunner/TestCreatorProviderProcessor.java
##########
@@ -47,11 +47,11 @@ protected boolean handleProcess(Set<? extends TypeElement> annotations, RoundEnv
if(registration == null) {
continue;
}
- File f = layer(e).instanceFile("Services", null);
+ File f = layer(e).instanceFile("Services/TestCreatorProviders", null);
Review comment:
Right. It is.
##########
File path: platform/openide.filesystems/src/org/openide/filesystems/Ordering.java
##########
@@ -158,7 +164,8 @@ public int compareTo(ChildAndPosition o) {
previousChild = subsequentChild;
}
}
- if (logWarnings && /* #201893*/ !parent.getPath().matches("Projects/.+/Lookup") && !childrenByPosition.isEmpty() && childrenByPosition.size() < children.size()) {
+ if (logWarnings && /* #201893*/ !parent.getPath().matches("Projects/.+/Lookup") && !childrenByPosition.isEmpty() && childrenByPosition.size() < children.size() &&
Review comment:
Couldn't, by a chance, the check for `Projects/.+/Lookup` be removed by using the same trick with autogenerating the position? No need to solve it in this PR however.
##########
File path: java/java.project.ui/src/org/netbeans/modules/java/project/ui/NewJavaFileWizardIterator.java
##########
@@ -241,17 +242,28 @@ private void addRequires(FileObject createdFile, Set<String> requiredModuleNames
final JavaSource src = JavaSource.forFileObject(createdFile);
if (src != null) {
final Set<String> mNames = requiredModuleNames;
- src.runModificationTask((WorkingCopy copy) -> {
- copy.toPhase(JavaSource.Phase.RESOLVED);
Review comment:
Fine.
##########
File path: platform/editor.mimelookup/src/org/netbeans/modules/editor/mimelookup/CreateRegistrationProcessor.java
##########
@@ -145,7 +147,17 @@ private void process(Element toRegister, AnnotationMirror mimeRegistration) thro
}
instantiableClassOrMethod(toRegister, apiTE);
- layer(toRegister).instanceFile("Editors" + mimeType + folder, null, null).position(position).stringvalue("instanceOf", processingEnv.getElementUtils().getBinaryName(apiTE).toString()).write(); //NOI18N
+ File f = layer(toRegister).instanceFile("Editors" + mimeType + folder, null, null);
+ if (position == Integer.MAX_VALUE && !"".equals(folder)) {
Review comment:
Right, generate some positions always.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#issuecomment-695834078
> Btw. also Groovy is failing. Probably some ordering issue?
IMHO failing because of the revived `JavaIndexer`; I think I'll need @BradWalker review / assistance for this -- or some other Groovy Guru ? The error was:
```
It differs in the following things:
Number of lines:
Expected: 85
Actual: 87
Actual content contains following lines which are missing in expected content:
CLASS Singleton3() null
CLASS y() null
Log:
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491673504
##########
File path: groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/resources/layer.xml
##########
@@ -120,13 +120,13 @@
</folder>
<file name="JavaIndexer.shadow">
- <attr name="originalFile" stringvalue="Editors/text/x-java/JavaIndexer.instance"/>
+ <!-- Ugly hack to make commit-validation work. Must change when NETBEANS-4795 is implemented -->
+ <attr name="originalFile" stringvalue="Editors/text/x-java/org-netbeans-modules-java-source-indexing-JavaCustomIndexer$Factory-register.instance"/>
Review comment:
The original shadow pointed to nowhere. @lkishalmi to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491673934
##########
File path: platform/openide.filesystems/src/org/openide/filesystems/Ordering.java
##########
@@ -158,7 +164,18 @@ public int compareTo(ChildAndPosition o) {
previousChild = subsequentChild;
}
}
- if (logWarnings && /* #201893*/ !parent.getPath().matches("Projects/.+/Lookup") && !childrenByPosition.isEmpty() && childrenByPosition.size() < children.size()) {
+ boolean shouldLog = logWarnings && !childrenByPosition.isEmpty() && childrenByPosition.size() < children.size();
+ if (shouldLog) {
+ // exceptions: See Bugzilla#201893
+ if (parent.getPath().matches("Projects/.+/Lookup")) {
+ // do not report any order issues for Projects/Lookup, even between files, or between folders.
+ shouldLog = false;
+ } else if (FileUtil.isParentOf(FileUtil.getConfigRoot(), parent) && ((ordered & unordered) == 0)) {
Review comment:
both ordered and undordered bits have to be set for a category (folder OR file) to log the warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r486330754
##########
File path: platform/openide.filesystems/src/org/openide/filesystems/Ordering.java
##########
@@ -158,7 +164,8 @@ public int compareTo(ChildAndPosition o) {
previousChild = subsequentChild;
}
}
- if (logWarnings && /* #201893*/ !parent.getPath().matches("Projects/.+/Lookup") && !childrenByPosition.isEmpty() && childrenByPosition.size() < children.size()) {
+ if (logWarnings && /* #201893*/ !parent.getPath().matches("Projects/.+/Lookup") && !childrenByPosition.isEmpty() && childrenByPosition.size() < children.size() &&
Review comment:
The registration folder typically contains `.instance` files and subfolders (categories, ...); while if one `.instance` is position-ed, all `.instance`s should define positions (this is the point of the test).
It seems that it is NOT necessary to require order on files+folders, but just order within the category.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491728061
##########
File path: enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/ddloaders/SunDescriptorDataObject.java
##########
@@ -107,7 +108,7 @@ protected int getXMLMultiViewIndex() {
private DDType descriptorType;
private final int xmlIndex;
- public SunDescriptorDataObject(FileObject pf, SunDescriptorDataLoader loader) throws DataObjectExistsException {
+ public SunDescriptorDataObject(FileObject pf, MultiFileLoader loader) throws DataObjectExistsException {
Review comment:
For the records, the error was:
```
[junit] java.lang.NoSuchMethodException: org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject.<init>(org.openide.filesystems.FileObj
ect, org.openide.loaders.MultiFileLoader)
[junit] at java.lang.Class.getConstructor0(Class.java:3082)
[junit] at java.lang.Class.getConstructor(Class.java:1825)
[junit] at org.openide.loaders.MimeFactory.<init>(MimeFactory.java:54)
[junit] Caused: java.lang.IllegalStateException: org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject.<init>(org.openide.filesystems
.FileObject, org.openide.loaders.MultiFileLoader)
[junit] at org.openide.loaders.MimeFactory.<init>(MimeFactory.java:57)
[junit] at org.openide.loaders.MimeFactory.layer(MimeFactory.java:77)
[junit] at org.openide.loaders.DataLoaderPool.factory(DataLoaderPool.java:641)
[junit] Caused: java.lang.reflect.InvocationTargetException
[junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[junit] at java.lang.reflect.Method.invoke(Method.java:498)
[junit] at org.netbeans.core.startup.layers.BinaryFS$AttrImpl$MethodAndParams.invoke(BinaryFS.java:730)
[junit] [catch] at org.netbeans.core.startup.layers.BinaryFS$AttrImpl.getValue(BinaryFS.java:660)
[junit] at org.netbeans.core.startup.layers.BinaryFS$BFSBase.getAttribute(BinaryFS.java:506)
[junit] at org.openide.filesystems.MultiFileObject.getAttribute(MultiFileObject.java:918)
[junit] at org.openide.filesystems.MultiFileObject.getAttribute(MultiFileObject.java:851)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491694637
##########
File path: nbbuild/cluster.properties
##########
@@ -717,8 +717,6 @@ nb.cluster.java=\
maven.search,\
maven.spring,\
nashorn.execution,\
- performance,\
Review comment:
This change probably results in [following failure](https://travis-ci.org/github/apache/netbeans/jobs/728712951):
```
[nb-javac] /home/travis/build/apache/netbeans/enterprise/performance.javaee/test/unit/src/org/netbeans/performance/j2ee/startup/MeasureJ2EEStartupTime.java:23: error: package org.netbeans.modules.performance.utilities does not exist
[nb-javac] import org.netbeans.modules.performance.utilities.MeasureStartupTimeTestCase;
[nb-javac] ^
[nb-javac] /home/travis/build/apache/netbeans/enterprise/performance.javaee/test/unit/src/org/netbeans/performance/j2ee/startup/MeasureJ2EEStartupTime.java:30: error: cannot find symbol
[nb-javac] public class MeasureJ2EEStartupTime extends MeasureStartupTimeTestCase {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r492663963
##########
File path: enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/ddloaders/SunDescriptorDataObject.java
##########
@@ -107,7 +108,7 @@ protected int getXMLMultiViewIndex() {
private DDType descriptorType;
private final int xmlIndex;
- public SunDescriptorDataObject(FileObject pf, SunDescriptorDataLoader loader) throws DataObjectExistsException {
+ public SunDescriptorDataObject(FileObject pf, MultiFileLoader loader) throws DataObjectExistsException {
Review comment:
I have reverted the SunDescriptorDataObject, and removed the extra (and non-working) registration in Payara. Filed [NETBEANS-4828](https://issues.apache.org/jira/browse/NETBEANS-4828).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491703231
##########
File path: nbbuild/cluster.properties
##########
@@ -717,8 +717,6 @@ nb.cluster.java=\
maven.search,\
maven.spring,\
nashorn.execution,\
- performance,\
Review comment:
ah ! Strange I didn't get this one running build. So perhaps remove `performance.javaee` as well ?
##########
File path: enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/ddloaders/SunDescriptorDataObject.java
##########
@@ -107,7 +108,7 @@ protected int getXMLMultiViewIndex() {
private DDType descriptorType;
private final int xmlIndex;
- public SunDescriptorDataObject(FileObject pf, SunDescriptorDataLoader loader) throws DataObjectExistsException {
+ public SunDescriptorDataObject(FileObject pf, MultiFileLoader loader) throws DataObjectExistsException {
Review comment:
For the records, the error was:
```
[junit] java.lang.NoSuchMethodException: org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject.<init>(org.openide.filesystems.FileObj
ect, org.openide.loaders.MultiFileLoader)
[junit] at java.lang.Class.getConstructor0(Class.java:3082)
[junit] at java.lang.Class.getConstructor(Class.java:1825)
[junit] at org.openide.loaders.MimeFactory.<init>(MimeFactory.java:54)
[junit] Caused: java.lang.IllegalStateException: org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject.<init>(org.openide.filesystems
.FileObject, org.openide.loaders.MultiFileLoader)
[junit] at org.openide.loaders.MimeFactory.<init>(MimeFactory.java:57)
[junit] at org.openide.loaders.MimeFactory.layer(MimeFactory.java:77)
[junit] at org.openide.loaders.DataLoaderPool.factory(DataLoaderPool.java:641)
[junit] Caused: java.lang.reflect.InvocationTargetException
[junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[junit] at java.lang.reflect.Method.invoke(Method.java:498)
[junit] at org.netbeans.core.startup.layers.BinaryFS$AttrImpl$MethodAndParams.invoke(BinaryFS.java:730)
[junit] [catch] at org.netbeans.core.startup.layers.BinaryFS$AttrImpl.getValue(BinaryFS.java:660)
[junit] at org.netbeans.core.startup.layers.BinaryFS$BFSBase.getAttribute(BinaryFS.java:506)
[junit] at org.openide.filesystems.MultiFileObject.getAttribute(MultiFileObject.java:918)
[junit] at org.openide.filesystems.MultiFileObject.getAttribute(MultiFileObject.java:851)
```
##########
File path: enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/ddloaders/SunDescriptorDataObject.java
##########
@@ -107,7 +108,7 @@ protected int getXMLMultiViewIndex() {
private DDType descriptorType;
private final int xmlIndex;
- public SunDescriptorDataObject(FileObject pf, SunDescriptorDataLoader loader) throws DataObjectExistsException {
+ public SunDescriptorDataObject(FileObject pf, MultiFileLoader loader) throws DataObjectExistsException {
Review comment:
`MimeFactory` looks specifically for a constructor with `MultiFileLoader` in the signature; maybe it could search constructors for MFL subclass ?
##########
File path: enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/ddloaders/SunDescriptorDataObject.java
##########
@@ -107,7 +108,7 @@ protected int getXMLMultiViewIndex() {
private DDType descriptorType;
private final int xmlIndex;
- public SunDescriptorDataObject(FileObject pf, SunDescriptorDataLoader loader) throws DataObjectExistsException {
+ public SunDescriptorDataObject(FileObject pf, MultiFileLoader loader) throws DataObjectExistsException {
Review comment:
Strangely enough, the `@DataObject.Registration` on `PayaraDescriptorDataObject` could have never worked, IMHO: `MimeFactory` passes in an instance created by `DataLoaderPool.getDefaultFileLoader()`, which is definitely not a SunDDwhatever. Maybe I could save the API change entirely by removing the extra (not effectively used) registration completely, leaving the registration on `PayaraDescriptorDataLoader` only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r486307632
##########
File path: ide/gsf.testrunner/src/org/netbeans/modules/gsf/testrunner/TestCreatorProviderProcessor.java
##########
@@ -47,11 +47,11 @@ protected boolean handleProcess(Set<? extends TypeElement> annotations, RoundEnv
if(registration == null) {
continue;
}
- File f = layer(e).instanceFile("Services", null);
+ File f = layer(e).instanceFile("Services/TestCreatorProviders", null);
Review comment:
Compatible, Services Lookup is recursive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2359: commit-validation fixes: code improvements
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2359:
URL: https://github.com/apache/netbeans/pull/2359#discussion_r491728110
##########
File path: enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/ddloaders/SunDescriptorDataObject.java
##########
@@ -107,7 +108,7 @@ protected int getXMLMultiViewIndex() {
private DDType descriptorType;
private final int xmlIndex;
- public SunDescriptorDataObject(FileObject pf, SunDescriptorDataLoader loader) throws DataObjectExistsException {
+ public SunDescriptorDataObject(FileObject pf, MultiFileLoader loader) throws DataObjectExistsException {
Review comment:
`MimeFactory` looks specifically for a constructor with `MultiFileLoader` in the signature; maybe it could search constructors for MFL subclass ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists