[jira] [Created] (STORM-114) Runtime ClassCastException while attempting to log problems with file deletion while cleaning inbox.

["James Xu (JIRA)" <ji...@apache.org>]

James Xu created STORM-114:
------------------------------

             Summary: Runtime ClassCastException while attempting to log problems with file deletion while cleaning inbox.
                 Key: STORM-114
                 URL: https://issues.apache.org/jira/browse/STORM-114
             Project: Apache Storm (Incubating)
          Issue Type: Bug
            Reporter: James Xu


I noticed this while starting nimbus with a user that didn't have privileges to cleanup the inbox (also see this https://groups.google.com/forum/#!msg/storm-user/I8gTBg8-qy8/U7Q41AiJYkUJ)

nimbus clean-inbox calls log-error incorrectly (first argument should be a Throwable) generating a runtime exception.

        (log-message "Cleaning inbox ... deleted: " (.getName f))
        ;; This should never happen
        (log-error "Cleaning inbox ... error deleting: " (.getName f))
        ))))
I guess a "this should never happen" should be instead be replaced with a RuntimeException.

2013-06-26 04:45:59,999 nimbus [Thread-1] [ERROR] Error when processing event
java.lang.ClassCastException: java.lang.String cannot be cast to java.lang.Throwable
    at clojure.tools.logging$eval1$fn__7.invoke(NO_SOURCE_FILE:0)
    at clojure.tools.logging.impl$fn__56$G__49__67.invoke(impl.clj:16)
    at clojure.tools.logging$log_STAR_.invoke(logging.clj:59)
    at backtype.storm.daemon.nimbus$clean_inbox.invoke(nimbus.clj:832)
    at backtype.storm.daemon.nimbus$fn__3596$exec_fn__1231__auto____3597$fn__3607.invoke(nimbus.clj:880)
    at backtype.storm.timer$schedule_recurring$this__1779.invoke(timer.clj:77)
    at backtype.storm.timer$mk_timer$fn__1762$fn__1763.invoke(timer.clj:33)
    at backtype.storm.timer$mk_timer$fn__1762.invoke(timer.clj:26)
    at clojure.lang.AFn.run(AFn.java:24)
    at java.lang.Thread.run(Thread.java:662)
2013-06-26 04:46:00,022 util [Thread-1] [INFO] Halting process: ("Error when processing an event")

both #611 and #756 are trying to solve this issue



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)