You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:38:37 UTC

[GitHub] [hadoop] iwasakims commented on a change in pull request #2149: HADOOP-13230. S3A to optionally retain directory markers

iwasakims commented on a change in pull request #2149:
URL: https://github.com/apache/hadoop/pull/2149#discussion_r462222407



##########
File path: hadoop-tools/hadoop-aws/pom.xml
##########
@@ -331,6 +336,44 @@
       </properties>
     </profile>
 
+    <!-- Directory marker retention options, all from the -Dmarkers value-->
+    <profile>
+      <id>keep-markers</id>
+      <activation>
+        <property>
+          <name>markers</name>
+          <value>keep</value>
+        </property>
+      </activation>
+      <properties >
+        <fs.s3a.directory.marker>keep</fs.s3a.directory.marker>

Review comment:
       The property name must be `fs.s3a.directory.marker.retention` to make it consistent with Constants.java.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org