You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/12/26 12:18:03 UTC
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request
#680: refactor chunk reader
jt2594838 commented on a change in pull request #680: refactor chunk reader
URL: https://github.com/apache/incubator-iotdb/pull/680#discussion_r361443944
##########
File path: tsfile/src/test/java/org/apache/iotdb/tsfile/read/reader/PageReaderTest.java
##########
@@ -171,14 +171,11 @@ public void test(TSDataType dataType) {
ByteBuffer page = ByteBuffer.wrap(pageWriter.getUncompressedBytes().array());
PageReader pageReader = new PageReader(page, dataType, decoder,
- new DeltaBinaryDecoder.LongDeltaDecoder());
+ new DeltaBinaryDecoder.LongDeltaDecoder(), null);
int index = 0;
long startTimestamp = System.currentTimeMillis();
- BatchData data = null;
- if (pageReader.hasNextBatch()) {
- data = pageReader.nextBatch();
- }
+ BatchData data = pageReader.getAllSatisfiedPageData();
assert data != null;
Review comment:
Replace with JUnit assertion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services