You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/10/22 22:59:32 UTC
[Impala-ASF-CR] IMPALA-9027: planner fixes for mt dop
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14522
to look at the new patch set (#4).
Change subject: IMPALA-9027: planner fixes for mt_dop
......................................................................
IMPALA-9027: planner fixes for mt_dop
* Update the distributed planner to reflect that broadcast join tables
are replicated in all fragments.
* Did a pass over the planner code looking at call sites of
getNumNodes() to confirm that they shouldn't be replaced by
getNumInstances()
Testing:
* Updated affected planner test where PARALLELPLANS had a
different join strategy.
* Added a targeted test to mem-limit-broadcast-join.test to
show that mt_dop affects join mode.
* Ran exhaustive tests.
Change-Id: I23395c2dadf6be0e8be99706ca3ab5f4964cbcf9
---
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java
M fe/src/main/java/org/apache/impala/planner/HashJoinNode.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/mem-limit-broadcast-join.test
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
M testdata/workloads/functional-planner/queries/PlannerTest/spillable-buffer-sizing.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpch-all.test
9 files changed, 769 insertions(+), 667 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/14522/4
--
To view, visit http://gerrit.cloudera.org:8080/14522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I23395c2dadf6be0e8be99706ca3ab5f4964cbcf9
Gerrit-Change-Number: 14522
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>