You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/10/11 07:51:57 UTC
[GitHub] [drill] KazydubB commented on a change in pull request #1869:
DRILL-7254: Read Hive union w/o nulls
KazydubB commented on a change in pull request #1869: DRILL-7254: Read Hive union w/o nulls
URL: https://github.com/apache/drill/pull/1869#discussion_r332942929
##########
File path: exec/vector/src/main/codegen/templates/UnionListWriter.java
##########
@@ -35,7 +35,7 @@
private ListVector vector;
private UInt4Vector offsets;
- private PromotableWriter writer;
+ protected PromotableWriter writer;
Review comment:
nit: move the `protected` field on top of the `private` fields declaration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services