[jira] Commented: (TUSCANY-2553) Fix the Policy model

["Jean-Sebastien Delfino (JIRA)" <de...@tuscany.apache.org>]

    [ https://issues.apache.org/jira/browse/TUSCANY-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623574#action_12623574 ] 

Jean-Sebastien Delfino commented on TUSCANY-2553:
-------------------------------------------------

I forgot one important aspect: the model does not need to be an exact representation of the XML syntax for declaring and describing policies, but it needs to be a good logical model representing these entities. Again a UML diagram will make things clear, and will quickly show that trying to represent the exact XML policy syntax produces a clunky model.

> Fix the Policy model
> --------------------
>
>                 Key: TUSCANY-2553
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2553
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Assembly Model
>            Reporter: Jean-Sebastien Delfino
>             Fix For: Java-SCA-Next
>
>
> The policy model needs the following improvements:
> - Consistency, for example only have a List<Xyz> getXyz() method for 0..n relationships, no setter method, like we have in the other models.
> - No information duplication, remove fields that duplicate information available somewhere else in the models, or which can be derived from existing information.
> - No legacy, remove temporary fields and methods that are not used or not really needed anymore.
> - Make sure that all get/read methods have no side effects and keep the model unchanged. 
> - Move any model processing logic out of the model classes, to 'processors', 'builders' or 'utilities', or whatever you want to call them.
> - Proper Policy -> Assembly relationships, representing the natural "a Policy *qualifies* an Assembly object" instead of the current relationships, which are mostly Assembly -> Policy, basically backwards.
> I suggest to start with a UML diagram, which will make the above issues appear obvious, then ensure that the model interfaces match the UML.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.