You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/27 08:17:38 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
MaxGekk opened a new pull request #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047
### What changes were proposed in this pull request?
In the PR, I propose 2 tests to check that rebasing of timestamps from/to the hybrid calendar (Julian + Gregorian) to/from Proleptic Gregorian calendar works correctly.
1. The test `compatibility with Spark 2.4 in reading timestamps` load ORC file saved by Spark 2.4.5 via:
```shell
$ export TZ="America/Los_Angeles"
```
```scala
scala> spark.conf.set("spark.sql.session.timeZone", "America/Los_Angeles")
scala> val df = Seq("1001-01-01 01:02:03.123456").toDF("tsS").select($"tsS".cast("timestamp").as("ts"))
df: org.apache.spark.sql.DataFrame = [ts: timestamp]
scala> df.write.orc("/Users/maxim/tmp/before_1582/2_4_5_ts_orc")
scala> spark.read.orc("/Users/maxim/tmp/before_1582/2_4_5_ts_orc").show(false)
+--------------------------+
|ts |
+--------------------------+
|1001-01-01 01:02:03.123456|
+--------------------------+
```
2. The test `rebasing timestamps in write` is round trip test. Since the previous test confirms correct rebasing of timestamps in read. This test should pass only if rebasing works correctly in write.
### Why are the changes needed?
To guarantee that rebasing works correctly for timestamps in ORC datasource.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
By running `OrcSourceSuite` for Hive 1.2 and 2.3 via the commands:
```
$ build/sbt -Phive-2.3 "test:testOnly *OrcSourceSuite"
```
and
```
$ build/sbt -Phive-1.2 "test:testOnly *OrcSourceSuite"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-604875981
**[Test build #120473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120473/testReport)** for PR 28047 at commit [`5a04bbf`](https://github.com/apache/spark/commit/5a04bbf79a1df9cf925c988faa7b97b8d51fc643).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-604876450
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25179/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-605016083
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120473/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-604873703
@cloud-fan @HyukjinKwon @dongjoon-hyun Please, review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-604875981
**[Test build #120473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120473/testReport)** for PR 28047 at commit [`5a04bbf`](https://github.com/apache/spark/commit/5a04bbf79a1df9cf925c988faa7b97b8d51fc643).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-604876444
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-605016083
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120473/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-605016068
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-605014964
**[Test build #120473 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120473/testReport)** for PR 28047 at commit [`5a04bbf`](https://github.com/apache/spark/commit/5a04bbf79a1df9cf925c988faa7b97b8d51fc643).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-605372513
I made a follow-up.
- https://github.com/apache/spark/pull/28059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-604876450
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25179/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-604887129
> this PR adds similar test cases for timestamp, right?
@dongjoon-hyun Right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-604879013
So, like SPARK-31238 added test cases for `date`, this PR adds similar test cases for `timestamp`, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-604876444
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28047:
[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28047: [SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource
URL: https://github.com/apache/spark/pull/28047#issuecomment-605016068
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org