You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "bjornjorgensen (via GitHub)" <gi...@apache.org> on 2023/11/19 21:32:22 UTC

[PR] [SPARK-45994][PYTHON] Change `description-file` to `description_file` [spark]

bjornjorgensen opened a new pull request, #43891:
URL: https://github.com/apache/spark/pull/43891

   ### What changes were proposed in this pull request?
   Change `description-file` to `description_file`
   
   ### Why are the changes needed?
   
   + echo 'Building python distribution package'
   Building python distribution package
   + pushd /home/bjorn/spark/python
   + rm -rf pyspark.egg-info
   + python3 setup.py sdist
   /usr/lib/python3.11/site-packages/setuptools/dist.py:745: SetuptoolsDeprecationWarning: Invalid dash-separated options
   !!
   
           ********************************************************************************
           Usage of dash-separated 'description-file' will not be supported in future
           versions. Please use the underscore name 'description_file' instead.
   
           This deprecation is overdue, please update your project and remove deprecated
           calls to avoid build errors in the future.
   
           See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
           ********************************************************************************
   
   !!
     opt = self.warn_dash_deprecation(opt, section)
   running sdist
   running egg_info
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45994][PYTHON] Change `description-file` to `description_file` [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43891:
URL: https://github.com/apache/spark/pull/43891#issuecomment-1818042044

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45994][PYTHON] Change `description-file` to `description_file` [spark]

Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #43891:
URL: https://github.com/apache/spark/pull/43891#issuecomment-1817984984

   Link to runner https://github.com/bjornjorgensen/spark/actions/runs/6923037435


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45994][PYTHON] Change `description-file` to `description_file` [spark]

Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #43891:
URL: https://github.com/apache/spark/pull/43891#issuecomment-1817985902

   For more info on this one [Does description-file in setup.cfg, section "metadata" have any effect?](https://stackoverflow.com/questions/60084128/does-description-file-in-setup-cfg-section-metadata-have-any-effect)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45994][PYTHON] Change `description-file` to `description_file` [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43891: [SPARK-45994][PYTHON] Change `description-file` to `description_file`
URL: https://github.com/apache/spark/pull/43891


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org