[GitHub] [arrow] pitrou commented on a change in pull request #8457: ARROW-9164: [C++] Add embedded documentation to compute functions

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #8457:
URL: https://github.com/apache/arrow/pull/8457#discussion_r505564859



##########
File path: cpp/src/arrow/compute/function.h
##########
@@ -137,19 +169,23 @@ class ARROW_EXPORT Function {
   /// that default_options() is valid to pass to Execute as options.
   const FunctionOptions* default_options() const { return default_options_; }
 
+  virtual Status Validate() const;
+
  protected:
-  Function(std::string name, Function::Kind kind, const Arity& arity,
+  Function(std::string name, Function::Kind kind, const Arity& arity, FunctionDoc doc,
            const FunctionOptions* default_options)
       : name_(std::move(name)),
         kind_(kind),
         arity_(arity),
+        doc_(std::move(doc)),
         default_options_(default_options) {}
 
   Status CheckArity(int passed_num_args) const;
 
   std::string name_;
   Function::Kind kind_;
   Arity arity_;
+  FunctionDoc doc_;
   const FunctionOptions* default_options_ = NULLPTR;

Review comment:
       Why not, do you think there's any chance of them being dynamically generated?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org