[jira] Commented: (WW-3329) ${Parameters.xxx} in freemarker view is broken

["zhouyanming (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/struts/browse/WW-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47237#action_47237 ] 

zhouyanming commented on WW-3329:
---------------------------------

it works fine for Parameters.xxx

but there is another problem

if (session != null) {
            sessionModel = (HttpSessionHashModel) session.getAttribute(ATTR_SESSION_MODEL);
            if (sessionModel == null) {
                sessionModel = new HttpSessionHashModel(session, wrapper);
                session.setAttribute(ATTR_SESSION_MODEL, sessionModel);
            }
            model.put(KEY_SESSION, new HttpSessionHashModel(session, wrapper));
        }

some app store session into shared memory or database for SNA,and objects in session is the less the better
so I don't think it's necessary to put sessionModel into session,It's better construct it during every request.

> ${Parameters.xxx} in freemarker view is broken
> ----------------------------------------------
>
>                 Key: WW-3329
>                 URL: https://issues.apache.org/struts/browse/WW-3329
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 2.2.0
>            Reporter: zhouyanming
>            Assignee: Musachy Barroso
>            Priority: Blocker
>             Fix For: 2.2.0
>
>         Attachments: patch.diff
>
>
> "Parameters" was instead by ".freemarker.RequestParameters" in FreemakerManager
> protected ScopesHashModel buildScopesHashModel(
> 			ServletContext servletContext, HttpServletRequest request,
> 			HttpServletResponse response, ObjectWrapper wrapper,
> 			ValueStack stack) ;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.