You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/04/09 21:51:00 UTC
[jira] [Commented] (KAFKA-8200) TopologyTestDriver should offer an
iterable signature of readOutput
[ https://issues.apache.org/jira/browse/KAFKA-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813847#comment-16813847 ]
ASF GitHub Bot commented on KAFKA-8200:
---------------------------------------
pkleindl commented on pull request #6556: KAFKA-8200: added Iterator methods for output to TopologyTestDriver
URL: https://github.com/apache/kafka/pull/6556
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> TopologyTestDriver should offer an iterable signature of readOutput
> -------------------------------------------------------------------
>
> Key: KAFKA-8200
> URL: https://issues.apache.org/jira/browse/KAFKA-8200
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Michael Drogalis
> Priority: Minor
> Labels: needs-kip
>
> When using the TopologyTestDriver, one examines the output on a topic with the readOutput method. This method returns one record at a time, until no more records can be found, at which point in returns null.
> Many times, the usage pattern around readOutput will involve writing a loop to extract a number of records from the topic, building up a list of records, until it returns null.
> It would be helpful to offer an iterable signature of readOutput, which returns either an iterator or list over the records that are currently available in the topic. This would effectively remove the loop that a user needs to write for him/herself each time.
> Such a signature might look like:
> {code:java}
> public Iterable<ProducerRecord<byte[],byte[]>> readOutput(java.lang.String topic);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)