[GitHub] [arrow] projjal commented on a change in pull request #10040: ARROW-11565: [C++][Gandiva] Modify upper()/lower() logic to make them work for utf8 strings

[GitBox <gi...@apache.org>]

projjal commented on a change in pull request #10040:
URL: https://github.com/apache/arrow/pull/10040#discussion_r622727913



##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -1000,5 +1172,47 @@ void ExportedStubFunctions::AddMappings(Engine* engine) const {
   engine->AddGlobalMappingForFunc("gdv_fn_sha256_decimal128",
                                   types->i8_ptr_type() /*return_type*/, args,
                                   reinterpret_cast<void*>(gdv_fn_sha256_decimal128));
+
+  // gdv_fn_utf8_char_length
+  args = {

Review comment:
       you don't need to register these here. only upper/lower is enough.

##########
File path: ci/scripts/python_wheel_manylinux_build.sh
##########
@@ -64,6 +64,7 @@ echo "=== (${PYTHON_VERSION}) Building Arrow C++ libraries ==="
 : ${ARROW_WITH_LZ4:=ON}
 : ${ARROW_WITH_SNAPPY:=ON}
 : ${ARROW_WITH_ZLIB:=ON}
+: ${ARROW_WITH_UTF8PROC:=ON}

Review comment:
       Are these necessary?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org