You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/10/18 09:07:00 UTC
[jira] [Updated] (FLINK-33295) Separate SinkV2 and SinkV1Adapter tests
[ https://issues.apache.org/jira/browse/FLINK-33295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated FLINK-33295:
-----------------------------------
Labels: pull-request-available (was: )
> Separate SinkV2 and SinkV1Adapter tests
> ---------------------------------------
>
> Key: FLINK-33295
> URL: https://issues.apache.org/jira/browse/FLINK-33295
> Project: Flink
> Issue Type: Sub-task
> Components: API / DataStream, Connectors / Common
> Reporter: Peter Vary
> Priority: Major
> Labels: pull-request-available
>
> Current SinkV2 tests are based on the sink generated by the _org.apache.flink.streaming.runtime.operators.sink.TestSink_ test class. This test class does not generate the SinkV2 directly, but generates a SinkV1 and wraps in with a _org.apache.flink.streaming.api.transformations.SinkV1Adapter._ While this tests the SinkV2, but only as it is aligned with SinkV1, and the SinkV1Adapter.
> We should have tests where we create a SinkV2 directly and the functionality is tested without the adapter.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)