You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/10 23:01:20 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #869: Fix #865
Re-org the source tree
ppalaga opened a new pull request #869: Fix #865 Re-org the source tree
URL: https://github.com/apache/camel-quarkus/pull/869
Fix #865
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #869: Fix #865 Re-org the source tree
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #869: Fix #865 Re-org the source tree
URL: https://github.com/apache/camel-quarkus/pull/869#discussion_r390780124
##########
File path: docs/modules/ROOT/pages/list-of-camel-quarkus-extensions.adoc
##########
@@ -312,49 +312,31 @@ Number of Camel data formats: 23 in 18 JAR artifacts (0 deprecated)
== Camel Languages
// languages: START
-Number of Camel languages: 11 in 5 JAR artifacts (0 deprecated)
+Number of Camel languages: 3 in 3 JAR artifacts (0 deprecated)
Review comment:
Is it expected that extensions are removed from here? We should be listing all of the stuff that camel-quarkus supports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga merged pull request #869: Fix #865 Re-org
the source tree
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #869: Fix #865 Re-org the source tree
URL: https://github.com/apache/camel-quarkus/pull/869
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #869:
Fix #865 Re-org the source tree
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #869: Fix #865 Re-org the source tree
URL: https://github.com/apache/camel-quarkus/pull/869#discussion_r390782306
##########
File path: docs/modules/ROOT/pages/list-of-camel-quarkus-extensions.adoc
##########
@@ -312,49 +312,31 @@ Number of Camel data formats: 23 in 18 JAR artifacts (0 deprecated)
== Camel Languages
// languages: START
-Number of Camel languages: 11 in 5 JAR artifacts (0 deprecated)
+Number of Camel languages: 3 in 3 JAR artifacts (0 deprecated)
Review comment:
No, thanks for spotting it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#869: Fix #865 Re-org the source tree
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #869: Fix #865 Re-org the source tree
URL: https://github.com/apache/camel-quarkus/pull/869#discussion_r390837444
##########
File path: tooling/scripts/sort-poms.groovy
##########
@@ -187,14 +188,16 @@ void sortModules(String[] sortModulesPaths) {
void updateMvndRules(String[] updateMvndRuleDirs) {
final Set<String> extensionArtifactIds = [] as TreeSet
- Files.list(baseDir.resolve('extensions'))
+ Stream.of('extensions', 'extensions-core')
Review comment:
not very groovysh :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #869:
Fix #865 Re-org the source tree
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #869: Fix #865 Re-org the source tree
URL: https://github.com/apache/camel-quarkus/pull/869#discussion_r390840183
##########
File path: tooling/scripts/sort-poms.groovy
##########
@@ -187,14 +188,16 @@ void sortModules(String[] sortModulesPaths) {
void updateMvndRules(String[] updateMvndRuleDirs) {
final Set<String> extensionArtifactIds = [] as TreeSet
- Files.list(baseDir.resolve('extensions'))
+ Stream.of('extensions', 'extensions-core')
Review comment:
Yes, I am a proper Groovy noob! If there was a plugin to run Java as a script, I'd very much prefer writing it in Java :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #869: Fix #865 Re-org
the source tree
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #869: Fix #865 Re-org the source tree
URL: https://github.com/apache/camel-quarkus/pull/869#issuecomment-597520525
202430f eliminates the missing languages in the .adoc files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services