You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by "Aled Sage (JIRA)" <ji...@apache.org> on 2018/01/30 10:07:00 UTC
[jira] [Commented] (BROOKLYN-461) Merging config keys:
CollectionMerger.Ref.equals always return true
[ https://issues.apache.org/jira/browse/BROOKLYN-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344802#comment-16344802 ]
Aled Sage commented on BROOKLYN-461:
------------------------------------
Ignore [https://github.com/apache/brooklyn-server/pull/893] - it has nothing to do with this issue; that PR fixes BROOKLYN-561 (i.e. a typo in PR message).
> Merging config keys: CollectionMerger.Ref.equals always return true
> -------------------------------------------------------------------
>
> Key: BROOKLYN-461
> URL: https://issues.apache.org/jira/browse/BROOKLYN-461
> Project: Brooklyn
> Issue Type: Bug
> Reporter: JC
> Assignee: Aled Sage
> Priority: Trivial
> Fix For: 0.11.0
>
>
> Hi
> In recent github mirror of broolyn-server, I've found the following issue in equals implementation.
> Path: utils/common/src/main/java/org/apache/brooklyn/util/collections/CollectionMerger.java
> {code}
> 196
> 197 @Override
> 198 public boolean equals(Object o) {
> 199 if (!(o instanceof Ref)) {
> 200 return false;
> 201 }
> 202 return ((Ref)o).obj == ((Ref)o).obj;
> 203 }
> {code}
> Line 202 should be like this?
> {code}
> 202 return this.obj == ((Ref)o).obj;
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)