[GitHub] [geode-native] pivotal-jbarrett opened pull request #426: GEODE-6239: Updates third party dependencies.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

- Updates ACE to 6.5.3
- Updates GTest to 1.8.1
- Updates OpenSSL to 1.1.1a
- Updated to use more modern CMake patterns.
- Fixes mutli config builds.

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

And once more

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

Huh? It’s a 256bit SHA, what name would you like?

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

Again with the typo

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

Typo here - SHA265 is not a thing.  Yeah, I see it was there already.  

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

What the what??? I don't get it.  Is the typo intentional because of a name conflict or something?  Is the variable used anywhere else?  If not, can we just use the raw hash here and get rid of the poorly-named variable altogether?

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

No. This replaces older code in this file that attempted the same thing poorly. What this does is default to Debug if a build type was not provided and our generator is not a multi config generator (Xcode, VS).

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

again

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

Again

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

Heh - thanks

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

No. The replaces older code in this file that attempted the same thing poorly. What this does is default to Debug if a build type was not provided and our generator is not a multi config generator (Xcode, VS).

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

One last time

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

What doe you mean it’s not a thing? It’s a variable to configure the sha used to verify the version, now specified in the project declaration.

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

You’re the first to notice this since the beginning of time on theses files! Hahah.

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

... and again

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett closed pull request #426: GEODE-6239: Updates third party dependencies.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

[ pull request closed by pivotal-jbarrett ]

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

Copy paste

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

Is this really a thing?  Do we have a platform for which we only build debug?

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on issue #426: GEODE-6239: Updates third party dependencies.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

@pdxcodemonkey Ok, fixed that spelling mistake. Please re-review.

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #426: GEODE-6239: Updates third party dependencies.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

Oh dyslexia! I’ll fix!

[ Full content available at: https://github.com/apache/geode-native/pull/426 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org