You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2017/04/06 00:43:36 UTC
Review Request 58228: Perf: Refactor ambari db-cleanup to include all
big tables
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58228/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-20687
https://issues.apache.org/jira/browse/AMBARI-20687
Repository: ambari
Description
-------
Add check for large tables into db consistency check.
Add code to cleanup these tables into db-cleanup code.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java e7e9433
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java c132a3d
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 1dd3b54
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExecutionCommandDAO.java 7a3bc01
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 79b8bc9
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 2696f66
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java c2919b2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExecutionCommandEntity.java 85f3a25
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java a809295
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java f19aa72
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java ff14e3a
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestResourceFilterEntity.java 8ee41d2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RoleSuccessCriteriaEntity.java 3386c24
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java 49c1594
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostRequestEntity.java b90e192
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java c71d4e4
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 7421ca1
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java 560970a
ambari-server/src/main/python/ambari-server.py 87cc6c2
ambari-server/src/main/python/ambari_server/dbCleanup.py abc8267
ambari-server/src/main/resources/stacks/HDP/2.3.ECS/repos/repoinfo.xml 329539e
ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/repos/repoinfo.xml ad79215
ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml 81a70a5
ambari-server/src/main/resources/stacks/HDP/3.0/repos/repoinfo.xml 5145064
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java 7d8ba50
Diff: https://reviews.apache.org/r/58228/diff/1/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include
all big tables
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58228/#review171188
-----------------------------------------------------------
I still need to go through the rest of the code review. Please wait until others have also given feedback.
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
Lines 234 (patched)
<https://reviews.apache.org/r/58228/#comment244067>
Let's call this checkForLargeTables
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
Lines 247 (patched)
<https://reviews.apache.org/r/58228/#comment244068>
Does this work on all DB types that we support?
SQLServer and SQLAnywhere?
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
Lines 257 (patched)
<https://reviews.apache.org/r/58228/#comment244069>
We should find out which type the DB is and only add the query that is needed.
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
Lines 280 (patched)
<https://reviews.apache.org/r/58228/#comment244070>
we should also log what the limit is.
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
Lines 283 (patched)
<https://reviews.apache.org/r/58228/#comment244071>
Use String.format
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExecutionCommandDAO.java
Lines 64 (patched)
<https://reviews.apache.org/r/58228/#comment244072>
Does this need a limit with a WHERE clause?
- Alejandro Fernandez
On April 6, 2017, 12:45 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58228/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 12:45 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-20687
> https://issues.apache.org/jira/browse/AMBARI-20687
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add check for large tables into db consistency check.
> Add code to cleanup these tables into db-cleanup code.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java e7e9433
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java c132a3d
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 1dd3b54
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExecutionCommandDAO.java 7a3bc01
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 79b8bc9
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 2696f66
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java c2919b2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExecutionCommandEntity.java 85f3a25
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java a809295
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java f19aa72
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java ff14e3a
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestResourceFilterEntity.java 8ee41d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RoleSuccessCriteriaEntity.java 3386c24
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java 49c1594
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostRequestEntity.java b90e192
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java c71d4e4
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 7421ca1
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java 560970a
> ambari-server/src/main/python/ambari-server.py 87cc6c2
> ambari-server/src/main/python/ambari_server/dbCleanup.py abc8267
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java 7d8ba50
>
>
> Diff: https://reviews.apache.org/r/58228/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include
all big tables
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58228/
-----------------------------------------------------------
(Updated \u041a\u0432\u0456\u0442\u0435\u043d\u044c 6, 2017, 12:45 \u0434\u043e \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-20687
https://issues.apache.org/jira/browse/AMBARI-20687
Repository: ambari
Description
-------
Add check for large tables into db consistency check.
Add code to cleanup these tables into db-cleanup code.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java e7e9433
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java c132a3d
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 1dd3b54
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExecutionCommandDAO.java 7a3bc01
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 79b8bc9
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 2696f66
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java c2919b2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExecutionCommandEntity.java 85f3a25
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java a809295
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java f19aa72
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java ff14e3a
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestResourceFilterEntity.java 8ee41d2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RoleSuccessCriteriaEntity.java 3386c24
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java 49c1594
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostRequestEntity.java b90e192
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java c71d4e4
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 7421ca1
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java 560970a
ambari-server/src/main/python/ambari-server.py 87cc6c2
ambari-server/src/main/python/ambari_server/dbCleanup.py abc8267
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java 7d8ba50
Diff: https://reviews.apache.org/r/58228/diff/2/
Changes: https://reviews.apache.org/r/58228/diff/1-2/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi