[GitHub] [ignite] nizhikov commented on a diff in pull request #10165: IGNITE-15837 Read Repair should support binary keys

[GitBox <gi...@apache.org>]

nizhikov commented on code in PR #10165:
URL: https://github.com/apache/ignite/pull/10165#discussion_r930100376


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java:
##########
@@ -700,7 +700,7 @@ public void onKernalStop() {
             /*force primary*/ !ctx.config().isReadFromBackup(),
             /*skip tx*/false,
             /*task name*/null,
-            /*deserialize binary*/false,
+            !ctx.keepBinary(),

Review Comment:
   Why binary deserialization can be required here?



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java:
##########
@@ -736,7 +736,7 @@ public void onKernalStop() {
             /*force primary*/ !ctx.config().isReadFromBackup(),
             /*skip tx*/false,
             /*task name*/null,
-            /*deserialize binary*/false,
+            !ctx.keepBinary(),

Review Comment:
   Why binary deserialization can be required here?



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java:
##########
@@ -5121,7 +5121,7 @@ private IgniteInternalFuture<Void> repairTxAsync(
                 ctx.operationContextPerCall(opCtx);
 
                 try (Transaction tx = ctx.grid().transactions().txStart(PESSIMISTIC, SERIALIZABLE)) {
-                    get((K)key, null, false, false); // Repair.
+                    get((K)key, null, !ctx.keepBinary(), false); // Repair.

Review Comment:
   Why binary deserialization can be required here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org