[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #9346: improve helm chart

[GitBox <gi...@apache.org>]

craig-rueda commented on a change in pull request #9346: improve helm chart
URL: https://github.com/apache/incubator-superset/pull/9346#discussion_r405701435
 
 

 ##########
 File path: install/helm/superset/values.yaml
 ##########
 @@ -54,6 +54,132 @@ resources: {}
   # requests:
   #   cpu: 100m
   #   memory: 128Mi
+#Superset node configuration
+supersetNode:
+  connections: 
+    redis_host: superset-redis-headless
+    redis_port: "6379"
+    db_host: superset-postgresql
+    db_port: "5432"
+    db_user: superset
+    db_pass: superset
+    db_name: superset
+
+# -----------------------------------------------------------------------------
+# Miscellaneous parameters
+# -----------------------------------------------------------------------------
+
+init:
+  enabled: true
+  waitImage:
+    repository: busybox
+    tag: latest
+    pullPolicy: IfNotPresent
+  initscript: |-
+    superset fab create-admin \
 
 Review comment:
   I think you got things a bit out of order here. Should be:
   
   ```
   superset db upgrade
   superset init
   superset fab create-admin ...
   ```
   
   Also, please add `|| true` to the end of the fab admin command as to make it idempotent. We want this thing to run for each upgrade of Superset so that the DB stays up to date.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org