You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lens.apache.org by pr...@apache.org on 2015/05/27 16:31:52 UTC
[1/3] incubator-lens git commit: LENS-551: Cleanup testcases of
exception stack traces
Repository: incubator-lens
Updated Branches:
refs/heads/master 82553db30 -> b0783db79
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
----------------------------------------------------------------------
diff --git a/lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java b/lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
index 885a69a..dc1dc1d 100644
--- a/lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
+++ b/lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
@@ -54,8 +54,6 @@ import org.apache.hadoop.hive.metastore.api.FieldSchema;
import org.apache.hadoop.hive.ql.session.SessionState;
import org.apache.hadoop.mapred.SequenceFileInputFormat;
import org.apache.log4j.BasicConfigurator;
-import org.apache.log4j.LogManager;
-import org.apache.log4j.Logger;
import org.glassfish.jersey.client.ClientConfig;
import org.glassfish.jersey.media.multipart.FormDataBodyPart;
@@ -67,9 +65,11 @@ import org.testng.annotations.AfterTest;
import org.testng.annotations.BeforeTest;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
+@Slf4j
@Test(groups = "unit-test")
public class TestMetastoreService extends LensJerseyTest {
- public static final Logger LOG = LogManager.getLogger(TestMetastoreService.class);
private ObjectFactory cubeObjectFactory;
protected String mediaType = MediaType.APPLICATION_XML;
protected MediaType medType = MediaType.APPLICATION_XML_TYPE;
@@ -152,7 +152,7 @@ public class TestMetastoreService extends LensJerseyTest {
result = dbTarget.queryParam("sessionid", lensSessionId).queryParam("ignoreIfExisting", false)
.request(mediaType).post(Entity.xml(newDb), APIResult.class);
assertEquals(result.getStatus(), APIResult.Status.FAILED);
- LOG.info(">> Result message " + result.getMessage());
+ log.info(">> Result message " + result.getMessage());
// Drop
dbTarget.path(newDb).queryParam("sessionid", lensSessionId).request().delete();
@@ -768,7 +768,7 @@ public class TestMetastoreService extends LensJerseyTest {
.get(new GenericType<JAXBElement<XCube>>() {});
fail("Should have thrown 404, got:" + got);
} catch (NotFoundException ex) {
- ex.printStackTrace();
+ log.error("Resource not found.", ex);
}
target = target().path("metastore").path("cubes").path("test_drop_cube");
@@ -782,7 +782,7 @@ public class TestMetastoreService extends LensJerseyTest {
.get(new GenericType<JAXBElement<XCube>>() {});
fail("Should have thrown 404, got :" + got);
} catch (NotFoundException ex) {
- ex.printStackTrace();
+ log.error("Resource not found.", ex);
}
} finally {
dropDatabase(DB);
@@ -1222,7 +1222,7 @@ public class TestMetastoreService extends LensJerseyTest {
mediaType).get(new GenericType<JAXBElement<XDimension>>() {});
fail("Should have thrown 404, but got" + got.getValue().getName());
} catch (NotFoundException ex) {
- ex.printStackTrace();
+ log.error("Resource not found.", ex);
}
try {
@@ -1230,7 +1230,7 @@ public class TestMetastoreService extends LensJerseyTest {
.queryParam("sessionid", lensSessionId).request(mediaType).delete(APIResult.class);
fail("Should have thrown 404, but got" + result.getStatus());
} catch (NotFoundException ex) {
- ex.printStackTrace();
+ log.error("Resource not found.", ex);
}
} finally {
dropDatabase(DB);
@@ -1264,7 +1264,7 @@ public class TestMetastoreService extends LensJerseyTest {
.queryParam("sessionid", lensSessionId).request(mediaType).delete(APIResult.class);
fail("Should have got 404");
} catch (NotFoundException e404) {
- LOG.info("correct");
+ log.info("correct");
}
} finally {
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
----------------------------------------------------------------------
diff --git a/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java b/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
index dc243aa..62c24ba 100644
--- a/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
+++ b/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
@@ -63,8 +63,6 @@ import org.apache.lens.server.error.LensExceptionMapper;
import org.apache.lens.server.session.HiveSessionService;
import org.apache.lens.server.session.LensSessionImpl;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.FSDataInputStream;
import org.apache.hadoop.fs.FileStatus;
@@ -85,15 +83,15 @@ import org.testng.annotations.Test;
import com.codahale.metrics.MetricRegistry;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class TestQueryService.
*/
+@Slf4j
@Test(groups = "unit-test")
public class TestQueryService extends LensJerseyTest {
- /** The Constant LOG. */
- public static final Log LOG = LogFactory.getLog(TestQueryService.class);
-
/** The query service. */
QueryExecutionServiceImpl queryService;
@@ -736,7 +734,7 @@ public class TestQueryService extends LensJerseyTest {
}
// Test http download end point
- LOG.info("Starting httpendpoint test");
+ log.info("Starting httpendpoint test");
final FormDataMultiPart mp3 = new FormDataMultiPart();
mp3.bodyPart(new FormDataBodyPart(FormDataContentDisposition.name("sessionid").build(), lensSessionId,
MediaType.APPLICATION_XML_TYPE));
@@ -894,7 +892,7 @@ public class TestQueryService extends LensJerseyTest {
*/
static void validateHttpEndPoint(WebTarget parent, LensSessionHandle lensSessionId, QueryHandle handle,
String redirectUrl) throws IOException {
- LOG.info("@@@ validateHttpEndPoint sessionid " + lensSessionId);
+ log.info("@@@ validateHttpEndPoint sessionid " + lensSessionId);
Response response = parent.path("queryapi/queries/" + handle.toString() + "/httpresultset")
.queryParam("sessionid", lensSessionId).request().get();
@@ -933,7 +931,7 @@ public class TestQueryService extends LensJerseyTest {
Assert.assertEquals(response.getStatus(), Response.Status.NOT_FOUND.getStatusCode());
} catch (NotFoundException e) {
// expected
- e.printStackTrace();
+ log.error("Resource not found.", e);
}
}
@@ -1348,7 +1346,7 @@ public class TestQueryService extends LensJerseyTest {
File testJarFile = new File("testdata/test2.jar");
sessionService.addResourceToAllServices(sessionHandle, "jar", "file://" + testJarFile.getAbsolutePath());
- LOG.info("@@@ Opened session " + sessionHandle.getPublicId() + " with database " + LensTestUtil.DB_WITH_JARS);
+ log.info("@@@ Opened session " + sessionHandle.getPublicId() + " with database " + LensTestUtil.DB_WITH_JARS);
LensSessionImpl session = sessionService.getSession(sessionHandle);
// Jars should be pending until query is run
@@ -1373,7 +1371,7 @@ public class TestQueryService extends LensJerseyTest {
Assert.assertTrue(addedToHiveDriver);
// Switch database
- LOG.info("@@@# database switch test");
+ log.info("@@@# database switch test");
session.setCurrentDatabase(LensTestUtil.DB_WITH_JARS_2);
LensTestUtil.createTable(tableInDBWithJars + "_2", target(), sessionHandle, "(ID INT, IDSTR STRING) "
+ "ROW FORMAT SERDE \"DatabaseJarSerde\"");
@@ -1393,12 +1391,12 @@ public class TestQueryService extends LensJerseyTest {
Assert.assertTrue(session.getPendingSessionResourcesForDatabase(LensTestUtil.DB_WITH_JARS_2).isEmpty());
} finally {
- LOG.info("@@@ TEST_OVER");
+ log.info("@@@ TEST_OVER");
try {
LensTestUtil.dropTable(tableInDBWithJars, target(), sessionHandle);
LensTestUtil.dropTable(tableInDBWithJars + "_2", target(), sessionHandle);
} catch (Throwable th) {
- th.printStackTrace();
+ log.error("Exception while dropping table.", th);
}
sessionService.closeSession(sessionHandle);
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java
----------------------------------------------------------------------
diff --git a/lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java b/lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java
index 640cc41..28bed27 100644
--- a/lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java
+++ b/lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java
@@ -27,8 +27,6 @@ import java.util.List;
import org.apache.lens.server.LensTestUtil;
import org.apache.lens.server.api.LensConfConstants;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.hive.conf.HiveConf;
import org.apache.hadoop.hive.ql.metadata.Hive;
@@ -37,9 +35,11 @@ import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
+@Slf4j
public class TestDatabaseResourceService {
private static final String DB_PFX = TestDatabaseResourceService.class.getSimpleName();
- public static final Log LOG = LogFactory.getLog(TestDatabaseResourceService.class);
public static final String TEST_CLASS = "ClassLoaderTestClass";
@@ -85,7 +85,7 @@ public class TestDatabaseResourceService {
for (URL url : db1Loader.getURLs()) {
String jarFile = url.getPath();
if (jarFile.endsWith(db + ".jar")) {
- LOG.info("Found jar url " + url.toString());
+ log.info("Found jar url " + url.toString());
return true;
}
}
@@ -132,7 +132,7 @@ public class TestDatabaseResourceService {
Class clz = Class.forName("ClassLoaderTestClass", true, getClass().getClassLoader());
Assert.fail("Expected class loading to fail");
} catch (Throwable th) {
- LOG.error("Expected error " + th + " msg = "+th.getMessage());
+ log.error("Expected error " + th + " msg = "+th.getMessage(), th);
}
// Should pass now
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java
----------------------------------------------------------------------
diff --git a/lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java b/lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java
index bf0526f..d5e60c4 100644
--- a/lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java
+++ b/lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java
@@ -37,9 +37,12 @@ import org.testng.annotations.AfterMethod;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class TestStatisticsLogFileScannerTask.
*/
+@Slf4j
@Test(groups = "unit-test")
public class TestStatisticsLogFileScannerTask {
@@ -100,7 +103,7 @@ public class TestStatisticsLogFileScannerTask {
}
}).when(service).notifyEvent(Mockito.any(PartitionEvent.class));
} catch (Exception e) {
- e.printStackTrace();
+ log.error("Error while running test.", e);
}
task.setService(service);
task.run();
[2/3] incubator-lens git commit: LENS-551: Cleanup testcases of
exception stack traces
Posted by pr...@apache.org.
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java
----------------------------------------------------------------------
diff --git a/lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java b/lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java
index c08a5b1..51344ce 100644
--- a/lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java
+++ b/lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java
@@ -42,8 +42,6 @@ import org.apache.lens.server.api.LensConfConstants;
import org.apache.lens.server.query.QueryServiceResource;
import org.apache.lens.server.session.SessionResource;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.hive.conf.HiveConf;
import org.apache.hadoop.hive.metastore.api.Database;
import org.apache.hadoop.hive.ql.metadata.Hive;
@@ -59,11 +57,12 @@ import org.testng.annotations.BeforeMethod;
import org.testng.annotations.BeforeTest;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
-
+@Slf4j
@Test
public class TestMLResource extends LensJerseyTest {
- private static final Log LOG = LogFactory.getLog(TestMLResource.class);
+
private static final String TEST_DB = "default";
private WebTarget mlTarget;
@@ -113,7 +112,7 @@ public class TestMLResource extends LensJerseyTest {
hive.dropDatabase(TEST_DB);
} catch (Exception exc) {
// Ignore drop db exception
- exc.printStackTrace();
+ log.error("Exception while dropping database.", exc);
}
mlClient.close();
}
@@ -158,13 +157,13 @@ public class TestMLResource extends LensJerseyTest {
Assert.assertFalse(params.isEmpty());
for (String key : params.keySet()) {
- LOG.info("## Param " + key + " help = " + params.get(key));
+ log.info("## Param " + key + " help = " + params.get(key));
}
}
@Test
public void trainAndEval() throws Exception {
- LOG.info("Starting train & eval");
+ log.info("Starting train & eval");
final String algoName = MLUtils.getAlgoName(NaiveBayesAlgo.class);
HiveConf conf = new HiveConf();
String tableName = "naivebayes_training_table";
@@ -177,7 +176,7 @@ public class TestMLResource extends LensJerseyTest {
String[] features = { "feature_1", "feature_2", "feature_3" };
String outputTable = "naivebayes_eval_table";
- LOG.info("Creating training table from file "
+ log.info("Creating training table from file "
+ sampleDataFileURI.toString());
Map<String, String> tableParams = new HashMap<String, String>();
@@ -185,7 +184,7 @@ public class TestMLResource extends LensJerseyTest {
ExampleUtils.createTable(conf, TEST_DB, tableName,
sampleDataFileURI.toString(), labelColumn, tableParams, features);
} catch (HiveException exc) {
- exc.printStackTrace();
+ log.error("Hive exception encountered.", exc);
}
MLTask.Builder taskBuilder = new MLTask.Builder();
@@ -198,7 +197,7 @@ public class TestMLResource extends LensJerseyTest {
MLTask task = taskBuilder.build();
- LOG.info("Created task " + task.toString());
+ log.info("Created task " + task.toString());
task.run();
Assert.assertEquals(task.getTaskState(), MLTask.State.SUCCESSFUL);
@@ -216,7 +215,7 @@ public class TestMLResource extends LensJerseyTest {
MLTask anotherTask = taskBuilder.build();
- LOG.info("Created second task " + anotherTask.toString());
+ log.info("Created second task " + anotherTask.toString());
anotherTask.run();
String secondModelID = anotherTask.getModelID();
@@ -233,7 +232,7 @@ public class TestMLResource extends LensJerseyTest {
int i = 0;
Set<String> partReports = new HashSet<String>();
for (Partition part : partitions) {
- LOG.info("@@PART#" + i + " " + part.getSpec().toString());
+ log.info("@@PART#" + i + " " + part.getSpec().toString());
partReports.add(part.getSpec().get("part_testid"));
}
@@ -243,7 +242,7 @@ public class TestMLResource extends LensJerseyTest {
Assert.assertTrue(partReports.contains(secondReportID), secondReportID
+ " second partition not there");
- LOG.info("Completed task run");
+ log.info("Completed task run");
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java
----------------------------------------------------------------------
diff --git a/lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java b/lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java
index 7bf5d09..cb226d5 100644
--- a/lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java
+++ b/lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java
@@ -27,9 +27,12 @@ import org.apache.lens.server.api.metrics.MetricsService;
import org.glassfish.jersey.server.monitoring.RequestEvent;
import org.glassfish.jersey.server.monitoring.RequestEventListener;
+import lombok.extern.slf4j.Slf4j;
+
/**
* Event listener used for metrics in errors.
*/
+@Slf4j
public class LensRequestListener implements RequestEventListener {
/** The Constant HTTP_REQUESTS_STARTED. */
@@ -108,7 +111,7 @@ public class LensRequestListener implements RequestEventListener {
metrics.incrCounter(LensRequestListener.class, HTTP_CLIENT_ERROR);
} else {
metrics.incrCounter(LensRequestListener.class, HTTP_UNKOWN_ERROR);
- error.printStackTrace();
+ log.error("Encountered HTTP exception", error);
}
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java
----------------------------------------------------------------------
diff --git a/lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java b/lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java
index 61a0dd8..d360978 100644
--- a/lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java
+++ b/lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java
@@ -26,11 +26,14 @@ import org.apache.hive.service.CompositeService;
import org.apache.log4j.BasicConfigurator;
import org.apache.log4j.PropertyConfigurator;
+import lombok.extern.slf4j.Slf4j;
+
/**
* Initialize the webapp.
*
* @see LensServletContextEvent
*/
+@Slf4j
public class LensServletContextListener implements ServletContextListener {
/** The Constant LOG_PROPERTIES_FILE_KEY. */
@@ -58,7 +61,7 @@ public class LensServletContextListener implements ServletContextListener {
} catch (Exception exc) {
// Try basic configuration
System.err.println("WARNING - log4j property configurator gave error, falling back to basic configurator");
- exc.printStackTrace();
+ log.error("WARNING - log4j property configurator gave error, falling back to basic configurator", exc);
BasicConfigurator.configure();
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
----------------------------------------------------------------------
diff --git a/lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java b/lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
index 4597614..64f6cd4 100644
--- a/lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
+++ b/lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
@@ -41,14 +41,14 @@ import org.apache.hadoop.hive.ql.metadata.Table;
import org.apache.hadoop.hive.ql.parse.ParseException;
import org.apache.hive.service.cli.CLIService;
import org.apache.hive.service.cli.HiveSQLException;
-import org.apache.log4j.LogManager;
-import org.apache.log4j.Logger;
import org.apache.thrift.TException;
import com.google.common.collect.Lists;
+import lombok.extern.slf4j.Slf4j;
+
+@Slf4j
public class CubeMetastoreServiceImpl extends LensService implements CubeMetastoreService {
- public static final Logger LOG = LogManager.getLogger(CubeMetastoreServiceImpl.class);
public CubeMetastoreServiceImpl(CLIService cliService) {
super(NAME, cliService);
@@ -86,7 +86,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
if (!Hive.get(getSession(sessionid).getHiveConf()).databaseExists(database)) {
throw new NotFoundException("Database " + database + " does not exist");
}
- LOG.info("Set database " + database);
+ log.info("Set database " + database);
getSession(sessionid).setCurrentDatabase(database);
} catch (HiveException e) {
throw new LensException(e);
@@ -106,7 +106,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
try {
acquire(sessionid);
Hive.get(getSession(sessionid).getHiveConf()).dropDatabase(database, false, true, cascade);
- LOG.info("Database dropped " + database + " cascade? " + true);
+ log.info("Database dropped " + database + " cascade? " + true);
} catch (HiveException e) {
throw new LensException(e);
} catch (NoSuchObjectException e) {
@@ -137,7 +137,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
} finally {
release(sessionid);
}
- LOG.info("Database created " + database);
+ log.info("Database created " + database);
}
/**
@@ -195,7 +195,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
Cube parent = cube instanceof XDerivedCube ? (Cube) msClient.getCube(
((XDerivedCube) cube).getParent()) : null;
msClient.createCube(JAXBUtils.hiveCubeFromXCube(cube, parent));
- LOG.info("Created cube " + cube.getName());
+ log.info("Created cube " + cube.getName());
} catch (HiveException e) {
throw new LensException(e);
} catch (ParseException e) {
@@ -237,7 +237,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
try {
acquire(sessionid);
getClient(sessionid).dropCube(cubeName);
- LOG.info("Dropped cube " + cubeName);
+ log.info("Dropped cube " + cubeName);
} catch (HiveException e) {
throw new LensException(e);
} finally {
@@ -259,7 +259,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
Cube parent = cube instanceof XDerivedCube ? (Cube) msClient.getCube(
((XDerivedCube) cube).getParent()) : null;
msClient.alterCube(cube.getName(), JAXBUtils.hiveCubeFromXCube(cube, parent));
- LOG.info("Cube updated " + cube.getName());
+ log.info("Cube updated " + cube.getName());
} catch (HiveException e) {
throw new LensException(e);
} catch (ParseException e) {
@@ -288,7 +288,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
try {
acquire(sessionid);
- LOG.info("# Columns: " + columns);
+ log.info("# Columns: " + columns);
getClient(sessionid).createCubeDimensionTable(xDimTable.getDimensionName(),
dimTblName,
columns,
@@ -296,7 +296,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
updatePeriodMap,
properties,
storageDesc);
- LOG.info("Dimension Table created " + xDimTable.getTableName());
+ log.info("Dimension Table created " + xDimTable.getTableName());
} catch (HiveException e) {
throw new LensException(e);
} finally {
@@ -309,9 +309,9 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
try {
acquire(sessionid);
getClient(sessionid).dropDimensionTable(dimTblName, cascade);
- LOG.info("Dropped dimension table " + dimTblName + " cascade? " + cascade);
+ log.info("Dropped dimension table " + dimTblName + " cascade? " + cascade);
} catch (HiveException e) {
- LOG.error("@@@@ Got HiveException: >>>>>>>" + e.getMessage() + "<<<<<<<<<");
+ log.error("@@@@ Got HiveException: >>>>>>>" + e.getMessage() + "<<<<<<<<<", e);
throw new LensException(e);
} finally {
release(sessionid);
@@ -352,7 +352,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
getClient(sessionid).alterCubeDimensionTable(dimensionTable.getTableName(),
JAXBUtils.cubeDimTableFromDimTable(dimensionTable),
JAXBUtils.storageTableMapFromXStorageTables(dimensionTable.getStorageTables()));
- LOG.info("Updated dimension table " + dimensionTable.getTableName());
+ log.info("Updated dimension table " + dimensionTable.getTableName());
} catch (HiveException exc) {
throw new LensException(exc);
} finally {
@@ -387,7 +387,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
}
msClient.addStorage(dimTable, storageTable.getStorageName(), period,
JAXBUtils.storageTableDescFromXStorageTableDesc(storageTable.getTableDesc()));
- LOG.info("Added storage " + storageTable.getStorageName() + " for dimension table " + dimTblName
+ log.info("Added storage " + storageTable.getStorageName() + " for dimension table " + dimTblName
+ " with update period " + period);
} catch (HiveException exc) {
throw new LensException(exc);
@@ -407,10 +407,10 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
List<String> storageNames = new ArrayList<String>(tab.getStorages());
for (String s : storageNames) {
msClient.dropStorageFromDim(dimTblName, s);
- LOG.info("Dropped storage " + s + " from dimension table " + dimTblName
+ log.info("Dropped storage " + s + " from dimension table " + dimTblName
+ " [" + ++i + "/" + total + "]");
}
- LOG.info("Dropped " + total + " storages from dimension table " + dimTblName);
+ log.info("Dropped " + total + " storages from dimension table " + dimTblName);
} catch (HiveException exc) {
throw new LensException(exc);
} finally {
@@ -451,10 +451,10 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
List<String> storageNames = new ArrayList<String>(tab.getStorages());
for (String s : storageNames) {
msClient.dropStorageFromFact(factName, s);
- LOG.info("Dropped storage " + s + " from fact table " + factName
+ log.info("Dropped storage " + s + " from fact table " + factName
+ " [" + ++i + "/" + total + "]");
}
- LOG.info("Dropped " + total + " storages from fact table " + factName);
+ log.info("Dropped " + total + " storages from fact table " + factName);
} catch (HiveException exc) {
throw new LensException(exc);
} finally {
@@ -474,7 +474,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
}
msClient.dropStorageFromDim(dimTblName, storage);
- LOG.info("Dropped storage " + storage + " from dimension table " + dimTblName);
+ log.info("Dropped storage " + storage + " from dimension table " + dimTblName);
} catch (HiveException exc) {
throw new LensException(exc);
} finally {
@@ -518,7 +518,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
fact.getWeight(),
JAXBUtils.mapFromXProperties(fact.getProperties()),
JAXBUtils.storageTableMapFromXStorageTables(fact.getStorageTables()));
- LOG.info("Created fact table " + fact.getName());
+ log.info("Created fact table " + fact.getName());
} catch (HiveException e) {
throw new LensException(e);
} finally {
@@ -532,7 +532,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
acquire(sessionid);
getClient(sessionid).alterCubeFactTable(fact.getName(), JAXBUtils.cubeFactFromFactTable(fact),
JAXBUtils.storageTableMapFromXStorageTables(fact.getStorageTables()));
- LOG.info("Updated fact table " + fact.getName());
+ log.info("Updated fact table " + fact.getName());
} catch (HiveException e) {
throw new LensException(e);
} finally {
@@ -545,7 +545,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
try {
acquire(sessionid);
getClient(sessionid).dropFact(fact, cascade);
- LOG.info("Dropped fact table " + fact + " cascade? " + cascade);
+ log.info("Dropped fact table " + fact + " cascade? " + cascade);
} catch (HiveException e) {
throw new LensException(e);
} finally {
@@ -653,7 +653,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
msClient.addStorage(msClient.getFactTable(fact),
storageTable.getStorageName(), updatePeriods,
JAXBUtils.storageTableDescFromXStorageTableElement(storageTable));
- LOG.info("Added storage " + storageTable.getStorageName() + ":" + updatePeriods + " for fact " + fact);
+ log.info("Added storage " + storageTable.getStorageName() + ":" + updatePeriods + " for fact " + fact);
} catch (HiveException exc) {
throw new LensException(exc);
} finally {
@@ -667,7 +667,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
acquire(sessionid);
checkFactStorage(sessionid, fact, storage);
getClient(sessionid).dropStorageFromFact(fact, storage);
- LOG.info("Dropped storage " + storage + " from fact " + fact);
+ log.info("Dropped storage " + storage + " from fact " + fact);
} catch (HiveException exc) {
throw new LensException(exc);
} finally {
@@ -797,7 +797,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
getClient(sessionid).addPartition(
JAXBUtils.storagePartSpecFromXPartition(partition),
storageName);
- LOG.info("Added partition for dimension: " + dimTblName + " storage: " + storageName);
+ log.info("Added partition for dimension: " + dimTblName + " storage: " + storageName);
} catch (HiveException exc) {
throw new LensException(exc);
} finally {
@@ -826,7 +826,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
List<FieldSchema> cols = client.getHiveTable(tableName).getPartCols();
String[] vals = StringUtils.split(values, ",");
if (vals.length != cols.size()) {
- LOG.error("Values for all the part columns not specified, cols:" + cols + " vals:" + vals);
+ log.error("Values for all the part columns not specified, cols:" + cols + " vals:" + vals);
throw new BadRequestException("Values for all the part columns not specified");
}
StringBuilder filter = new StringBuilder();
@@ -881,10 +881,10 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
List<Partition> partitions = msClient.getPartitionsByFilter(
tableName, filter);
if (partitions.size() > 1) {
- LOG.error("More than one partition with specified values, correspoding filter:" + filter);
+ log.error("More than one partition with specified values, correspoding filter:" + filter);
throw new BadRequestException("More than one partition with specified values");
} else if (partitions.size() == 0) {
- LOG.error("No partition exists with specified values, correspoding filter:" + filter);
+ log.error("No partition exists with specified values, correspoding filter:" + filter);
throw new NotFoundException("No partition exists with specified values");
}
Map<String, Date> timeSpec = new HashMap<String, Date>();
@@ -892,7 +892,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
UpdatePeriod updatePeriod = populatePartSpec(partitions.get(0), timeSpec, nonTimeSpec);
msClient.dropPartition(cubeTableName,
storageName, timeSpec, nonTimeSpec, updatePeriod);
- LOG.info("Dropped partition for dimension: " + cubeTableName
+ log.info("Dropped partition for dimension: " + cubeTableName
+ " storage: " + storageName + " values:" + values);
} catch (HiveException exc) {
throw new LensException(exc);
@@ -924,7 +924,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
}
}
}
- LOG.info("Dropped partition for cube table: " + cubeTableName
+ log.info("Dropped partition for cube table: " + cubeTableName
+ " storage: " + storageName + " by filter:" + filter);
} catch (HiveException exc) {
throw new LensException(exc);
@@ -939,7 +939,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
try {
acquire(sessionid);
getClient(sessionid).createStorage(JAXBUtils.storageFromXStorage(storage));
- LOG.info("Created storage " + storage.getName());
+ log.info("Created storage " + storage.getName());
} catch (HiveException e) {
throw new LensException(e);
} finally {
@@ -954,7 +954,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
try {
acquire(sessionid);
getClient(sessionid).dropStorage(storageName);
- LOG.info("Dropped storage " + storageName);
+ log.info("Dropped storage " + storageName);
} catch (HiveException e) {
throw new LensException(e);
} finally {
@@ -969,7 +969,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
acquire(sessionid);
getClient(sessionid).alterStorage(storageName,
JAXBUtils.storageFromXStorage(storage));
- LOG.info("Altered storage " + storageName);
+ log.info("Altered storage " + storageName);
} catch (HiveException e) {
throw new LensException(e);
} finally {
@@ -1086,7 +1086,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
try {
acquire(sessionid);
getClient(sessionid).createDimension(JAXBUtils.dimensionFromXDimension(dimension));
- LOG.info("Created dimension " + dimension.getName());
+ log.info("Created dimension " + dimension.getName());
} catch (HiveException e) {
throw new LensException(e);
} catch (ParseException e) {
@@ -1115,7 +1115,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
try {
acquire(sessionid);
getClient(sessionid).dropDimension(dimName);
- LOG.info("Dropped dimension " + dimName);
+ log.info("Dropped dimension " + dimName);
} catch (HiveException e) {
throw new LensException(e);
} finally {
@@ -1130,7 +1130,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
acquire(sessionid);
getClient(sessionid).alterDimension(dimName,
JAXBUtils.dimensionFromXDimension(dimension));
- LOG.info("Altered dimension " + dimName);
+ log.info("Altered dimension " + dimName);
} catch (HiveException e) {
throw new LensException(e);
} catch (ParseException e) {
@@ -1222,7 +1222,7 @@ public class CubeMetastoreServiceImpl extends LensService implements CubeMetasto
if (!StringUtils.isBlank(dbName)) {
tables = getTablesFromDB(sessionid, dbName, false);
} else {
- LOG.info("Getting tables from all dbs");
+ log.info("Getting tables from all dbs");
List<String> alldbs = getAllDatabases(sessionid);
tables = new ArrayList<String>();
for (String db : alldbs) {
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java
----------------------------------------------------------------------
diff --git a/lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java b/lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java
index a628c90..b6d5fec 100644
--- a/lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java
+++ b/lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java
@@ -38,20 +38,20 @@ import org.apache.hadoop.hive.ql.metadata.Partition;
import org.apache.hadoop.hive.ql.metadata.Table;
import org.apache.hadoop.hive.ql.parse.ParseException;
import org.apache.hadoop.hive.serde.serdeConstants;
-import org.apache.log4j.LogManager;
-import org.apache.log4j.Logger;
import com.google.common.base.Optional;
+import lombok.extern.slf4j.Slf4j;
+
/**
* Utilities for converting to and from JAXB types to hive.ql.metadata.cube types
*/
+@Slf4j
public final class JAXBUtils {
private JAXBUtils() {
}
- public static final Logger LOG = LogManager.getLogger(JAXBUtils.class);
private static final ObjectFactory XCF = new ObjectFactory();
/**
@@ -223,7 +223,7 @@ public final class JAXBUtils {
try {
return DatatypeFactory.newInstance().newXMLGregorianCalendar(c1);
} catch (DatatypeConfigurationException e) {
- LOG.warn("Error converting date " + d, e);
+ log.warn("Error converting date " + d, e);
return null;
}
}
@@ -322,7 +322,7 @@ public final class JAXBUtils {
xcc.setChainName(rd.getChainName());
xcc.setRefCol(rd.getRefColumn());
if (baseTable.getChainByName(rd.getChainName()) == null) {
- LOG.error("Missing chain definition for " + rd.getChainName());
+ log.error("Missing chain definition for " + rd.getChainName());
} else {
xcc.setDestTable(baseTable.getChainByName(rd.getChainName()).getDestTable());
}
@@ -568,7 +568,7 @@ public final class JAXBUtils {
storage.addProperties(mapFromXProperties(xs.getProperties()));
return storage;
} catch (Exception e) {
- LOG.error("Could not create storage class" + xs.getClassname() + "with name:" + xs.getName());
+ log.error("Could not create storage class" + xs.getClassname() + "with name:" + xs.getName(), e);
throw new WebApplicationException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
----------------------------------------------------------------------
diff --git a/lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java b/lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
index ee24e1f..6e8b3a6 100644
--- a/lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
+++ b/lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
@@ -45,7 +45,6 @@ import org.apache.lens.server.api.session.SessionService;
import org.apache.hadoop.hive.conf.HiveConf;
import org.apache.hive.service.AbstractService;
-import org.apache.log4j.Logger;
import org.glassfish.jersey.server.ContainerRequest;
import org.glassfish.jersey.server.model.ResourceMethod;
@@ -63,14 +62,14 @@ import info.ganglia.gmetric4j.gmetric.GMetric;
import info.ganglia.gmetric4j.gmetric.GMetric.UDPAddressingMode;
import lombok.Getter;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class MetricsServiceImpl.
*/
+@Slf4j
public class MetricsServiceImpl extends AbstractService implements MetricsService {
- /** The Constant LOG. */
- public static final Logger LOG = Logger.getLogger(MetricsService.class);
-
/** The query status listener. */
private AsyncEventListener<StatusChange> queryStatusListener;
@@ -132,7 +131,7 @@ public class MetricsServiceImpl extends AbstractService implements MetricsServic
private boolean enableResourceMethodMetering;
public void setEnableResourceMethodMetering(boolean enableResourceMethodMetering) {
- LOG.info("setEnableResourceMethodMetering: " + enableResourceMethodMetering);
+ log.info("setEnableResourceMethodMetering: " + enableResourceMethodMetering);
this.enableResourceMethodMetering = enableResourceMethodMetering;
if (!enableResourceMethodMetering) {
methodMetricsFactory.clear();
@@ -273,7 +272,7 @@ public class MetricsServiceImpl extends AbstractService implements MetricsServic
reporters.add(greporter);
} catch (IOException e) {
- LOG.error("Could not start ganglia reporter", e);
+ log.error("Could not start ganglia reporter", e);
}
}
if (hiveConf.getBoolean(LensConfConstants.ENABLE_GRAPHITE_METRICS, false)) {
@@ -289,10 +288,10 @@ public class MetricsServiceImpl extends AbstractService implements MetricsServic
.build(graphite);
reporters.add(reporter);
} catch (UnknownHostException e) {
- LOG.error("Couldn't get localhost. So couldn't setup graphite reporting");
+ log.error("Couldn't get localhost. So couldn't setup graphite reporting", e);
}
}
- LOG.info("Started metrics service");
+ log.info("Started metrics service");
super.init(hiveConf);
}
@@ -416,7 +415,7 @@ public class MetricsServiceImpl extends AbstractService implements MetricsServic
}
}
- LOG.info("Stopped metrics service");
+ log.info("Stopped metrics service");
super.stop();
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java
----------------------------------------------------------------------
diff --git a/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java b/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java
index a57888d..1904350 100644
--- a/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java
+++ b/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java
@@ -37,17 +37,14 @@ import org.apache.commons.dbutils.handlers.BeanHandler;
import org.apache.commons.lang3.StringUtils;
import org.apache.hadoop.conf.Configuration;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import lombok.extern.slf4j.Slf4j;
/**
* Top level class which logs and retrieves finished query from Database.
*/
+@Slf4j
public class LensServerDAO {
- /** The Constant LOG. */
- private static final Logger LOG = LoggerFactory.getLogger(LensServerDAO.class);
-
/** The ds. */
private DataSource ds;
@@ -83,7 +80,7 @@ public class LensServerDAO {
try {
runner.update("drop table finished_queries");
} catch (SQLException e) {
- e.printStackTrace();
+ log.error("SQL exception while dropping finished queries table.", e);
}
}
@@ -102,9 +99,9 @@ public class LensServerDAO {
try {
createTable(sql);
ds.getConnection().commit();
- LOG.info("Created finished queries table");
+ log.info("Created finished queries table");
} catch (SQLException e) {
- LOG.warn("Unable to create finished queries table", e);
+ log.warn("Unable to create finished queries table", e);
}
}
@@ -128,10 +125,10 @@ public class LensServerDAO {
query.getErrorMessage(), query.getDriverStartTime(), query.getDriverEndTime(), query.getMetadataClass(),
query.getQueryName(), query.getSubmissionTime());
} else {
- LOG.warn("Re insert happening in purge: " + Thread.currentThread().getStackTrace());
+ log.warn("Re insert happening in purge: " + Thread.currentThread().getStackTrace());
if (alreadyExisting.equals(query)) {
// This is also okay
- LOG.warn("Skipping Re-insert. Finished Query found in DB while trying to insert, handle=" + query.getHandle());
+ log.warn("Skipping Re-insert. Finished Query found in DB while trying to insert, handle=" + query.getHandle());
} else {
String msg = "Found different value pre-existing in DB while trying to insert finished query. "
+ "Old = " + alreadyExisting + "\nNew = " + query;
@@ -155,7 +152,7 @@ public class LensServerDAO {
try {
return runner.query(sql, rsh, handle);
} catch (SQLException e) {
- e.printStackTrace();
+ log.error("SQL exception while executing query.", e);
}
return null;
}
@@ -212,7 +209,7 @@ public class LensServerDAO {
try {
queryHandleList.add(QueryHandle.fromString(handle));
} catch (IllegalArgumentException exc) {
- LOG.warn("Warning invalid query handle found in DB " + handle);
+ log.warn("Warning invalid query handle found in DB " + handle);
}
}
return queryHandleList;
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
----------------------------------------------------------------------
diff --git a/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
index 4cf1fa9..7c2da3a 100644
--- a/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
+++ b/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
@@ -73,19 +73,17 @@ import org.codehaus.jackson.map.*;
import org.codehaus.jackson.map.module.SimpleModule;
import com.google.common.collect.ImmutableList;
+
import lombok.Getter;
+import lombok.extern.slf4j.Slf4j;
/**
* The Class QueryExecutionServiceImpl.
*/
+@Slf4j
public class QueryExecutionServiceImpl extends LensService implements QueryExecutionService {
/**
- * The Constant LOG.
- */
- public static final Log LOG = LogFactory.getLog(QueryExecutionServiceImpl.class);
-
- /**
* The Constant PREPARED_QUERIES_COUNTER.
*/
public static final String PREPARED_QUERIES_COUNTER = "prepared-queries";
@@ -239,7 +237,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
public void onEvent(DriverEvent event) {
// Need to restore session only in case of hive driver
if (event instanceof DriverSessionStarted) {
- LOG.info("New driver event by driver " + event.getDriver());
+ log.info("New driver event by driver " + event.getDriver());
handleDriverSessionStart(event);
}
}
@@ -266,10 +264,10 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
try {
Class<?> clazz = Class.forName(acceptorClass);
QueryAcceptor acceptor = (QueryAcceptor) clazz.newInstance();
- LOG.info("initialized query acceptor: " + acceptor);
+ log.info("initialized query acceptor: " + acceptor);
queryAcceptors.add(acceptor);
} catch (Exception e) {
- LOG.warn("Could not load the acceptor:" + acceptorClass, e);
+ log.warn("Could not load the acceptor:" + acceptorClass, e);
throw new LensException("Could not load acceptor" + acceptorClass, e);
}
}
@@ -279,14 +277,14 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
private void initializeListeners() {
if (conf.getBoolean(LensConfConstants.QUERY_STATE_LOGGER_ENABLED, true)) {
getEventService().addListenerForType(new QueryStatusLogger(), StatusChange.class);
- LOG.info("Registered query state logger");
+ log.info("Registered query state logger");
}
// Add result formatter
getEventService().addListenerForType(new ResultFormatter(this), QueryExecuted.class);
getEventService().addListenerForType(new QueryExecutionStatisticsGenerator(this, getEventService()),
QueryEnded.class);
getEventService().addListenerForType(new QueryEndNotifier(this, getCliService().getHiveConf()), QueryEnded.class);
- LOG.info("Registered query result formatter");
+ log.info("Registered query result formatter");
}
/**
@@ -308,9 +306,9 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
}
drivers.put(driverClass, driver);
- LOG.info("Driver for " + driverClass + " is loaded");
+ log.info("Driver for " + driverClass + " is loaded");
} catch (Exception e) {
- LOG.warn("Could not load the driver:" + driverClass, e);
+ log.warn("Could not load the driver:" + driverClass, e);
throw new LensException("Could not load driver " + driverClass, e);
}
}
@@ -321,7 +319,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
Class<? extends DriverSelector> driverSelectorClass = conf.getClass(LensConfConstants.DRIVER_SELECTOR_CLASS,
MinQueryCostSelector.class,
DriverSelector.class);
- LOG.info("Using driver selector class: " + driverSelectorClass.getCanonicalName());
+ log.info("Using driver selector class: " + driverSelectorClass.getCanonicalName());
driverSelector = driverSelectorClass.newInstance();
} catch (Exception e) {
throw new LensException("Couldn't instantiate driver selector class. Class name: "
@@ -371,6 +369,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
/**
* The Class QueryStatusLogger.
*/
+ @Slf4j
public static class QueryStatusLogger implements LensEventListener<StatusChange> {
/**
@@ -476,13 +475,13 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
*/
@Override
public void run() {
- LOG.info("Starting QuerySubmitter thread");
+ log.info("Starting QuerySubmitter thread");
while (!pausedForTest && !stopped && !querySubmitter.isInterrupted()) {
try {
QueryContext ctx = queuedQueries.take();
synchronized (ctx) {
if (ctx.getStatus().getStatus().equals(Status.QUEUED)) {
- LOG.info("Launching query:" + ctx.getUserQuery());
+ log.info("Launching query:" + ctx.getUserQuery());
try {
// acquire session before any query operation.
acquire(ctx.getLensSessionIdentifier());
@@ -490,13 +489,13 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
if (!ctx.isDriverQueryExplicitlySet()) {
rewriteAndSelect(ctx);
} else {
- LOG.info("Submitting to already selected driver");
+ log.info("Submitting to already selected driver");
}
// Check if we need to pass session's effective resources to selected driver
addSessionResourcesToDriver(ctx);
ctx.getSelectedDriver().executeAsync(ctx);
} catch (Exception e) {
- LOG.error("Error launching query " + ctx.getQueryHandle(), e);
+ log.error("Error launching query " + ctx.getQueryHandle(), e);
String reason = e.getCause() != null ? e.getCause().getMessage() : e.getMessage();
setFailedStatus(ctx, "Launching query failed", reason);
continue;
@@ -504,18 +503,18 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
release(ctx.getLensSessionIdentifier());
}
setLaunchedStatus(ctx);
- LOG.info("Launched query " + ctx.getQueryHandle());
+ log.info("Launched query " + ctx.getQueryHandle());
}
}
} catch (InterruptedException e) {
- LOG.info("Query Submitter has been interrupted, exiting");
+ log.info("Query Submitter has been interrupted, exiting");
return;
} catch (Exception e) {
incrCounter(QUERY_SUBMITTER_COUNTER);
- LOG.error("Error in query submitter", e);
+ log.error("Error in query submitter", e);
}
}
- LOG.info("QuerySubmitter exited");
+ log.info("QuerySubmitter exited");
}
}
@@ -545,7 +544,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
*/
@Override
public void run() {
- LOG.info("Starting Status poller thread");
+ log.info("Starting Status poller thread");
while (!stopped && !statusPoller.isInterrupted()) {
try {
List<QueryContext> launched = new ArrayList<QueryContext>();
@@ -554,25 +553,25 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
if (stopped || statusPoller.isInterrupted()) {
return;
}
- LOG.info("Polling status for " + ctx.getQueryHandle());
+ log.info("Polling status for " + ctx.getQueryHandle());
try {
// session is not required to update status of the query
// don't need to wrap this with acquire/release
updateStatus(ctx.getQueryHandle());
} catch (LensException e) {
- LOG.error("Error updating status ", e);
+ log.error("Error updating status ", e);
}
}
Thread.sleep(pollInterval);
} catch (InterruptedException e) {
- LOG.info("Status poller has been interrupted, exiting");
+ log.info("Status poller has been interrupted, exiting");
return;
} catch (Exception e) {
incrCounter(STATUS_UPDATE_COUNTER);
- LOG.error("Error in status poller", e);
+ log.error("Error in status poller", e);
}
}
- LOG.info("StatusPoller exited");
+ log.info("StatusPoller exited");
}
}
@@ -655,14 +654,14 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
QueryStatus before = ctx.getStatus();
if (!ctx.getStatus().getStatus().equals(QueryStatus.Status.QUEUED) && !ctx.getDriverStatus().isFinished()
&& !ctx.getStatus().finished()) {
- LOG.info("Updating status for " + ctx.getQueryHandle());
+ log.info("Updating status for " + ctx.getQueryHandle());
try {
ctx.getSelectedDriver().updateStatus(ctx);
ctx.setStatus(ctx.getDriverStatus().toQueryStatus());
} catch (LensException exc) {
// Driver gave exception while updating status
setFailedStatus(ctx, "Status update failed", exc.getMessage());
- LOG.error("Status update failed for " + handle, exc);
+ log.error("Status update failed for " + handle, exc);
}
// query is successfully executed by driver and
// if query result need not be persisted or there is no result available in driver, move the query to
@@ -712,7 +711,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
case SUCCESSFUL:
return new QuerySuccess(ctx.getEndTime(), prevState, currState, query);
default:
- LOG.warn("Query " + query + " transitioned to " + currState + " state from " + prevState + " state");
+ log.warn("Query " + query + " transitioned to " + currState + " state from " + prevState + " state");
return null;
}
}
@@ -741,7 +740,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
try {
getEventService().notifyEvent(event);
} catch (LensException e) {
- LOG.warn("LensEventService encountered error while handling event: " + event.getEventId(), e);
+ log.warn("LensEventService encountered error while handling event: " + event.getEventId(), e);
}
}
}
@@ -758,13 +757,13 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
*/
@Override
public void run() {
- LOG.info("Starting Query purger thread");
+ log.info("Starting Query purger thread");
while (!stopped && !queryPurger.isInterrupted()) {
FinishedQuery finished = null;
try {
finished = finishedQueries.take();
} catch (InterruptedException e) {
- LOG.info("QueryPurger has been interrupted, exiting");
+ log.info("QueryPurger has been interrupted, exiting");
return;
}
try {
@@ -785,9 +784,9 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
}
try {
lensServerDao.insertFinishedQuery(finishedQuery);
- LOG.info("Saved query " + finishedQuery.getHandle() + " to DB");
+ log.info("Saved query " + finishedQuery.getHandle() + " to DB");
} catch (Exception e) {
- LOG.warn("Exception while purging query ", e);
+ log.warn("Exception while purging query ", e);
finishedQueries.add(finished);
continue;
}
@@ -799,24 +798,24 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
finished.getCtx().getSelectedDriver().closeQuery(finished.getCtx().getQueryHandle());
}
} catch (Exception e) {
- LOG.warn("Exception while closing query with selected driver.", e);
+ log.warn("Exception while closing query with selected driver.", e);
}
- LOG.info("Purging: " + finished.getCtx().getQueryHandle());
+ log.info("Purging: " + finished.getCtx().getQueryHandle());
allQueries.remove(finished.getCtx().getQueryHandle());
resultSets.remove(finished.getCtx().getQueryHandle());
}
fireStatusChangeEvent(finished.getCtx(),
new QueryStatus(1f, Status.CLOSED, "Query purged", false, null, null), finished.getCtx().getStatus());
- LOG.info("Query purged: " + finished.getCtx().getQueryHandle());
+ log.info("Query purged: " + finished.getCtx().getQueryHandle());
} catch (LensException e) {
incrCounter(QUERY_PURGER_COUNTER);
- LOG.error("Error closing query ", e);
+ log.error("Error closing query ", e);
} catch (Exception e) {
incrCounter(QUERY_PURGER_COUNTER);
- LOG.error("Error in query purger", e);
+ log.error("Error in query purger", e);
}
}
- LOG.info("QueryPurger exited");
+ log.info("QueryPurger exited");
}
}
@@ -832,24 +831,24 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
*/
@Override
public void run() {
- LOG.info("Starting Prepared Query purger thread");
+ log.info("Starting Prepared Query purger thread");
while (!stopped && !prepareQueryPurger.isInterrupted()) {
try {
PreparedQueryContext prepared = preparedQueryQueue.take();
destroyPreparedQuery(prepared);
- LOG.info("Purged prepared query: " + prepared.getPrepareHandle());
+ log.info("Purged prepared query: " + prepared.getPrepareHandle());
} catch (LensException e) {
incrCounter(PREPARED_QUERY_PURGER_COUNTER);
- LOG.error("Error closing prepared query ", e);
+ log.error("Error closing prepared query ", e);
} catch (InterruptedException e) {
- LOG.info("PreparedQueryPurger has been interrupted, exiting");
+ log.info("PreparedQueryPurger has been interrupted, exiting");
return;
} catch (Exception e) {
incrCounter(PREPARED_QUERY_PURGER_COUNTER);
- LOG.error("Error in prepared query purger", e);
+ log.error("Error in prepared query purger", e);
}
}
- LOG.info("PreparedQueryPurger exited");
+ log.info("PreparedQueryPurger exited");
}
}
@@ -875,7 +874,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
maxFinishedQueries = conf.getInt(LensConfConstants.MAX_NUMBER_OF_FINISHED_QUERY,
LensConfConstants.DEFAULT_FINISHED_QUERIES);
initalizeFinishedQueryStore(conf);
- LOG.info("Query execution service initialized");
+ log.info("Query execution service initialized");
}
/**
@@ -889,7 +888,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
try {
this.lensServerDao.createFinishedQueriesTable();
} catch (Exception e) {
- LOG.warn("Unable to create finished query table, query purger will not purge queries", e);
+ log.warn("Unable to create finished query table, query purger will not purge queries", e);
}
SimpleModule module = new SimpleModule("HiveColumnModule", new Version(1, 0, 0, null));
module.addSerializer(ColumnDescriptor.class, new JsonSerializer<ColumnDescriptor>() {
@@ -940,15 +939,15 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
super.stop();
for (Thread th : new Thread[]{querySubmitter, statusPoller, queryPurger, prepareQueryPurger}) {
try {
- LOG.debug("Waiting for" + th.getName());
+ log.debug("Waiting for" + th.getName());
th.join();
} catch (InterruptedException e) {
- LOG.error("Error waiting for thread: " + th.getName(), e);
+ log.error("Error waiting for thread: " + th.getName(), e);
}
}
estimatePool.shutdownNow();
- LOG.info("Query execution service stopped");
+ log.info("Query execution service stopped");
}
/*
@@ -973,7 +972,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
}
}
} catch (LensException e) {
- LOG.error("Could not set query conf ", e);
+ log.error("Could not set query conf ", e);
}
}
}
@@ -1068,7 +1067,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
++inCompleteDrivers;
// Cancel the corresponding task
estimateFutures.get(i).cancel(true);
- LOG.warn("Timeout reached for estimate task for driver " + r.getDriver() + " " + debugInfo);
+ log.warn("Timeout reached for estimate task for driver " + r.getDriver() + " " + debugInfo);
}
}
@@ -1188,20 +1187,20 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
if (!succeeded) {
failureCause = estimateRunnable.getFailureCause();
cause = estimateRunnable.getCause();
- LOG.error("Estimate failed for driver " + driver + " cause: " + failureCause);
+ log.error("Estimate failed for driver " + driver + " cause: " + failureCause);
}
estimateGauge.markSuccess();
} else {
- LOG.error("Estimate skipped since rewrite failed for driver " + driver + " cause: " + failureCause);
+ log.error("Estimate skipped since rewrite failed for driver " + driver + " cause: " + failureCause);
}
} catch (Throwable th) {
- LOG.error("Error computing estimate for driver " + driver, th);
+ log.error("Error computing estimate for driver " + driver, th);
} finally {
completed = true;
try {
release(ctx.getLensSessionIdentifier());
} catch (LensException e) {
- LOG.error("Could not release session: " + ctx.getLensSessionIdentifier(), e);
+ log.error("Could not release session: " + ctx.getLensSessionIdentifier(), e);
} finally {
estimateCompletionLatch.countDown();
}
@@ -1368,7 +1367,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
throws LensException {
PreparedQueryContext prepared = null;
try {
- LOG.info("ExplainAndPrepare: " + sessionHandle.toString() + " query: " + query);
+ log.info("ExplainAndPrepare: " + sessionHandle.toString() + " query: " + query);
acquire(sessionHandle);
prepared = prepareQuery(sessionHandle, query, lensConf, SubmitOp.EXPLAIN_AND_PREPARE);
prepared.setQueryName(queryName);
@@ -1380,7 +1379,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
if (prepared != null) {
destroyPreparedQuery(prepared);
}
- LOG.error("Explain and prepare failed", e);
+ log.error("Explain and prepare failed", e);
QueryPlan plan;
if (e.getCause() != null && e.getCause().getMessage() != null) {
plan = new QueryPlan(true, e.getCause().getMessage());
@@ -1406,7 +1405,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
public QueryHandle executePrepareAsync(LensSessionHandle sessionHandle, QueryPrepareHandle prepareHandle,
LensConf conf, String queryName) throws LensException {
try {
- LOG.info("ExecutePrepareAsync: " + sessionHandle.toString() + " query:" + prepareHandle.getPrepareHandleId());
+ log.info("ExecutePrepareAsync: " + sessionHandle.toString() + " query:" + prepareHandle.getPrepareHandleId());
acquire(sessionHandle);
PreparedQueryContext pctx = getPreparedQueryContext(sessionHandle, prepareHandle);
Configuration qconf = getLensConf(sessionHandle, conf);
@@ -1434,7 +1433,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
public QueryHandleWithResultSet executePrepare(LensSessionHandle sessionHandle, QueryPrepareHandle prepareHandle,
long timeoutMillis, LensConf conf, String queryName) throws LensException {
try {
- LOG.info("ExecutePrepare: " + sessionHandle.toString() + " query:" + prepareHandle.getPrepareHandleId()
+ log.info("ExecutePrepare: " + sessionHandle.toString() + " query:" + prepareHandle.getPrepareHandleId()
+ " timeout:" + timeoutMillis);
acquire(sessionHandle);
PreparedQueryContext pctx = getPreparedQueryContext(sessionHandle, prepareHandle);
@@ -1462,7 +1461,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
public QueryHandle executeAsync(LensSessionHandle sessionHandle, String query, LensConf conf, String queryName)
throws LensException {
try {
- LOG.info("ExecuteAsync: " + sessionHandle.toString() + " query: " + query);
+ log.info("ExecuteAsync: " + sessionHandle.toString() + " query: " + query);
acquire(sessionHandle);
Configuration qconf = getLensConf(sessionHandle, conf);
accept(query, qconf, SubmitOp.EXECUTE);
@@ -1521,7 +1520,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
queuedQueries.add(ctx);
allQueries.put(ctx.getQueryHandle(), ctx);
fireStatusChangeEvent(ctx, ctx.getStatus(), before);
- LOG.info("Returning handle " + ctx.getQueryHandle().getHandleId());
+ log.info("Returning handle " + ctx.getQueryHandle().getHandleId());
return ctx.getQueryHandle();
}
@@ -1535,7 +1534,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
public boolean updateQueryConf(LensSessionHandle sessionHandle, QueryHandle queryHandle, LensConf newconf)
throws LensException {
try {
- LOG.info("UpdateQueryConf:" + sessionHandle.toString() + " query: " + queryHandle);
+ log.info("UpdateQueryConf:" + sessionHandle.toString() + " query: " + queryHandle);
acquire(sessionHandle);
QueryContext ctx = getQueryContext(sessionHandle, queryHandle);
if (ctx != null && ctx.getStatus().getStatus() == QueryStatus.Status.QUEUED) {
@@ -1560,7 +1559,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
public boolean updateQueryConf(LensSessionHandle sessionHandle, QueryPrepareHandle prepareHandle, LensConf newconf)
throws LensException {
try {
- LOG.info("UpdatePreparedQueryConf:" + sessionHandle.toString() + " query: " + prepareHandle);
+ log.info("UpdatePreparedQueryConf:" + sessionHandle.toString() + " query: " + prepareHandle);
acquire(sessionHandle);
PreparedQueryContext ctx = getPreparedQueryContext(sessionHandle, prepareHandle);
ctx.updateConf(newconf.getProperties());
@@ -1663,7 +1662,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
public QueryHandleWithResultSet execute(LensSessionHandle sessionHandle, String query, long timeoutMillis,
LensConf conf, String queryName) throws LensException {
try {
- LOG.info("Blocking execute " + sessionHandle.toString() + " query: " + query + " timeout: " + timeoutMillis);
+ log.info("Blocking execute " + sessionHandle.toString() + " query: " + query + " timeout: " + timeoutMillis);
acquire(sessionHandle);
Configuration qconf = getLensConf(sessionHandle, conf);
accept(query, qconf, SubmitOp.EXECUTE);
@@ -1694,7 +1693,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
try {
Thread.sleep(10);
} catch (InterruptedException e) {
- e.printStackTrace();
+ log.error("Encountered Interrupted exception.", e);
}
}
QueryCompletionListener listener = new QueryCompletionListenerImpl(handle);
@@ -1708,7 +1707,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
listener.wait(timeoutMillis);
}
} catch (InterruptedException e) {
- LOG.info("Waiting thread interrupted");
+ log.info("Waiting thread interrupted");
}
if (getQueryContext(sessionHandle, handle).getStatus().finished()) {
result.setResult(getResultset(handle).toQueryResult());
@@ -1750,7 +1749,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
public void onCompletion(QueryHandle handle) {
synchronized (this) {
succeeded = true;
- LOG.info("Query " + handle + " with time out succeeded");
+ log.info("Query " + handle + " with time out succeeded");
this.notify();
}
}
@@ -1765,7 +1764,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
public void onError(QueryHandle handle, String error) {
synchronized (this) {
succeeded = false;
- LOG.info("Query " + handle + " with time out failed");
+ log.info("Query " + handle + " with time out failed");
this.notify();
}
}
@@ -1782,7 +1781,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
public QueryResultSetMetadata getResultSetMetadata(LensSessionHandle sessionHandle, QueryHandle queryHandle)
throws LensException {
try {
- LOG.info("GetResultSetMetadata: " + sessionHandle.toString() + " query: " + queryHandle);
+ log.info("GetResultSetMetadata: " + sessionHandle.toString() + " query: " + queryHandle);
acquire(sessionHandle);
LensResultSet resultSet = getResultset(queryHandle);
if (resultSet != null) {
@@ -1806,7 +1805,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
public QueryResult fetchResultSet(LensSessionHandle sessionHandle, QueryHandle queryHandle, long startIndex,
int fetchSize) throws LensException {
try {
- LOG.info("FetchResultSet:" + sessionHandle.toString() + " query:" + queryHandle);
+ log.info("FetchResultSet:" + sessionHandle.toString() + " query:" + queryHandle);
acquire(sessionHandle);
return getResultset(queryHandle).toQueryResult();
} finally {
@@ -1823,7 +1822,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
@Override
public void closeResultSet(LensSessionHandle sessionHandle, QueryHandle queryHandle) throws LensException {
try {
- LOG.info("CloseResultSet:" + sessionHandle.toString() + " query: " + queryHandle);
+ log.info("CloseResultSet:" + sessionHandle.toString() + " query: " + queryHandle);
acquire(sessionHandle);
resultSets.remove(queryHandle);
// Ask driver to close result set
@@ -1842,7 +1841,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
@Override
public boolean cancelQuery(LensSessionHandle sessionHandle, QueryHandle queryHandle) throws LensException {
try {
- LOG.info("CancelQuery: " + sessionHandle.toString() + " query:" + queryHandle);
+ log.info("CancelQuery: " + sessionHandle.toString() + " query:" + queryHandle);
acquire(sessionHandle);
QueryContext ctx = getQueryContext(sessionHandle, queryHandle);
if (ctx.getStatus().finished()) {
@@ -1914,7 +1913,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
List<QueryHandle> persistedQueries = lensServerDao.findFinishedQueries(state, userName, queryName, fromDate,
toDate);
if (persistedQueries != null && !persistedQueries.isEmpty()) {
- LOG.info("Adding persisted queries " + persistedQueries.size());
+ log.info("Adding persisted queries " + persistedQueries.size());
all.addAll(persistedQueries);
}
}
@@ -1991,7 +1990,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
@Override
public boolean destroyPrepared(LensSessionHandle sessionHandle, QueryPrepareHandle prepared) throws LensException {
try {
- LOG.info("DestroyPrepared: " + sessionHandle.toString() + " query:" + prepared);
+ log.info("DestroyPrepared: " + sessionHandle.toString() + " query:" + prepared);
acquire(sessionHandle);
destroyPreparedQuery(getPreparedQueryContext(sessionHandle, prepared));
return true;
@@ -2025,7 +2024,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
public QueryCost estimate(LensSessionHandle sessionHandle, String query, LensConf lensConf)
throws LensException {
try {
- LOG.info("Estimate: " + sessionHandle.toString() + " query:" + query);
+ log.info("Estimate: " + sessionHandle.toString() + " query:" + query);
acquire(sessionHandle);
Configuration qconf = getLensConf(sessionHandle, lensConf);
ExplainQueryContext estimateQueryContext = new ExplainQueryContext(query,
@@ -2048,7 +2047,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
@Override
public QueryPlan explain(LensSessionHandle sessionHandle, String query, LensConf lensConf) throws LensException {
try {
- LOG.info("Explain: " + sessionHandle.toString() + " query:" + query);
+ log.info("Explain: " + sessionHandle.toString() + " query:" + query);
acquire(sessionHandle);
Configuration qconf = getLensConf(sessionHandle, lensConf);
ExplainQueryContext explainQueryContext = new ExplainQueryContext(query,
@@ -2059,7 +2058,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
addSessionResourcesToDriver(explainQueryContext);
return explainQueryContext.getSelectedDriver().explain(explainQueryContext).toQueryPlan();
} catch (LensException e) {
- LOG.error("Error during explain :", e);
+ log.error("Error during explain :", e);
QueryPlan plan;
if (e.getCause() != null && e.getCause().getMessage() != null) {
plan = new QueryPlan(true, e.getCause().getMessage());
@@ -2135,10 +2134,10 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
driver = (LensDriver) driverCls.newInstance();
driver.configure(conf);
} catch (Exception e) {
- LOG.error("Could not instantiate driver:" + driverClsName);
+ log.error("Could not instantiate driver:" + driverClsName, e);
throw new IOException(e);
}
- LOG.info("Driver state for " + driverClsName + " will be ignored");
+ log.info("Driver state for " + driverClsName + " will be ignored");
}
driver.readExternal(in);
}
@@ -2187,7 +2186,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
allQueries.remove(ctx.getQueryHandle());
}
}
- LOG.info("Recovered " + allQueries.size() + " queries");
+ log.info("Recovered " + allQueries.size() + " queries");
}
}
@@ -2219,7 +2218,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
}
}
}
- LOG.info("Persisted " + allQueries.size() + " queries");
+ log.info("Persisted " + allQueries.size() + " queries");
}
/**
@@ -2256,7 +2255,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
throw new NotFoundException("Http result not available for query:" + queryHandle.toString());
}
} catch (IOException e) {
- LOG.warn("Unable to get status for Result Directory", e);
+ log.warn("Unable to get status for Result Directory", e);
throw new NotFoundException("Http result not available for query:" + queryHandle.toString());
}
String resultFSReadUrl = ctx.getConf().get(LensConfConstants.RESULT_FS_READ_URL);
@@ -2360,7 +2359,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
String lensSession = sessionStarted.getLensSessionID();
LensSessionHandle sessionHandle = getSessionHandle(lensSession);
if (sessionHandle == null) {
- LOG.warn("Lens session went away for sessionid:" + lensSession);
+ log.warn("Lens session went away for sessionid:" + lensSession);
return;
}
@@ -2371,22 +2370,22 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
List<ResourceEntry> resources = session.getLensSessionPersistInfo().getResources();
if (resources != null && !resources.isEmpty()) {
for (ResourceEntry resource : resources) {
- LOG.info("Restoring resource " + resource + " for session " + lensSession);
+ log.info("Restoring resource " + resource + " for session " + lensSession);
String command = "add " + resource.getType().toLowerCase() + " " + resource.getLocation();
try {
// Execute add resource query in blocking mode
hiveDriver.execute(createResourceQuery(command, sessionHandle, hiveDriver));
resource.restoredResource();
- LOG.info("Restored resource " + resource + " for session " + lensSession);
+ log.info("Restored resource " + resource + " for session " + lensSession);
} catch (Exception exc) {
- LOG.error("Unable to add resource " + resource + " for session " + lensSession, exc);
+ log.error("Unable to add resource " + resource + " for session " + lensSession, exc);
}
}
} else {
- LOG.info("No resources to restore for session " + lensSession);
+ log.info("No resources to restore for session " + lensSession);
}
} catch (Exception e) {
- LOG.warn(
+ log.warn(
"Lens session went away! " + lensSession + " driver session: "
+ ((DriverSessionStarted) event).getDriverSessionID(), e);
} finally {
@@ -2421,7 +2420,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
Collection<ResourceEntry> dbResources = session.getDBResources(ctx.getDatabase());
if (CollectionUtils.isNotEmpty(dbResources)) {
- LOG.info("Proceeding to add resources for DB "
+ log.info("Proceeding to add resources for DB "
+ session.getCurrentDatabase() + " for query " + ctx.getLogHandle() + " resources: " + dbResources);
List<ResourceEntry> failedDBResources = addResources(dbResources, sessionHandle, hiveDriver);
@@ -2433,7 +2432,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
}
}
} else {
- LOG.info("No need to add DB resources for session: " + sessionIdentifier
+ log.info("No need to add DB resources for session: " + sessionIdentifier
+ " db= " + session.getCurrentDatabase());
}
hiveDriver.setResourcesAddedForSession(sessionIdentifier, ctx.getDatabase());
@@ -2442,7 +2441,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
// Get pending session resources which needed to be added for this database
Collection<ResourceEntry> pendingResources =
session.getPendingSessionResourcesForDatabase(ctx.getDatabase());
- LOG.info("Adding pending " + pendingResources.size() + " session resources for session " + sessionIdentifier
+ log.info("Adding pending " + pendingResources.size() + " session resources for session " + sessionIdentifier
+ " for database " + ctx.getDatabase());
List<ResourceEntry> failedResources = addResources(pendingResources, sessionHandle, hiveDriver);
// Mark added resources so that we don't add them again. If any of the resources failed
@@ -2471,7 +2470,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
addSingleResourceToHive(hiveDriver, res, sessionHandle);
} catch (LensException exc) {
failedResources.add(res);
- LOG.error("Error adding resources for session "
+ log.error("Error adding resources for session "
+ sessionHandle.getPublicId().toString() + " resources: " + res.getLocation(), exc.getCause());
}
}
@@ -2489,7 +2488,7 @@ public class QueryExecutionServiceImpl extends LensService implements QueryExecu
}
String command = "add " + res.getType().toLowerCase() + " " + uri;
driver.execute(createResourceQuery(command, sessionHandle, driver));
- LOG.info("Added resource to hive driver for session "
+ log.info("Added resource to hive driver for session "
+ sessionIdentifier + " cmd: " + command);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
----------------------------------------------------------------------
diff --git a/lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java b/lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
index 9b6d6bc..34e14b6 100644
--- a/lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
+++ b/lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
@@ -42,22 +42,20 @@ import org.apache.lens.server.api.query.QueryExecutionService;
import org.apache.lens.server.error.UnSupportedQuerySubmitOpException;
import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.LogManager;
-import org.apache.log4j.Logger;
import org.glassfish.jersey.media.multipart.FormDataParam;
+import lombok.extern.slf4j.Slf4j;
+
/**
* queryapi resource
* <p/>
* This provides api for all things query.
*/
+@Slf4j
@Path("/queryapi")
public class QueryServiceResource {
- /** The Constant LOG. */
- public static final Logger LOG = LogManager.getLogger(QueryServiceResource.class);
-
/** The query server. */
private QueryExecutionService queryServer;
@@ -269,7 +267,7 @@ public class QueryServiceResource {
}
}
} catch (Exception e) {
- LOG.error("Error canceling queries", e);
+ log.error("Error canceling queries", e);
failed = true;
}
String msgString = (StringUtils.isBlank(state) ? "" : " in state" + state)
@@ -342,7 +340,7 @@ public class QueryServiceResource {
try {
sop = SubmitOp.valueOf(operation.toUpperCase());
} catch (IllegalArgumentException e) {
- LOG.error("Illegal argument for submitop: " + operation);
+ log.error("Illegal argument for submitop: " + operation, e);
}
if (sop == null) {
throw new BadRequestException("Invalid operation type: " + operation + prepareClue);
@@ -391,7 +389,7 @@ public class QueryServiceResource {
}
}
} catch (Exception e) {
- LOG.error("Error destroying prepared queries", e);
+ log.error("Error destroying prepared queries", e);
failed = true;
}
String msgString = (StringUtils.isBlank(user) ? "" : " for user " + user);
@@ -637,7 +635,7 @@ public class QueryServiceResource {
try {
sop = SubmitOp.valueOf(operation.toUpperCase());
} catch (IllegalArgumentException e) {
- LOG.warn("illegal argument for submit operation: " + operation, e);
+ log.warn("illegal argument for submit operation: " + operation, e);
}
if (sop == null) {
throw new BadRequestException("Invalid operation type: " + operation + submitPreparedClue);
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
----------------------------------------------------------------------
diff --git a/lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java b/lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
index bb0d301..6dc4ea6 100644
--- a/lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
+++ b/lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
@@ -45,8 +45,6 @@ import org.apache.lens.server.query.QueryExecutionServiceImpl;
import org.apache.lens.server.session.LensSessionImpl.ResourceEntry;
import org.apache.commons.lang3.StringUtils;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hive.conf.HiveConf;
@@ -61,15 +59,14 @@ import org.apache.hive.service.cli.OperationHandle;
import lombok.AccessLevel;
import lombok.Getter;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class HiveSessionService.
*/
+@Slf4j
public class HiveSessionService extends LensService implements SessionService {
- /** The Constant LOG. */
- public static final Log LOG = LogFactory.getLog(HiveSessionService.class);
-
-
/** The restorable sessions. */
private List<LensSessionImpl.LensSessionPersistInfo> restorableSessions;
@@ -103,7 +100,7 @@ public class HiveSessionService extends LensService implements SessionService {
service.addResource(sessionid, type, path);
numAdded++;
} catch (LensException e) {
- LOG.error("Failed to add resource type:" + type + " path:" + path + " in service:" + service, e);
+ log.error("Failed to add resource type:" + type + " path:" + path + " in service:" + service, e);
error = true;
break;
}
@@ -205,7 +202,7 @@ public class HiveSessionService extends LensService implements SessionService {
Map<String, String> configuration)
throws LensException {
LensSessionHandle sessionid = super.openSession(username, password, configuration);
- LOG.info("Opened session " + sessionid + " for user " + username);
+ log.info("Opened session " + sessionid + " for user " + username);
notifyEvent(new SessionOpened(System.currentTimeMillis(), sessionid, username));
// Set current database
@@ -213,7 +210,7 @@ public class HiveSessionService extends LensService implements SessionService {
try {
if (!Hive.get(getSession(sessionid).getHiveConf()).databaseExists(database)) {
closeSession(sessionid);
- LOG.info("Closed session " + sessionid.getPublicId().toString() + " as db " + database + " does not exist");
+ log.info("Closed session " + sessionid.getPublicId().toString() + " as db " + database + " does not exist");
throw new NotFoundException("Database " + database + " does not exist");
}
} catch (Exception e) {
@@ -221,10 +218,10 @@ public class HiveSessionService extends LensService implements SessionService {
try {
closeSession(sessionid);
} catch (LensException e2) {
- LOG.error("Error closing session " + sessionid.getPublicId().toString(), e2);
+ log.error("Error closing session " + sessionid.getPublicId().toString(), e2);
}
- LOG.error("Error in checking if database exists " + database, e);
+ log.error("Error in checking if database exists " + database, e);
throw new LensException("Error in checking if database exists" + database, e);
} else {
throw (NotFoundException) e;
@@ -232,7 +229,7 @@ public class HiveSessionService extends LensService implements SessionService {
}
getSession(sessionid).setCurrentDatabase(database);
- LOG.info("Set database to " + database + " for session " + sessionid.getPublicId());
+ log.info("Set database to " + database + " for session " + sessionid.getPublicId());
}
// add auxuiliary jars
@@ -240,7 +237,7 @@ public class HiveSessionService extends LensService implements SessionService {
if (auxJars != null) {
for (String jar : auxJars) {
- LOG.info("Adding aux jar:" + jar);
+ log.info("Adding aux jar:" + jar);
addResourceToAllServices(sessionid, "jar", jar);
}
}
@@ -301,7 +298,7 @@ public class HiveSessionService extends LensService implements SessionService {
* @param addToSession the add to session
*/
protected void setSessionParameter(LensSessionHandle sessionid, String key, String value, boolean addToSession) {
- LOG.info("Request to Set param key:" + key + " value:" + value);
+ log.info("Request to Set param key:" + key + " value:" + value);
String command = "set" + " " + key + "= " + value;
try {
acquire(sessionid);
@@ -320,7 +317,7 @@ public class HiveSessionService extends LensService implements SessionService {
if (addToSession) {
getSession(sessionid).setConfig(key, value);
}
- LOG.info("Set param key:" + key + " value:" + value);
+ log.info("Set param key:" + key + " value:" + value);
} catch (HiveSQLException e) {
throw new WebApplicationException(e);
} finally {
@@ -354,7 +351,7 @@ public class HiveSessionService extends LensService implements SessionService {
// Restore sessions if any
if (restorableSessions == null || restorableSessions.size() <= 0) {
- LOG.info("No sessions to restore");
+ log.info("No sessions to restore");
return;
}
@@ -373,7 +370,7 @@ public class HiveSessionService extends LensService implements SessionService {
try {
addResource(sessionHandle, resourceEntry.getType(), resourceEntry.getLocation());
} catch (Exception e) {
- LOG.error("Failed to restore resource for session: " + session + " resource: " + resourceEntry);
+ log.error("Failed to restore resource for session: " + session + " resource: " + resourceEntry, e);
}
}
@@ -382,16 +379,17 @@ public class HiveSessionService extends LensService implements SessionService {
try {
setSessionParameter(sessionHandle, cfg.getKey(), cfg.getValue(), false);
} catch (Exception e) {
- LOG.error("Error setting parameter " + cfg.getKey() + "=" + cfg.getValue() + " for session: " + session);
+ log.error("Error setting parameter " + cfg.getKey() + "=" + cfg.getValue()
+ + " for session: " + session, e);
}
}
- LOG.info("Restored session " + persistInfo.getSessionHandle().getPublicId());
+ log.info("Restored session " + persistInfo.getSessionHandle().getPublicId());
notifyEvent(new SessionRestored(System.currentTimeMillis(), sessionHandle));
} catch (LensException e) {
throw new RuntimeException(e);
}
}
- LOG.info("Session service restoed " + restorableSessions.size() + " sessions");
+ log.info("Session service restoed " + restorableSessions.size() + " sessions");
}
/*
@@ -420,7 +418,7 @@ public class HiveSessionService extends LensService implements SessionService {
LensSessionImpl session = getSession(sessionHandle);
session.getLensSessionPersistInfo().writeExternal(out);
}
- LOG.info("Session service pesristed " + SESSION_MAP.size() + " sessions");
+ log.info("Session service pesristed " + SESSION_MAP.size() + " sessions");
}
/*
@@ -439,7 +437,7 @@ public class HiveSessionService extends LensService implements SessionService {
restorableSessions.add(persistInfo);
SESSION_MAP.put(persistInfo.getSessionHandle().getPublicId().toString(), persistInfo.getSessionHandle());
}
- LOG.info("Session service recovered " + SESSION_MAP.size() + " sessions");
+ log.info("Session service recovered " + SESSION_MAP.size() + " sessions");
}
/**
@@ -474,7 +472,7 @@ public class HiveSessionService extends LensService implements SessionService {
try {
getCliService().closeOperation(op);
} catch (HiveSQLException e) {
- LOG.error("Error closing operation " + op.getHandleIdentifier(), e);
+ log.error("Error closing operation " + op.getHandleIdentifier(), e);
}
}
}
@@ -511,13 +509,13 @@ public class HiveSessionService extends LensService implements SessionService {
try {
long lastAccessTime = getSession(sessionHandle).getLastAccessTime();
closeInternal(sessionHandle);
- LOG.info("Closed inactive session " + sessionHandle.getPublicId() + " last accessed at "
+ log.info("Closed inactive session " + sessionHandle.getPublicId() + " last accessed at "
+ new Date(lastAccessTime));
notifyEvent(new SessionExpired(System.currentTimeMillis(), sessionHandle));
} catch (ClientErrorException nfe) {
// Do nothing
} catch (LensException e) {
- LOG.error("Error closing session " + sessionHandle.getPublicId() + " reason " + e.getMessage());
+ log.error("Error closing session " + sessionHandle.getPublicId() + " reason " + e.getMessage(), e);
}
}
}
@@ -532,7 +530,7 @@ public class HiveSessionService extends LensService implements SessionService {
try {
runInternal();
} catch (Exception e) {
- LOG.warn("Unknown error while checking for inactive sessions - " + e.getMessage());
+ log.warn("Unknown error while checking for inactive sessions - " + e.getMessage());
}
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/main/java/org/apache/lens/server/stats/event/query/QueryExecutionStatistics.java
----------------------------------------------------------------------
diff --git a/lens-server/src/main/java/org/apache/lens/server/stats/event/query/QueryExecutionStatistics.java b/lens-server/src/main/java/org/apache/lens/server/stats/event/query/QueryExecutionStatistics.java
index 4acf748..020d540 100644
--- a/lens-server/src/main/java/org/apache/lens/server/stats/event/query/QueryExecutionStatistics.java
+++ b/lens-server/src/main/java/org/apache/lens/server/stats/event/query/QueryExecutionStatistics.java
@@ -34,9 +34,13 @@ import org.apache.hadoop.mapred.TextInputFormat;
import lombok.Getter;
import lombok.Setter;
+import lombok.extern.slf4j.Slf4j;
+
+
/**
* Statistics class used to capture query information.
*/
+@Slf4j
public class QueryExecutionStatistics extends LoggableLensStatistics {
/** The handle. */
@@ -147,7 +151,7 @@ public class QueryExecutionStatistics extends LoggableLensStatistics {
try {
table.setInputFormatClass(TextInputFormat.class.getName());
} catch (HiveException e) {
- e.printStackTrace();
+ log.error("Encountered hive exception.", e);
}
return table;
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java
----------------------------------------------------------------------
diff --git a/lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java b/lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java
index aab9771..c05a2e7 100644
--- a/lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java
+++ b/lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java
@@ -39,6 +39,7 @@ import org.apache.lens.api.response.NoErrorPayload;
import org.apache.lens.server.api.LensConfConstants;
import org.apache.commons.io.FileUtils;
+
import org.apache.hadoop.hive.conf.HiveConf;
import org.apache.hadoop.hive.metastore.TableType;
import org.apache.hadoop.hive.metastore.api.Database;
@@ -52,9 +53,12 @@ import org.glassfish.jersey.media.multipart.FormDataContentDisposition;
import org.glassfish.jersey.media.multipart.FormDataMultiPart;
import org.testng.Assert;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class LensTestUtil.
*/
+@Slf4j
public final class LensTestUtil {
public static final String DB_WITH_JARS = "test_db_static_jars";
@@ -283,7 +287,7 @@ public final class LensTestUtil {
FileUtils.copyFile(testJarFile, new File(dbDir, jarOrder[2]));
FileUtils.copyFile(serdeJarFile, new File(dbDir, jarOrder[3]));
} catch (FileNotFoundException fnf) {
- fnf.printStackTrace();
+ log.error("File not found.", fnf);
}
}
}
[3/3] incubator-lens git commit: LENS-551: Cleanup testcases of
exception stack traces
Posted by pr...@apache.org.
LENS-551: Cleanup testcases of exception stack traces
Project: http://git-wip-us.apache.org/repos/asf/incubator-lens/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-lens/commit/b0783db7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-lens/tree/b0783db7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-lens/diff/b0783db7
Branch: refs/heads/master
Commit: b0783db7976d207b6544dcf2d9f8e5685994f9b4
Parents: 82553db
Author: Yash Sharma <ya...@gmail.com>
Authored: Wed May 27 20:01:26 2015 +0530
Committer: Rajat Khandelwal <ra...@gmail.com>
Committed: Wed May 27 20:01:26 2015 +0530
----------------------------------------------------------------------
checkstyle/src/main/resources/checkstyle.xml | 7 +
.../lens/cli/commands/BaseLensCommand.java | 10 +-
.../cli/commands/LensConnectionCommands.java | 7 +-
.../lens/cli/TestLensDimensionCommands.java | 16 +-
.../cli/TestLensDimensionTableCommands.java | 24 ++-
.../apache/lens/cli/TestLensFactCommands.java | 27 ++-
.../apache/lens/cli/TestLensQueryCommands.java | 31 ++-
.../apache/lens/client/jdbc/LensJdbcDriver.java | 6 +-
.../org/apache/lens/cube/parse/HQLParser.java | 7 +-
.../timeline/TestPartitionTimelines.java | 6 +-
.../apache/lens/cube/parse/CubeTestSetup.java | 6 +-
.../lens/cube/parse/TestCubeRewriter.java | 7 +-
.../apache/lens/cube/parse/TestDateUtil.java | 6 +-
.../apache/lens/cube/parse/TestHQLParser.java | 6 +-
.../lens/cube/parse/TestMaxUpdateInterval.java | 6 +-
.../lens/cube/parse/TestQueryRewrite.java | 3 +-
.../lens/cube/parse/TestTimeRangeWriter.java | 5 +-
.../parse/TestTimeRangeWriterWithQuery.java | 6 +-
.../org/apache/lens/driver/hive/HiveDriver.java | 95 +++++----
.../lens/driver/hive/HiveInMemoryResultSet.java | 5 +-
.../apache/lens/driver/hive/HiveQueryPlan.java | 5 +-
.../lens/driver/hive/TestRemoteHiveDriver.java | 27 ++-
.../driver/jdbc/TestColumnarSQLRewriter.java | 7 +-
.../jdbc/TestDataSourceConnectionProvider.java | 15 +-
.../apache/lens/driver/jdbc/TestJdbcDriver.java | 32 ++--
.../apache/lens/examples/SampleMetastore.java | 6 +-
.../org/apache/lens/client/LensMLClient.java | 9 +-
.../apache/lens/ml/algo/lib/AlgoArgParser.java | 11 +-
.../org/apache/lens/ml/impl/LensMLImpl.java | 71 ++++---
.../java/org/apache/lens/ml/TestMLResource.java | 25 ++-
.../apache/lens/server/LensRequestListener.java | 5 +-
.../lens/server/LensServletContextListener.java | 5 +-
.../metastore/CubeMetastoreServiceImpl.java | 76 ++++----
.../apache/lens/server/metastore/JAXBUtils.java | 12 +-
.../lens/server/metrics/MetricsServiceImpl.java | 17 +-
.../apache/lens/server/query/LensServerDAO.java | 21 +-
.../server/query/QueryExecutionServiceImpl.java | 191 +++++++++----------
.../lens/server/query/QueryServiceResource.java | 16 +-
.../lens/server/session/HiveSessionService.java | 50 +++--
.../event/query/QueryExecutionStatistics.java | 6 +-
.../org/apache/lens/server/LensTestUtil.java | 6 +-
.../server/metastore/TestMetastoreService.java | 18 +-
.../lens/server/query/TestQueryService.java | 22 +--
.../session/TestDatabaseResourceService.java | 10 +-
.../stats/TestStatisticsLogFileScannerTask.java | 5 +-
45 files changed, 498 insertions(+), 456 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/checkstyle/src/main/resources/checkstyle.xml
----------------------------------------------------------------------
diff --git a/checkstyle/src/main/resources/checkstyle.xml b/checkstyle/src/main/resources/checkstyle.xml
index d6ff839..031d664 100644
--- a/checkstyle/src/main/resources/checkstyle.xml
+++ b/checkstyle/src/main/resources/checkstyle.xml
@@ -245,6 +245,13 @@
<property name="checkFormat" value="ParameterNumberCheck|VisibilityModifierCheck|HiddenFieldCheck|MethodName|HideUtilityClassConstructorCheck|DoubleCheckedLockingCheck|InnerAssignmentCheck"/>
</module>
+ <module name="RegexpSingleline">
+ <property name="severity" value="error" />
+ <property name="format" value="\w*.printStackTrace\w*" />
+ <property name="message" value="Print stack trace not allowed. Use Logger." />
+ <property name="fileExtensions" value="java" />
+ </module>
+
<!--module name="SuppressionFilter">
<property name="file" value="checkstyle/src/main/resources/suppressions.xml"/>
</module-->
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java
----------------------------------------------------------------------
diff --git a/lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java b/lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java
index d6055cd..3deddfa 100644
--- a/lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java
+++ b/lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java
@@ -27,8 +27,6 @@ import java.util.Date;
import org.apache.lens.client.LensClient;
import org.apache.lens.client.LensClientSingletonWrapper;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.codehaus.jackson.JsonGenerationException;
import org.codehaus.jackson.JsonGenerator;
@@ -41,9 +39,12 @@ import org.springframework.shell.event.ParseResult;
import com.google.common.collect.Sets;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class BaseLensCommand.
*/
+@Slf4j
public class BaseLensCommand implements ExecutionProcessor {
/** The mapper. */
@@ -52,9 +53,6 @@ public class BaseLensCommand implements ExecutionProcessor {
/** The pp. */
protected DefaultPrettyPrinter pp;
- /** The Constant LOG. */
- public static final Log LOG = LogFactory.getLog(BaseLensCommand.class);
-
/** The is connection active. */
protected static boolean isConnectionActive;
public static final String DATE_FMT = "yyyy-MM-dd'T'HH:mm:ss:SSS";
@@ -84,7 +82,7 @@ public class BaseLensCommand implements ExecutionProcessor {
*/
protected static synchronized void closeClientConnection() {
if (isConnectionActive) {
- LOG.debug("Request for stopping lens cli received");
+ log.debug("Request for stopping lens cli received");
getClient().closeConnection();
isConnectionActive = false;
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
----------------------------------------------------------------------
diff --git a/lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java b/lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
index d727ecc..675e6c8 100644
--- a/lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
+++ b/lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
@@ -32,9 +32,13 @@ import org.springframework.stereotype.Component;
import com.google.common.base.Joiner;
+import lombok.extern.slf4j.Slf4j;
+
+
/**
* The Class LensConnectionCommands.
*/
+@Slf4j
@Component
@UserDocumentation(title = "Session management",
description = "Opening the lens CLI shell is equivalent to open a session with lens server."
@@ -159,8 +163,7 @@ public class LensConnectionCommands extends BaseLensCommand {
closeClientConnection();
return ExitShellRequest.NORMAL_EXIT;
} catch (ProcessingException e) {
- System.out.println(e.getMessage());
- LOG.error(e);
+ log.error("Error while closing client connection.", e);
return ExitShellRequest.FATAL_EXIT;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java
----------------------------------------------------------------------
diff --git a/lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java b/lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java
index 5df3486..208eb78 100644
--- a/lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java
+++ b/lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java
@@ -25,19 +25,17 @@ import java.net.URL;
import org.apache.lens.cli.commands.LensDimensionCommands;
import org.apache.lens.client.LensClient;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import org.testng.Assert;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class TestLensDimensionCommands.
*/
+@Slf4j
public class TestLensDimensionCommands extends LensCliApplicationTest {
- /** The Constant LOG. */
- private static final Logger LOG = LoggerFactory.getLogger(TestLensDimensionCommands.class);
-
/** The command. */
private static LensDimensionCommands command = null;
@@ -69,7 +67,7 @@ public class TestLensDimensionCommands extends LensCliApplicationTest {
*/
@Test
public void testDimensionCommands() throws Exception {
- LOG.debug("Starting to test dimension commands");
+ log.debug("Starting to test dimension commands");
URL dimensionSpec = TestLensDimensionCommands.class.getClassLoader().getResource("test-dimension.xml");
String dimensionList = getCommand().showDimensions();
Assert.assertFalse(dimensionList.contains("test_dim"));
@@ -114,14 +112,14 @@ public class TestLensDimensionCommands extends LensCliApplicationTest {
writer.close();
String desc = command.describeDimension("test_dim");
- LOG.debug(desc);
+ log.debug(desc);
String propString = "name : test_dim.prop value : test";
String propString1 = "name : test_dim.prop1 value : test1";
Assert.assertTrue(desc.contains(propString));
command.updateDimension("test_dim", "/tmp/test_dim1.xml");
desc = command.describeDimension("test_dim");
- LOG.debug(desc);
+ log.debug(desc);
Assert.assertTrue(desc.contains(propString));
Assert.assertTrue(desc.contains(propString1));
@@ -129,7 +127,7 @@ public class TestLensDimensionCommands extends LensCliApplicationTest {
newFile.delete();
} catch (Throwable t) {
- t.printStackTrace();
+ log.error("Testing update dimension failed with exception", t);
Assert.fail("Testing update dimension failed with exception" + t.getMessage());
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java
----------------------------------------------------------------------
diff --git a/lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java b/lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java
index a98f183..a87d0b7 100644
--- a/lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java
+++ b/lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java
@@ -28,19 +28,17 @@ import org.apache.lens.cli.commands.LensDimensionCommands;
import org.apache.lens.cli.commands.LensDimensionTableCommands;
import org.apache.lens.client.LensClient;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import org.testng.Assert;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class TestLensDimensionTableCommands.
*/
+@Slf4j
public class TestLensDimensionTableCommands extends LensCliApplicationTest {
- /** The Constant LOG. */
- private static final Logger LOG = LoggerFactory.getLogger(TestLensDimensionTableCommands.class);
-
/** The Constant DIM_LOCAL. */
public static final String DIM_LOCAL = "dim_local";
@@ -116,7 +114,7 @@ public class TestLensDimensionTableCommands extends LensCliApplicationTest {
try {
command.createDimensionTable(new File(dimSpec.toURI()).getAbsolutePath());
} catch (Exception e) {
- e.printStackTrace();
+ log.error("Unable to create dimtable", e);
Assert.fail("Unable to create dimtable" + e.getMessage());
}
@@ -126,13 +124,13 @@ public class TestLensDimensionTableCommands extends LensCliApplicationTest {
Assert.assertEquals(command.showDimensionTables("blah"), dimList);
Assert.fail();
} catch (NotFoundException e) {
- LOG.info("blah is not a table", e);
+ log.info("blah is not a table", e);
}
try {
Assert.assertEquals(command.showDimensionTables("dim_table2"), dimList);
Assert.fail();
} catch (NotFoundException e) {
- LOG.info("dim_table2 is a table, but not a dimension", e);
+ log.info("dim_table2 is a table, but not a dimension", e);
}
Assert.assertTrue(dimList.contains(tableName), "dim_table table should be found");
}
@@ -166,7 +164,7 @@ public class TestLensDimensionTableCommands extends LensCliApplicationTest {
writer.close();
String desc = command.describeDimensionTable("dim_table2");
- LOG.debug(desc);
+ log.debug(desc);
String propString = "name : dim2.prop value : d2";
String propString1 = "name : dim2.prop value : d1";
String propString2 = "name : dim2.prop1 value : d2";
@@ -174,7 +172,7 @@ public class TestLensDimensionTableCommands extends LensCliApplicationTest {
command.updateDimensionTable("dim_table2", "/tmp/local-dim1.xml");
desc = command.describeDimensionTable("dim_table2");
- LOG.debug(desc);
+ log.debug(desc);
Assert.assertTrue(desc.contains(propString1));
Assert.assertTrue(desc.contains(propString2));
@@ -234,7 +232,7 @@ public class TestLensDimensionTableCommands extends LensCliApplicationTest {
command.addPartitionToDimtable("dim_table2", DIM_LOCAL, new File(
TestLensFactCommands.class.getClassLoader().getResource("dim1-local-part.xml").toURI()).getAbsolutePath());
} catch (Throwable t) {
- t.printStackTrace();
+ log.error("Unable to locate the storage part file for adding new storage to dim table dim_table2", t);
Assert.fail("Unable to locate the storage part file for adding new storage to dim table dim_table2");
}
verifyAndDeletePartition();
@@ -242,7 +240,7 @@ public class TestLensDimensionTableCommands extends LensCliApplicationTest {
command.addPartitionsToDimtable("dim_table2", DIM_LOCAL, new File(
TestLensFactCommands.class.getClassLoader().getResource("dim1-local-parts.xml").toURI()).getAbsolutePath());
} catch (Throwable t) {
- t.printStackTrace();
+ log.error("Unable to locate the storage part file for adding new storage to dim table dim_table2", t);
Assert.fail("Unable to locate the storage part file for adding new storage to dim table dim_table2");
}
verifyAndDeletePartition();
@@ -270,7 +268,7 @@ public class TestLensDimensionTableCommands extends LensCliApplicationTest {
try {
command.addPartitionToDimtable(tableName, storageName, new File(resource.toURI()).getAbsolutePath());
} catch (Throwable t) {
- t.printStackTrace();
+ log.error("Unable to locate the storage part file for adding new storage to dim table dim_table2", t);
Assert.fail("Unable to locate the storage part file for adding new storage to dim table dim_table2");
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java
----------------------------------------------------------------------
diff --git a/lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java b/lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java
index 19979cc..1ad234d 100644
--- a/lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java
+++ b/lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java
@@ -31,18 +31,16 @@ import org.apache.lens.cli.commands.LensCubeCommands;
import org.apache.lens.cli.commands.LensFactCommands;
import org.apache.lens.client.LensClient;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class TestLensFactCommands.
*/
+@Slf4j
public class TestLensFactCommands extends LensCliApplicationTest {
- /** The Constant LOG. */
- private static final Logger LOG = LoggerFactory.getLogger(TestLensFactCommands.class);
-
/** The Constant FACT_LOCAL. */
public static final String FACT_LOCAL = "fact_local";
@@ -119,13 +117,13 @@ public class TestLensFactCommands extends LensCliApplicationTest {
assertEquals(command.showFacts("blah"), factList);
fail();
} catch (NotFoundException e) {
- LOG.info("blah is not a table", e);
+ log.info("blah is not a table", e);
}
try {
assertEquals(command.showFacts("fact1"), factList);
fail();
} catch (NotFoundException e) {
- LOG.info("fact1 is a table, but not a cube table", e);
+ log.info("fact1 is a table, but not a cube table", e);
}
assertEquals("fact1", factList, "Fact1 table should be found");
}
@@ -157,7 +155,7 @@ public class TestLensFactCommands extends LensCliApplicationTest {
writer.close();
String desc = command.describeFactTable("fact1");
- LOG.debug(desc);
+ log.debug(desc);
String propString = "name : fact1.prop value : f1";
String propString1 = "name : fact1.prop1 value : f2";
@@ -165,15 +163,14 @@ public class TestLensFactCommands extends LensCliApplicationTest {
command.updateFactTable("fact1", "/tmp/local-fact1.xml");
desc = command.describeFactTable("fact1");
- LOG.debug(desc);
+ log.debug(desc);
assertTrue(desc.contains(propString), "The sample property value is not set");
-
assertTrue(desc.contains(propString1), "The sample property value is not set");
newFile.delete();
} catch (Throwable t) {
- t.printStackTrace();
+ log.error("Updating of the fact1 table failed with ", t);
fail("Updating of the fact1 table failed with " + t.getMessage());
}
@@ -208,7 +205,7 @@ public class TestLensFactCommands extends LensCliApplicationTest {
try {
command.addNewFactStorage("fact1", new File(resource.toURI()).getAbsolutePath());
} catch (Throwable t) {
- t.printStackTrace();
+ log.error("Unable to locate the storage part file for adding new storage to fact table fact1", t);
fail("Unable to locate the storage part file for adding new storage to fact table fact1");
}
result = command.getFactStorages("fact1");
@@ -233,15 +230,15 @@ public class TestLensFactCommands extends LensCliApplicationTest {
command.addPartitionToFact("fact1", FACT_LOCAL, new File(
TestLensFactCommands.class.getClassLoader().getResource("fact1-local-part.xml").toURI()).getAbsolutePath());
} catch (Throwable t) {
- t.printStackTrace();
+ log.error("Unable to locate the storage part file for adding new storage to fact table fact1", t);
fail("Unable to locate the storage part file for adding new storage to fact table fact1");
}
verifyAndDeletePartitions();
try {
command.addPartitionsToFact("fact1", FACT_LOCAL, new File(
- TestLensFactCommands.class.getClassLoader().getResource("fact1-local-parts.xml").toURI()).getAbsolutePath());
+ TestLensFactCommands.class.getClassLoader().getResource("fact1-local-parts.xml").toURI()).getAbsolutePath());
} catch (Throwable t) {
- t.printStackTrace();
+ log.error("Unable to locate the storage part file for adding new storage to fact table fact1", t);
fail("Unable to locate the storage part file for adding new storage to fact table fact1");
}
verifyAndDeletePartitions();
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java
----------------------------------------------------------------------
diff --git a/lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java b/lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java
index 5724d24..32a89ac 100644
--- a/lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java
+++ b/lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java
@@ -43,18 +43,16 @@ import org.apache.lens.driver.hive.TestHiveDriver;
import org.apache.commons.lang.StringUtils;
import org.apache.hadoop.fs.Path;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class TestLensQueryCommands.
*/
+@Slf4j
public class TestLensQueryCommands extends LensCliApplicationTest {
- /** The Constant LOG. */
- private static final Logger LOG = LoggerFactory.getLogger(TestLensQueryCommands.class);
-
/** The client. */
private LensClient client;
@@ -130,29 +128,29 @@ public class TestLensQueryCommands extends LensCliApplicationTest {
result = qCom.executePreparedQuery(qh, false, "testPrepQuery1");
- LOG.warn("XXXXXX Prepared query sync result is " + result);
+ log.warn("XXXXXX Prepared query sync result is " + result);
assertTrue(result.contains("1\tfirst"));
String handle = qCom.executePreparedQuery(qh, true, "testPrepQuery2");
- LOG.debug("Perpared query handle is " + handle);
+ log.debug("Perpared query handle is " + handle);
while (!client.getQueryStatus(handle).finished()) {
Thread.sleep(5000);
}
String status = qCom.getStatus(handle);
- LOG.debug("Prepared Query Status is " + status);
+ log.debug("Prepared Query Status is " + status);
assertTrue(status.contains("Status : SUCCESSFUL"));
result = qCom.getQueryResults(handle, null);
- LOG.debug("Prepared Query Result is " + result);
+ log.debug("Prepared Query Result is " + result);
assertTrue(result.contains("1\tfirst"));
// Fetch again.
result = qCom.getQueryResults(handle, null);
- LOG.debug("Prepared Query Result is " + result);
+ log.debug("Prepared Query Result is " + result);
assertTrue(result.contains("1\tfirst"));
result = qCom.destroyPreparedQuery(qh);
- LOG.debug("destroy result is " + result);
+ log.debug("destroy result is " + result);
assertEquals("Successfully destroyed " + qh, result);
result = qCom.getAllPreparedQueries("testPreparedName", "all", submitTime, Long.MAX_VALUE);
@@ -195,9 +193,8 @@ public class TestLensQueryCommands extends LensCliApplicationTest {
String sql = "cube select id, name from test_dim";
String result = qCom.explainQuery(sql, "");
- LOG.debug(result);
+ log.debug(result);
assertTrue(result.contains(explainPlan));
-
}
/**
@@ -210,7 +207,7 @@ public class TestLensQueryCommands extends LensCliApplicationTest {
String sql = "cube select id2, name from test_dim";
String result = qCom.explainQuery(sql, "");
- LOG.debug(result);
+ log.debug(result);
assertTrue(result.contains("Explain FAILED:"));
result = qCom.explainAndPrepare(sql, "");
@@ -318,7 +315,7 @@ public class TestLensQueryCommands extends LensCliApplicationTest {
LensCubeCommands command = new LensCubeCommands();
command.setClient(client);
- LOG.debug("Starting to test cube commands");
+ log.debug("Starting to test cube commands");
URL cubeSpec = TestLensQueryCommands.class.getClassLoader().getResource("sample-cube.xml");
command.createCube(new File(cubeSpec.toURI()).getAbsolutePath());
TestLensDimensionCommands.createDimension();
@@ -367,7 +364,7 @@ public class TestLensQueryCommands extends LensCliApplicationTest {
assertNotNull(result);
assertFalse(result.contains("Failed to get resultset"));
} catch (Exception exc) {
- exc.printStackTrace();
+ log.error("Exception not expected while getting resultset.", exc);
fail("Exception not expected: " + exc.getMessage());
}
System.out.println("@@END_PERSISTENT_RESULT_TEST-------------");
@@ -397,7 +394,7 @@ public class TestLensQueryCommands extends LensCliApplicationTest {
// This is to check for positive processing time
assertFalse(result.contains("(-"));
} catch (Exception exc) {
- exc.printStackTrace();
+ log.error("Exception not expected while purging resultset.", exc);
fail("Exception not expected: " + exc.getMessage());
}
System.out.println("@@END_FINISHED_PURGED_RESULT_TEST-------------");
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDriver.java
----------------------------------------------------------------------
diff --git a/lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDriver.java b/lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDriver.java
index a6fae87..056a0b2 100644
--- a/lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDriver.java
+++ b/lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDriver.java
@@ -23,16 +23,20 @@ import java.util.Properties;
import java.util.logging.Logger;
import java.util.regex.Pattern;
+import lombok.extern.slf4j.Slf4j;
+
/**
* Top level JDBC driver for Lens.
*/
+@Slf4j
public class LensJdbcDriver implements Driver {
+
static {
try {
DriverManager.registerDriver(new LensJdbcDriver());
} catch (SQLException e) {
- e.printStackTrace();
+ log.error("Error in registering jdbc driver", e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java
----------------------------------------------------------------------
diff --git a/lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java b/lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java
index 1c375ed..7b99310 100644
--- a/lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java
+++ b/lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java
@@ -40,7 +40,12 @@ import org.antlr.runtime.tree.Tree;
import com.google.common.base.Optional;
+import lombok.extern.slf4j.Slf4j;
+
+
+@Slf4j
public final class HQLParser {
+
private HQLParser() {
}
@@ -168,7 +173,7 @@ public final class HQLParser {
try {
printAST(getHiveTokenMapping(), node, 0, 0);
} catch (Exception e) {
- e.printStackTrace();
+ log.error("Error in printing AST.", e);
}
System.out.println();
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java
----------------------------------------------------------------------
diff --git a/lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java b/lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java
index 0231e8b..0268bbf 100644
--- a/lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java
+++ b/lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java
@@ -30,7 +30,11 @@ import org.testng.annotations.Test;
import com.beust.jcommander.internal.Lists;
+import lombok.extern.slf4j.Slf4j;
+
+@Slf4j
public class TestPartitionTimelines {
+
private static final String TABLE_NAME = "storage_fact";
public static final UpdatePeriod PERIOD = UpdatePeriod.HOURLY;
private static final String PART_COL = "pt";
@@ -103,7 +107,7 @@ public class TestPartitionTimelines {
return clz.getConstructor(String.class, UpdatePeriod.class, String.class)
.newInstance(TABLE_NAME, PERIOD, PART_COL);
} catch (Exception e) {
- e.printStackTrace();
+ log.error("Error while getting instance.", e);
}
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
----------------------------------------------------------------------
diff --git a/lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java b/lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
index 1fb8556..914fe1b 100644
--- a/lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
+++ b/lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
@@ -1331,9 +1331,9 @@ public class CubeTestSetup {
try {
client.addPartition(sPartSpec, c1);
} catch (HiveException e) {
- e.printStackTrace();
+ log.error("Encountered Hive exception.", e);
} catch (LensException e) {
- e.printStackTrace();
+ log.error("Encountered Lens exception.", e);
}
cal.add(Calendar.HOUR_OF_DAY, 1);
temp = cal.getTime();
@@ -2047,7 +2047,7 @@ public class CubeTestSetup {
createStateTable(client);
createCubeFactsWithValidColumns(client);
} catch (Exception exc) {
- exc.printStackTrace();
+ log.error("Exception while creating sources.", exc);
throw exc;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
----------------------------------------------------------------------
diff --git a/lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java b/lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
index 9274ccf..0f1ad6e 100644
--- a/lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
+++ b/lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
@@ -44,6 +44,9 @@ import org.apache.hadoop.hive.ql.processors.CommandProcessorResponse;
import org.testng.annotations.BeforeTest;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
+@Slf4j
public class TestCubeRewriter extends TestQueryRewrite {
private final String cubeName = CubeTestSetup.TEST_CUBE_NAME;
@@ -1451,7 +1454,7 @@ public class TestCubeRewriter extends TestQueryRewrite {
assertTrue(hql.contains("`a measure`"));
System.out.println("@@ hql: " + hql);
} catch (NullPointerException npe) {
- npe.printStackTrace();
+ log.error("Not expecting null pointer exception", npe);
fail("Not expecting null pointer exception");
}
}
@@ -1502,7 +1505,7 @@ public class TestCubeRewriter extends TestQueryRewrite {
System.out.println("@@HQL " + hql);
} catch (NullPointerException npe) {
fail(npe.getMessage());
- npe.printStackTrace();
+ log.error("Not expecting null pointer exception", npe);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java
----------------------------------------------------------------------
diff --git a/lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java b/lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java
index a916dbf..6717b5b 100644
--- a/lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java
+++ b/lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java
@@ -45,10 +45,14 @@ import org.testng.annotations.Test;
import com.beust.jcommander.internal.Sets;
import com.google.common.collect.Lists;
+import lombok.extern.slf4j.Slf4j;
+
/**
* Unit tests for cube DateUtil class TestDateUtil.
*/
+@Slf4j
public class TestDateUtil {
+
public static final String[] TEST_PAIRS = {
"2013-Jan-01", "2013-Jan-31", "2013-Jan-01", "2013-May-31",
"2013-Jan-01", "2013-Dec-31", "2013-Feb-01", "2013-Apr-25",
@@ -67,7 +71,7 @@ public class TestDateUtil {
try {
pairs[i] = DATE_FMT.parse(TEST_PAIRS[i]);
} catch (ParseException e) {
- e.printStackTrace();
+ log.error("Parsing exception while setup.", e);
}
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java
----------------------------------------------------------------------
diff --git a/lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java b/lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java
index fef634d..b0b2e88 100644
--- a/lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java
+++ b/lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java
@@ -31,7 +31,11 @@ import org.apache.hadoop.hive.ql.parse.ParseException;
import org.testng.Assert;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
+@Slf4j
public class TestHQLParser {
+
HiveConf conf = new HiveConf();
@Test
public void testGroupByOrderByGetString() throws Exception {
@@ -238,7 +242,7 @@ public class TestHQLParser {
try {
ASTNode tree = HQLParser.parseHQL(query, conf);
} catch (NullPointerException exc) {
- exc.printStackTrace();
+ log.error("should not have thrown npe", exc);
Assert.fail("should not have thrown npe");
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cube/src/test/java/org/apache/lens/cube/parse/TestMaxUpdateInterval.java
----------------------------------------------------------------------
diff --git a/lens-cube/src/test/java/org/apache/lens/cube/parse/TestMaxUpdateInterval.java b/lens-cube/src/test/java/org/apache/lens/cube/parse/TestMaxUpdateInterval.java
index a5f64ec..7e5f38d 100644
--- a/lens-cube/src/test/java/org/apache/lens/cube/parse/TestMaxUpdateInterval.java
+++ b/lens-cube/src/test/java/org/apache/lens/cube/parse/TestMaxUpdateInterval.java
@@ -32,10 +32,14 @@ import org.apache.lens.cube.metadata.UpdatePeriod;
import org.testng.Assert;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
/*
* Unit test for maxUpdateIntervalIn method in CubeFactTable
*/
+@Slf4j
public class TestMaxUpdateInterval {
+
public static final String[] TEST_PAIRS = {
"2013-Jan-01", "2013-Jan-31", "2013-Jan-01", "2013-May-31",
"2013-Jan-01", "2013-Dec-31", "2013-Feb-01", "2013-Apr-25",
@@ -54,7 +58,7 @@ public class TestMaxUpdateInterval {
pairs[i] = DATE_FMT.parse(TEST_PAIRS[i]);
System.out.println(pairs[i].toString());
} catch (ParseException e) {
- e.printStackTrace();
+ log.error("Parsing exception while testing max update interval.", e);
}
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java
----------------------------------------------------------------------
diff --git a/lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java b/lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java
index 994a244..d16f6a5 100644
--- a/lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java
+++ b/lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java
@@ -31,6 +31,7 @@ import org.apache.hadoop.hive.ql.session.SessionState;
import org.codehaus.jackson.map.ObjectMapper;
import org.codehaus.jackson.type.TypeReference;
+
import org.testng.Assert;
import org.testng.annotations.AfterSuite;
import org.testng.annotations.BeforeClass;
@@ -103,7 +104,7 @@ public abstract class TestQueryRewrite {
// unreachable
return null;
} catch (SemanticException e) {
- e.printStackTrace();
+ log.error("Semantic exception in Rewrite.", e);
return e;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java
----------------------------------------------------------------------
diff --git a/lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java b/lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java
index 106660e..453a102 100644
--- a/lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java
+++ b/lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java
@@ -33,6 +33,9 @@ import org.apache.hadoop.hive.ql.parse.SemanticException;
import org.testng.Assert;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
+@Slf4j
public abstract class TestTimeRangeWriter {
public abstract TimeRangeWriter getTimerangeWriter();
@@ -59,7 +62,7 @@ public abstract class TestTimeRangeWriter {
try {
whereClause = getTimerangeWriter().getTimeRangeWhereClause(null, "test", answeringParts);
} catch (SemanticException e) {
- e.printStackTrace();
+ log.error("Semantic exception while testing disjoint parts.", e);
th = e;
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
----------------------------------------------------------------------
diff --git a/lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java b/lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
index b5aaeb2..0e22ce2 100644
--- a/lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
+++ b/lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
@@ -36,6 +36,10 @@ import org.testng.Assert;
import org.testng.annotations.BeforeTest;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
+
+@Slf4j
public class TestTimeRangeWriterWithQuery extends TestQueryRewrite {
private Configuration conf;
@@ -76,7 +80,7 @@ public class TestTimeRangeWriterWithQuery extends TestQueryRewrite {
rewrite("cube select" + " SUM(msr2) from testCube where " + TWO_DAYS_RANGE, conf);
} catch (SemanticException e) {
th = e;
- e.printStackTrace();
+ log.error("Semantic exception while testing cube query.", e);
}
if (!CubeTestSetup.isZerothHour()) {
Assert.assertNotNull(th);
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
----------------------------------------------------------------------
diff --git a/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
index 8bec5e0..052d0e2 100644
--- a/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
+++ b/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
@@ -61,19 +61,18 @@ import org.apache.hive.service.cli.*;
import org.apache.hive.service.cli.thrift.TOperationHandle;
import org.apache.hive.service.cli.thrift.TProtocolVersion;
import org.apache.hive.service.cli.thrift.TSessionHandle;
-import org.apache.log4j.Logger;
import org.codehaus.jackson.map.ObjectMapper;
import org.codehaus.jackson.type.TypeReference;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class HiveDriver.
*/
+@Slf4j
public class HiveDriver implements LensDriver {
- /** The Constant LOG. */
- public static final Logger LOG = Logger.getLogger(HiveDriver.class);
-
/** The Constant HIVE_CONNECTION_CLASS. */
public static final String HIVE_CONNECTION_CLASS = "lens.driver.hive.connection.class";
@@ -186,15 +185,15 @@ public class HiveDriver implements LensDriver {
if (thConn != null) {
try {
- LOG.info("Closed connection:" + expired.getConnId());
+ log.info("Closed connection:" + expired.getConnId());
thConn.close();
} catch (IOException e) {
- LOG.error("Error closing connection", e);
+ log.error("Error closing connection", e);
}
}
}
} catch (InterruptedException intr) {
- LOG.warn("Connection expiry thread interrupted", intr);
+ log.warn("Connection expiry thread interrupted", intr);
return;
}
}
@@ -309,7 +308,7 @@ public class HiveDriver implements LensDriver {
connectionExpiryThread.setName("HiveDriver-ConnectionExpiryThread");
connectionExpiryThread.start();
driverListeners = new ArrayList<LensEventListener<DriverEvent>>();
- LOG.info("Hive driver inited");
+ log.info("Hive driver inited");
}
@Override
@@ -350,7 +349,7 @@ public class HiveDriver implements LensDriver {
@Override
public QueryCost estimate(AbstractQueryContext qctx) throws LensException {
- LOG.info("Estimate: " + qctx.getDriverQuery(this));
+ log.info("Estimate: " + qctx.getDriverQuery(this));
if (qctx.getDriverQuery(this) == null) {
throw new NullPointerException("Null driver query for " + qctx.getUserQuery());
}
@@ -382,7 +381,7 @@ public class HiveDriver implements LensDriver {
// explain called again and again
return (HiveQueryPlan) explainCtx.getDriverContext().getDriverQueryPlan(this);
}
- LOG.info("Explain: " + explainCtx.getDriverQuery(this));
+ log.info("Explain: " + explainCtx.getDriverQuery(this));
Configuration explainConf = new Configuration(explainCtx.getDriverConf(this));
explainConf.setClassLoader(explainCtx.getConf().getClassLoader());
explainConf.setBoolean(LensConfConstants.QUERY_PERSISTENT_RESULT_INDRIVER, false);
@@ -461,7 +460,7 @@ public class HiveDriver implements LensDriver {
qdconf.set("mapred.job.name", ctx.getQueryHandle().toString());
OperationHandle op = getClient().executeStatement(getSession(ctx), ctx.getSelectedDriverQuery(),
qdconf.getValByRegex(".*"));
- LOG.info("The hive operation handle: " + op);
+ log.info("The hive operation handle: " + op);
ctx.setDriverOpHandle(op.toString());
hiveHandles.put(ctx.getQueryHandle(), op);
updateStatus(ctx);
@@ -498,24 +497,24 @@ public class HiveDriver implements LensDriver {
Configuration qdconf = ctx.getDriverConf(this);
qdconf.set("mapred.job.name", ctx.getQueryHandle().toString());
//Query is already explained.
- LOG.info("whetherCalculatePriority: " + whetherCalculatePriority);
+ log.info("whetherCalculatePriority: " + whetherCalculatePriority);
if (whetherCalculatePriority) {
try {
// Inside try since non-data fetching queries can also be executed by async method.
String priority = queryPriorityDecider.decidePriority(ctx).toString();
qdconf.set("mapred.job.priority", priority);
- LOG.info("set priority to " + priority);
+ log.info("set priority to " + priority);
} catch (Exception e) {
// not failing query launch when setting priority fails
// priority will be set to usually NORMAL - the default in underlying system.
- LOG.error("could not set priority for lens session id:" + ctx.getLensSessionIdentifier()
+ log.error("could not set priority for lens session id:" + ctx.getLensSessionIdentifier()
+ "User query: " + ctx.getUserQuery(), e);
}
}
OperationHandle op = getClient().executeStatementAsync(getSession(ctx), ctx.getSelectedDriverQuery(),
qdconf.getValByRegex(".*"));
ctx.setDriverOpHandle(op.toString());
- LOG.info("QueryHandle: " + ctx.getQueryHandle() + " HiveHandle:" + op);
+ log.info("QueryHandle: " + ctx.getQueryHandle() + " HiveHandle:" + op);
hiveHandles.put(ctx.getQueryHandle(), op);
} catch (IOException e) {
throw new LensException("Error adding persistent path", e);
@@ -532,7 +531,7 @@ public class HiveDriver implements LensDriver {
*/
@Override
public void updateStatus(QueryContext context) throws LensException {
- LOG.debug("GetStatus: " + context.getQueryHandle());
+ log.debug("GetStatus: " + context.getQueryHandle());
if (context.getDriverStatus().isFinished()) {
return;
}
@@ -540,9 +539,9 @@ public class HiveDriver implements LensDriver {
ByteArrayInputStream in = null;
try {
// Get operation status from hive server
- LOG.debug("GetStatus hiveHandle: " + hiveHandle);
+ log.debug("GetStatus hiveHandle: " + hiveHandle);
OperationStatus opStatus = getClient().getOperationStatus(hiveHandle);
- LOG.debug("GetStatus on hiveHandle: " + hiveHandle + " returned state:" + opStatus.getState().name());
+ log.debug("GetStatus on hiveHandle: " + hiveHandle + " returned state:" + opStatus.getState().name());
switch (opStatus.getState()) {
case CANCELED:
@@ -605,7 +604,7 @@ public class HiveDriver implements LensDriver {
progress = taskStatuses.size() == 0 ? 0 : (float) completedTasks / taskStatuses.size();
errorMsg = errorMessage.toString();
} else {
- LOG.warn("Empty task statuses");
+ log.warn("Empty task statuses");
}
String error = null;
if (StringUtils.isNotBlank(errorMsg)) {
@@ -619,7 +618,7 @@ public class HiveDriver implements LensDriver {
context.getDriverStatus().setDriverStartTime(opStatus.getOperationStarted());
context.getDriverStatus().setDriverFinishTime(opStatus.getOperationCompleted());
} catch (Exception e) {
- LOG.error("Error getting query status", e);
+ log.error("Error getting query status", e);
handleHiveServerError(context, e);
throw new LensException("Error getting query status", e);
} finally {
@@ -627,7 +626,7 @@ public class HiveDriver implements LensDriver {
try {
in.close();
} catch (IOException e) {
- e.printStackTrace();
+ log.error("Error closing stream.", e);
}
}
}
@@ -654,7 +653,7 @@ public class HiveDriver implements LensDriver {
*/
@Override
public LensResultSet fetchResultSet(QueryContext ctx) throws LensException {
- LOG.info("FetchResultSet: " + ctx.getQueryHandle());
+ log.info("FetchResultSet: " + ctx.getQueryHandle());
// This should be applicable only for a async query
return createResultSet(ctx, false);
}
@@ -679,10 +678,10 @@ public class HiveDriver implements LensDriver {
if (handle == null) {
return;
}
- LOG.info("CloseQuery: " + handle);
+ log.info("CloseQuery: " + handle);
OperationHandle opHandle = hiveHandles.remove(handle);
if (opHandle != null) {
- LOG.info("CloseQuery: " + opHandle);
+ log.info("CloseQuery: " + opHandle);
try {
getClient().closeOperation(opHandle);
} catch (HiveSQLException e) {
@@ -699,10 +698,10 @@ public class HiveDriver implements LensDriver {
*/
@Override
public boolean cancelQuery(QueryHandle handle) throws LensException {
- LOG.info("CancelQuery: " + handle);
+ log.info("CancelQuery: " + handle);
OperationHandle hiveHandle = getHiveHandle(handle);
try {
- LOG.info("CancelQuery hiveHandle: " + hiveHandle);
+ log.info("CancelQuery hiveHandle: " + hiveHandle);
getClient().cancelOperation(hiveHandle);
return true;
} catch (HiveSQLException e) {
@@ -718,7 +717,7 @@ public class HiveDriver implements LensDriver {
*/
@Override
public void close() {
- LOG.info("CloseDriver");
+ log.info("CloseDriver");
// Close this driver and release all resources
sessionLock.lock();
try {
@@ -727,7 +726,7 @@ public class HiveDriver implements LensDriver {
getClient().closeSession(lensToHiveSession.get(lensSessionDbKey));
} catch (Exception e) {
checkInvalidSession(e);
- LOG.warn("Error closing session for lens session: " + lensSessionDbKey + ", hive session: "
+ log.warn("Error closing session for lens session: " + lensSessionDbKey + ", hive session: "
+ lensToHiveSession.get(lensSessionDbKey), e);
}
}
@@ -756,7 +755,7 @@ public class HiveDriver implements LensDriver {
} catch (Exception e) {
throw new LensException(e);
}
- LOG.info("New thrift connection " + connectionClass);
+ log.info("New thrift connection " + connectionClass);
}
return embeddedConnection.getClient();
} else {
@@ -774,7 +773,7 @@ public class HiveDriver implements LensDriver {
connection = new ExpirableConnection(tconn, connectionExpiryTimeout);
thriftConnExpiryQueue.offer(connection);
threadConnections.put(connectionKey, connection);
- LOG.info("New thrift connection " + connectionClass + " for thread:" + Thread.currentThread().getId()
+ log.info("New thrift connection " + connectionClass + " for thread:" + Thread.currentThread().getId()
+ " for user:" + user + " connection ID=" + connection.getConnId());
} catch (Exception e) {
throw new LensException(e);
@@ -799,7 +798,7 @@ public class HiveDriver implements LensDriver {
*/
private LensResultSet createResultSet(QueryContext context, boolean closeAfterFetch) throws LensException {
OperationHandle op = getHiveHandle(context.getQueryHandle());
- LOG.info("Creating result set for hiveHandle:" + op);
+ log.info("Creating result set for hiveHandle:" + op);
try {
if (context.isDriverPersistent()) {
return new HivePersistentResultSet(new Path(context.getHdfsoutPath()), op, getClient());
@@ -846,7 +845,7 @@ public class HiveDriver implements LensDriver {
context.unSetDriverPersistent();
hiveQuery = context.getSelectedDriverQuery();
}
- LOG.info("Hive driver query:" + hiveQuery);
+ log.info("Hive driver query:" + hiveQuery);
context.setSelectedDriverQuery(hiveQuery);
}
@@ -875,14 +874,14 @@ public class HiveDriver implements LensDriver {
try {
hiveSession = getClient().openSession(ctx.getClusterUser(), "");
lensToHiveSession.put(sessionDbKey, hiveSession);
- LOG.info("New hive session for user: " + ctx.getClusterUser() + ", lens session: " + sessionDbKey
+ log.info("New hive session for user: " + ctx.getClusterUser() + ", lens session: " + sessionDbKey
+ " hive session handle: " + hiveSession.getHandleIdentifier());
for (LensEventListener<DriverEvent> eventListener : driverListeners) {
try {
eventListener.onEvent(new DriverSessionStarted(System.currentTimeMillis(), this, lensSession, hiveSession
.getSessionId().toString()));
} catch (Exception exc) {
- LOG.error("Error sending driver start event to listener " + eventListener, exc);
+ log.error("Error sending driver start event to listener " + eventListener, exc);
}
}
} catch (Exception e) {
@@ -969,7 +968,7 @@ public class HiveDriver implements LensDriver {
}
error = "timedout";
} catch (Exception e) {
- LOG.warn("Error while polling for status", e);
+ log.warn("Error while polling for status", e);
error = "error polling";
}
listener.onError(handle, error);
@@ -1025,9 +1024,9 @@ public class HiveDriver implements LensDriver {
QueryHandle qhandle = (QueryHandle) in.readObject();
OperationHandle opHandle = new OperationHandle((TOperationHandle) in.readObject());
hiveHandles.put(qhandle, opHandle);
- LOG.debug("Hive driver recovered " + qhandle + ":" + opHandle);
+ log.debug("Hive driver recovered " + qhandle + ":" + opHandle);
}
- LOG.info("HiveDriver recovered " + hiveHandles.size() + " queries");
+ log.info("HiveDriver recovered " + hiveHandles.size() + " queries");
int numSessions = in.readInt();
for (int i = 0; i < numSessions; i++) {
String lensId = in.readUTF();
@@ -1035,7 +1034,7 @@ public class HiveDriver implements LensDriver {
TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V6);
lensToHiveSession.put(lensId, sHandle);
}
- LOG.info("HiveDriver recovered " + lensToHiveSession.size() + " sessions");
+ log.info("HiveDriver recovered " + lensToHiveSession.size() + " sessions");
}
}
@@ -1052,15 +1051,15 @@ public class HiveDriver implements LensDriver {
for (Map.Entry<QueryHandle, OperationHandle> entry : hiveHandles.entrySet()) {
out.writeObject(entry.getKey());
out.writeObject(entry.getValue().toTOperationHandle());
- LOG.debug("Hive driver persisted " + entry.getKey() + ":" + entry.getValue());
+ log.debug("Hive driver persisted " + entry.getKey() + ":" + entry.getValue());
}
- LOG.info("HiveDriver persisted " + hiveHandles.size() + " queries");
+ log.info("HiveDriver persisted " + hiveHandles.size() + " queries");
out.writeInt(lensToHiveSession.size());
for (Map.Entry<String, SessionHandle> entry : lensToHiveSession.entrySet()) {
out.writeUTF(entry.getKey());
out.writeObject(entry.getValue().toTSessionHandle());
}
- LOG.info("HiveDriver persisted " + lensToHiveSession.size() + " sessions");
+ log.info("HiveDriver persisted " + lensToHiveSession.size() + " sessions");
}
}
@@ -1122,14 +1121,14 @@ public class HiveDriver implements LensDriver {
for (SessionHandle session : hiveSessionsToCheck) {
if (isSessionInvalid(exc, session)) {
// We have to expire previous session
- LOG.info("Hive server session " + session + " for lens session " + lensSession + " has become invalid");
+ log.info("Hive server session " + session + " for lens session " + lensSession + " has become invalid");
sessionLock.lock();
try {
// We should close all connections and clear the session map since
// most likely all sessions are gone
closeAllConnections();
lensToHiveSession.clear();
- LOG.info("Cleared all sessions");
+ log.info("Cleared all sessions");
} finally {
sessionLock.unlock();
}
@@ -1146,12 +1145,12 @@ public class HiveDriver implements LensDriver {
protected void checkInvalidOperation(QueryHandle queryHandle, HiveSQLException exc) {
final OperationHandle operation = hiveHandles.get(queryHandle);
if (operation == null) {
- LOG.info("No hive operation available for " + queryHandle);
+ log.info("No hive operation available for " + queryHandle);
return;
}
if (exc.getMessage() != null && exc.getMessage().contains("Invalid OperationHandle:")
&& exc.getMessage().contains(operation.toString())) {
- LOG.info("Hive operation " + operation + " for query " + queryHandle + " has become invalid");
+ log.info("Hive operation " + operation + " for query " + queryHandle + " has become invalid");
hiveHandles.remove(queryHandle);
return;
}
@@ -1193,10 +1192,10 @@ public class HiveDriver implements LensDriver {
if (hiveSession != null) {
try {
getClient().closeSession(hiveSession);
- LOG.info("Closed Hive session " + hiveSession.getHandleIdentifier() + " for lens session "
+ log.info("Closed Hive session " + hiveSession.getHandleIdentifier() + " for lens session "
+ sessionDbKey);
} catch (Exception e) {
- LOG.error("Error closing hive session " + hiveSession.getHandleIdentifier()
+ log.error("Error closing hive session " + hiveSession.getHandleIdentifier()
+ " for lens session " + sessionDbKey, e);
}
resourcesAddedForSession.remove(hiveSession);
@@ -1217,7 +1216,7 @@ public class HiveDriver implements LensDriver {
try {
connection.getConnection().close();
} catch (Exception ce) {
- LOG.warn("Error closing connection to hive server");
+ log.warn("Error closing connection to hive server");
}
}
threadConnections.clear();
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java
----------------------------------------------------------------------
diff --git a/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java b/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java
index 4d631ec..3d1f20a 100644
--- a/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java
+++ b/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java
@@ -30,9 +30,12 @@ import org.apache.lens.server.api.error.LensException;
import org.apache.hive.service.cli.*;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class HiveInMemoryResultSet.
*/
+@Slf4j
public class HiveInMemoryResultSet extends InMemoryResultSet {
/** The client. */
@@ -120,7 +123,7 @@ public class HiveInMemoryResultSet extends InMemoryResultSet {
noMoreResults = rowSet.numRows() == 0;
if (noMoreResults) {
if (closeAfterFecth) {
- HiveDriver.LOG.info("No more results closing the query");
+ log.info("No more results closing the query");
client.closeOperation(opHandle);
}
return false;
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java
----------------------------------------------------------------------
diff --git a/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java b/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java
index 9d43fa8..b0a04df 100644
--- a/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java
+++ b/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java
@@ -34,9 +34,12 @@ import org.apache.hadoop.hive.ql.metadata.Hive;
import org.apache.hadoop.hive.ql.metadata.HiveException;
import org.apache.hadoop.hive.ql.metadata.Table;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class HiveQueryPlan.
*/
+@Slf4j
public class HiveQueryPlan extends DriverQueryPlan {
/** The explain output. */
@@ -164,7 +167,7 @@ public class HiveQueryPlan extends DriverQueryPlan {
Table tbl = metastore.getTable(table, false);
if (tbl == null) {
// table not found, possible case if query is create table
- HiveDriver.LOG.info("Table " + table + " not found while extracting plan details");
+ log.info("Table " + table + " not found while extracting plan details");
continue;
}
tablesQueried.add(table);
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
----------------------------------------------------------------------
diff --git a/lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java b/lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
index f0566c8..b4086b8 100644
--- a/lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
+++ b/lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
@@ -35,8 +35,6 @@ import org.apache.lens.server.api.error.LensException;
import org.apache.lens.server.api.query.QueryContext;
import org.apache.commons.io.FileUtils;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.hive.conf.HiveConf;
import org.apache.hadoop.hive.ql.session.SessionState;
import org.apache.hive.service.Service;
@@ -47,14 +45,14 @@ import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class TestRemoteHiveDriver.
*/
+@Slf4j
public class TestRemoteHiveDriver extends TestHiveDriver {
- /** The Constant LOG. */
- public static final Log LOG = LogFactory.getLog(TestRemoteHiveDriver.class);
-
/** The Constant HS2_HOST. */
static final String HS2_HOST = "localhost";
@@ -121,7 +119,7 @@ public class TestRemoteHiveDriver extends TestHiveDriver {
try {
server.stop();
} catch (Exception e) {
- e.printStackTrace();
+ log.error("Error stopping hive service", e);
}
}
@@ -151,7 +149,7 @@ public class TestRemoteHiveDriver extends TestHiveDriver {
*/
@Test
public void testMultiThreadClient() throws Exception {
- LOG.info("@@ Starting multi thread test");
+ log.info("@@ Starting multi thread test");
// Launch two threads
createTestTable("test_multithreads");
HiveConf thConf = new HiveConf(conf, TestRemoteHiveDriver.class);
@@ -175,10 +173,10 @@ public class TestRemoteHiveDriver extends TestHiveDriver {
thrDriver.executeAsync(qctx);
} catch (LensException e) {
errCount.incrementAndGet();
- LOG.info(q + " executeAsync error: " + e.getCause());
+ log.info(q + " executeAsync error: " + e.getCause());
continue;
}
- LOG.info("@@ Launched query: " + q + " " + qctx.getQueryHandle());
+ log.info("@@ Launched query: " + q + " " + qctx.getQueryHandle());
launchedQueries++;
// Launch many threads to poll for status
final QueryHandle handle = qctx.getQueryHandle();
@@ -192,18 +190,17 @@ public class TestRemoteHiveDriver extends TestHiveDriver {
try {
thrDriver.updateStatus(qctx);
if (qctx.getDriverStatus().isFinished()) {
- LOG.info("@@ " + handle.getHandleId() + " >> " + qctx.getDriverStatus().getState());
+ log.info("@@ " + handle.getHandleId() + " >> " + qctx.getDriverStatus().getState());
thrDriver.closeQuery(handle);
break;
}
Thread.sleep(POLL_DELAY);
} catch (LensException e) {
- LOG.error("Got Exception", e.getCause());
- e.printStackTrace();
+ log.error("Got Exception " +e.getCause(), e);
errCount.incrementAndGet();
break;
} catch (InterruptedException e) {
- e.printStackTrace();
+ log.error("Encountred Interrupted exception", e);
break;
}
}
@@ -219,11 +216,11 @@ public class TestRemoteHiveDriver extends TestHiveDriver {
try {
th.join(10000);
} catch (InterruptedException e) {
- LOG.warn("Not ended yet: " + th.getName());
+ log.warn("Not ended yet: " + th.getName());
}
}
Assert.assertEquals(0, thrDriver.getHiveHandleSize());
- LOG.info("@@ Completed all pollers. Total thrift errors: " + errCount.get());
+ log.info("@@ Completed all pollers. Total thrift errors: " + errCount.get());
assertEquals(launchedQueries, QUERIES);
assertEquals(thrs.size(), QUERIES * THREADS);
assertEquals(errCount.get(), 0);
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
----------------------------------------------------------------------
diff --git a/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java b/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
index dc30bb9..556ca2c 100644
--- a/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
+++ b/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
@@ -46,9 +46,12 @@ import org.testng.annotations.AfterTest;
import org.testng.annotations.BeforeTest;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class TestColumnarSQLRewriter.
*/
+@Slf4j
public class TestColumnarSQLRewriter {
HiveConf hconf = new HiveConf();
@@ -186,7 +189,7 @@ public class TestColumnarSQLRewriter {
createHiveTable("default", "branch_dim", branchdimColumns);
createHiveTable("default", "location_dim", locationdimColumns);
} catch (HiveException e) {
- e.printStackTrace();
+ log.error("Encountered hive exception.", e);
}
}
@@ -204,7 +207,7 @@ public class TestColumnarSQLRewriter {
Hive.get().dropTable("default.branch_dim");
Hive.get().dropTable("default.location_dim");
} catch (HiveException e) {
- e.printStackTrace();
+ log.error("Encountered hive exception", e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java
----------------------------------------------------------------------
diff --git a/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java b/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java
index e526700..21e5f50 100644
--- a/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java
+++ b/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java
@@ -28,19 +28,18 @@ import java.util.concurrent.Semaphore;
import java.util.concurrent.atomic.AtomicInteger;
import org.apache.hadoop.conf.Configuration;
-import org.apache.log4j.Logger;
import org.testng.Assert;
import org.testng.annotations.Test;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class TestDataSourceConnectionProvider.
*/
+@Slf4j
public class TestDataSourceConnectionProvider {
- /** The Constant LOG. */
- public static final Logger LOG = Logger.getLogger(TestDataSourceConnectionProvider.class);
-
/**
* Test get connection hsql.
*
@@ -75,20 +74,20 @@ public class TestDataSourceConnectionProvider {
Assert.assertNotNull(st);
passed.incrementAndGet();
} catch (SQLException e) {
- LOG.error("error getting connection to db!", e);
+ log.error("error getting connection to db!", e);
} finally {
if (st != null) {
try {
st.close();
} catch (SQLException e) {
- e.printStackTrace();
+ log.error("Encountered SQL ecxception", e);
}
}
if (conn != null) {
try {
conn.close();
} catch (SQLException e) {
- e.printStackTrace();
+ log.error("Encountered SQL exception", e);
}
}
}
@@ -134,7 +133,7 @@ public class TestDataSourceConnectionProvider {
}
} catch (SQLException sqlEx) {
if (i != MAX_CONNECTIONS) {
- LOG.error("Unexpected getConnection error", sqlEx);
+ log.error("Unexpected getConnection error", sqlEx);
}
assertEquals(i, MAX_CONNECTIONS, "Failed before last getConnection call: " + sqlEx.getMessage());
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
----------------------------------------------------------------------
diff --git a/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java b/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
index 75c428a..4f03f23 100644
--- a/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
+++ b/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
@@ -46,8 +46,6 @@ import org.apache.lens.server.api.query.PreparedQueryContext;
import org.apache.lens.server.api.query.QueryContext;
import org.apache.lens.server.api.util.LensUtil;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hive.conf.HiveConf;
import org.apache.hadoop.hive.ql.session.SessionState;
@@ -62,11 +60,13 @@ import org.testng.annotations.Test;
import com.codahale.metrics.MetricRegistry;
import com.mchange.v2.c3p0.ComboPooledDataSource;
+import lombok.extern.slf4j.Slf4j;
+
/**
* The Class TestJdbcDriver.
*/
+@Slf4j
public class TestJdbcDriver {
- public static final Log LOG = LogFactory.getLog(TestJdbcDriver.class);
/** The base conf. */
Configuration baseConf;
@@ -211,7 +211,7 @@ public class TestJdbcDriver {
try {
driver.rewriteQuery(createQueryContext(query));
} catch (LensException e) {
- e.printStackTrace();
+ log.error("Error running DDL query.", e);
th = e;
}
Assert.assertNotNull(th);
@@ -222,7 +222,7 @@ public class TestJdbcDriver {
try {
driver.rewriteQuery(createQueryContext(query));
} catch (LensException e) {
- e.printStackTrace();
+ log.error("Error running DDL query", e);
th = e;
}
Assert.assertNotNull(th);
@@ -233,7 +233,7 @@ public class TestJdbcDriver {
try {
driver.rewriteQuery(createQueryContext(query));
} catch (LensException e) {
- e.printStackTrace();
+ log.error("Error running DDL query", e);
th = e;
}
Assert.assertNotNull(th);
@@ -244,7 +244,7 @@ public class TestJdbcDriver {
try {
driver.rewriteQuery(createQueryContext(query));
} catch (LensException e) {
- e.printStackTrace();
+ log.error("Error running DDL query", e);
th = e;
}
Assert.assertNotNull(th);
@@ -272,7 +272,7 @@ public class TestJdbcDriver {
driver.getEstimateConnectionConf().getInt(JDBCDriverConfConstants.JDBC_POOL_MAX_SIZE, 50);
for (int i = 0; i < maxEstimateConnections + 10; i++) {
try {
- LOG.info("Iteration#" + (i + 1));
+ log.info("Iteration#" + (i + 1));
String query = i > maxEstimateConnections ? "SELECT * FROM estimate_test" : "CREATE TABLE FOO(ID INT)";
ExplainQueryContext context = createExplainContext(query, baseConf);
cost = driver.estimate(context);
@@ -578,8 +578,8 @@ public class TestJdbcDriver {
try {
listenerNotificationLatch.await(1, TimeUnit.SECONDS);
} catch (Exception e) {
- fail("query completion listener was not notified - " + e.getMessage());
- e.printStackTrace();
+ fail("Query completion listener was not notified - " + e.getMessage());
+ log.error("Query completion listener was not notified.", e);
}
LensResultSet grs = driver.fetchResultSet(context);
@@ -738,7 +738,7 @@ public class TestJdbcDriver {
LensResultSet rs = driver.execute(ctx);
fail("Should have thrown exception");
} catch (LensException e) {
- e.printStackTrace();
+ log.error("Encountered Lens exception.", e);
}
final CountDownLatch listenerNotificationLatch = new CountDownLatch(1);
@@ -778,7 +778,7 @@ public class TestJdbcDriver {
driver.fetchResultSet(ctx);
fail("should have thrown error");
} catch (LensException e) {
- e.printStackTrace();
+ log.error("Encountered Lens exception", e);
}
driver.closeQuery(handle);
}
@@ -816,8 +816,8 @@ public class TestJdbcDriver {
DataSourceConnectionProvider.DriverConfig queryCfg =
queryCp.getDriverConfigfromConf(driver.getConf());
- LOG.info("@@@ ESTIMATE_CFG " + estimateCfg);
- LOG.info("@@@ QUERY CFG " + queryCfg);
+ log.info("@@@ ESTIMATE_CFG " + estimateCfg);
+ log.info("@@@ QUERY CFG " + queryCfg);
// Get connection from each so that pools get initialized
try {
@@ -825,14 +825,14 @@ public class TestJdbcDriver {
estimateConn.close();
} catch (SQLException e) {
// Ignore exception
- LOG.error("Error getting connection from estimate pool", e);
+ log.error("Error getting connection from estimate pool", e);
}
try {
Connection queryConn = queryCp.getConnection(driver.getConf());
queryConn.close();
} catch (SQLException e) {
- LOG.error("Error getting connection from query pool", e);
+ log.error("Error getting connection from query pool", e);
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java
----------------------------------------------------------------------
diff --git a/lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java b/lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java
index 2f28e5d..dee43ef 100644
--- a/lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java
+++ b/lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java
@@ -31,7 +31,11 @@ import org.apache.lens.api.metastore.ObjectFactory;
import org.apache.lens.client.LensClientSingletonWrapper;
import org.apache.lens.client.LensMetadataClient;
+import lombok.extern.slf4j.Slf4j;
+
+@Slf4j
public class SampleMetastore {
+
private LensMetadataClient metaClient;
public static final Unmarshaller JAXB_UNMARSHALLER;
private APIResult result;
@@ -117,7 +121,7 @@ public class SampleMetastore {
System.out.println("Created DB storages");
} catch (Exception e) {
retCode = 1;
- e.printStackTrace();
+ log.error("Creating DB storage failed", e);
System.err.println("Creating DB storage failed");
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java
----------------------------------------------------------------------
diff --git a/lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java b/lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java
index 8ffe853..6dd0ecf 100644
--- a/lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java
+++ b/lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java
@@ -40,16 +40,17 @@ import org.apache.lens.ml.api.TestReport;
import org.apache.lens.server.api.error.LensException;
import org.apache.commons.lang.StringUtils;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
+
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
+import lombok.extern.slf4j.Slf4j;
+
/**
* Client side implementation of LensML
*/
+@Slf4j
public class LensMLClient implements LensML, Closeable {
- private static final Log LOG = LogFactory.getLog(LensMLClient.class);
/** The client. */
private LensMLJerseyClient client;
@@ -179,7 +180,7 @@ public class LensMLClient implements LensML, Closeable {
try {
in.close();
} catch (IOException e) {
- e.printStackTrace();
+ log.error("Error closing stream.", e);
}
}
}
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-ml-lib/src/main/java/org/apache/lens/ml/algo/lib/AlgoArgParser.java
----------------------------------------------------------------------
diff --git a/lens-ml-lib/src/main/java/org/apache/lens/ml/algo/lib/AlgoArgParser.java b/lens-ml-lib/src/main/java/org/apache/lens/ml/algo/lib/AlgoArgParser.java
index 51979d8..00f20fc 100644
--- a/lens-ml-lib/src/main/java/org/apache/lens/ml/algo/lib/AlgoArgParser.java
+++ b/lens-ml-lib/src/main/java/org/apache/lens/ml/algo/lib/AlgoArgParser.java
@@ -27,12 +27,12 @@ import java.util.Map;
import org.apache.lens.ml.algo.api.AlgoParam;
import org.apache.lens.ml.algo.api.MLAlgo;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
+import lombok.extern.slf4j.Slf4j;
/**
* The Class AlgoArgParser.
*/
+@Slf4j
public final class AlgoArgParser {
private AlgoArgParser() {
}
@@ -53,9 +53,6 @@ public final class AlgoArgParser {
public abstract E parse(String value);
}
- /** The Constant LOG. */
- public static final Log LOG = LogFactory.getLog(AlgoArgParser.class);
-
/**
* Extracts feature names. If the algo has any parameters associated with @AlgoParam annotation, those are set
* as well.
@@ -104,12 +101,12 @@ public final class AlgoArgParser {
CustomArgParser<?> parser = clz.newInstance();
f.set(algo, parser.parse(value));
} else {
- LOG.warn("Ignored param " + key + "=" + value + " as no parser found");
+ log.warn("Ignored param " + key + "=" + value + " as no parser found");
}
}
}
} catch (Exception exc) {
- LOG.error("Error while setting param " + key + " to " + value + " for algo " + algo);
+ log.error("Error while setting param " + key + " to " + value + " for algo " + algo, exc);
}
}
return featureColumns;
http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/b0783db7/lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java
----------------------------------------------------------------------
diff --git a/lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java b/lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java
index e4c03c8..de76603 100644
--- a/lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java
+++ b/lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java
@@ -52,8 +52,6 @@ import org.apache.lens.server.api.error.LensException;
import org.apache.lens.server.api.session.SessionService;
import org.apache.commons.io.IOUtils;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.fs.FileStatus;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
@@ -66,15 +64,14 @@ import org.glassfish.jersey.media.multipart.FormDataContentDisposition;
import org.glassfish.jersey.media.multipart.FormDataMultiPart;
import org.glassfish.jersey.media.multipart.MultiPartFeature;
+import lombok.extern.slf4j.Slf4j;
/**
* The Class LensMLImpl.
*/
+@Slf4j
public class LensMLImpl implements LensML {
- /** The Constant LOG. */
- public static final Log LOG = LogFactory.getLog(LensMLImpl.class);
-
/** The drivers. */
protected List<MLDriver> drivers;
@@ -144,7 +141,7 @@ public class LensMLImpl implements LensML {
String modelId = UUID.randomUUID().toString();
- LOG.info("Begin training model " + modelId + ", algo=" + algorithm + ", table=" + table + ", params="
+ log.info("Begin training model " + modelId + ", algo=" + algorithm + ", table=" + table + ", params="
+ Arrays.toString(args));
String database = null;
@@ -156,7 +153,7 @@ public class LensMLImpl implements LensML {
MLModel model = algo.train(toLensConf(conf), database, table, modelId, args);
- LOG.info("Done training model: " + modelId);
+ log.info("Done training model: " + modelId);
model.setCreatedAt(new Date());
model.setAlgoName(algorithm);
@@ -164,7 +161,7 @@ public class LensMLImpl implements LensML {
Path modelLocation = null;
try {
modelLocation = persistModel(model);
- LOG.info("Model saved: " + modelId + ", algo: " + algorithm + ", path: " + modelLocation);
+ log.info("Model saved: " + modelId + ", algo: " + algorithm + ", path: " + modelLocation);
return model.getId();
} catch (IOException e) {
throw new LensException("Error saving model " + modelId + " for algo " + algorithm, e);
@@ -207,7 +204,7 @@ public class LensMLImpl implements LensML {
outputStream.writeObject(model);
outputStream.flush();
} catch (IOException io) {
- LOG.error("Error saving model " + model.getId() + " reason: " + io.getMessage());
+ log.error("Error saving model " + model.getId() + " reason: " + io.getMessage(), io);
throw io;
} finally {
IOUtils.closeQuietly(outputStream);
@@ -272,7 +269,7 @@ public class LensMLImpl implements LensML {
throw new RuntimeException("No ML Drivers specified in conf");
}
- LOG.info("Loading drivers " + Arrays.toString(driverClasses));
+ log.info("Loading drivers " + Arrays.toString(driverClasses));
drivers = new ArrayList<MLDriver>(driverClasses.length);
for (String driverClass : driverClasses) {
@@ -280,12 +277,12 @@ public class LensMLImpl implements LensML {
try {
cls = Class.forName(driverClass);
} catch (ClassNotFoundException e) {
- LOG.error("Driver class not found " + driverClass);
+ log.error("Driver class not found " + driverClass, e);
continue;
}
if (!MLDriver.class.isAssignableFrom(cls)) {
- LOG.warn("Not a driver class " + driverClass);
+ log.warn("Not a driver class " + driverClass);
continue;
}
@@ -294,16 +291,16 @@ public class LensMLImpl implements LensML {
MLDriver driver = mlDriverClass.newInstance();
driver.init(toLensConf(conf));
drivers.add(driver);
- LOG.info("Added driver " + driverClass);
+ log.info("Added driver " + driverClass);
} catch (Exception e) {
- LOG.error("Failed to create driver " + driverClass + " reason: " + e.getMessage(), e);
+ log.error("Failed to create driver " + driverClass + " reason: " + e.getMessage(), e);
}
}
if (drivers.isEmpty()) {
throw new RuntimeException("No ML drivers loaded");
}
- LOG.info("Inited ML service");
+ log.info("Inited ML service");
}
/**
@@ -317,14 +314,14 @@ public class LensMLImpl implements LensML {
}
driver.start();
} catch (LensException e) {
- LOG.error("Failed to start driver " + driver, e);
+ log.error("Failed to start driver " + driver, e);
}
}
udfStatusExpirySvc = Executors.newSingleThreadScheduledExecutor();
udfStatusExpirySvc.scheduleAtFixedRate(new UDFStatusExpiryRunnable(), 60, 60, TimeUnit.SECONDS);
- LOG.info("Started ML service");
+ log.info("Started ML service");
}
/**
@@ -335,12 +332,12 @@ public class LensMLImpl implements LensML {
try {
driver.stop();
} catch (LensException e) {
- LOG.error("Failed to stop driver " + driver, e);
+ log.error("Failed to stop driver " + driver, e);
}
}
drivers.clear();
udfStatusExpirySvc.shutdownNow();
- LOG.info("Stopped ML service");
+ log.info("Stopped ML service");
}
public synchronized HiveConf getHiveConf() {
@@ -455,18 +452,18 @@ public class LensMLImpl implements LensML {
}
if (!spec.isOutputTableExists()) {
- LOG.info("Output table '" + testTable + "' does not exist for test algorithm = " + algorithm + " modelid="
+ log.info("Output table '" + testTable + "' does not exist for test algorithm = " + algorithm + " modelid="
+ modelID + ", Creating table using query: " + spec.getCreateOutputTableQuery());
// create the output table
String createOutputTableQuery = spec.getCreateOutputTableQuery();
queryRunner.runQuery(createOutputTableQuery);
- LOG.info("Table created " + testTable);
+ log.info("Table created " + testTable);
}
// Check if ML UDF is registered in this session
registerPredictUdf(sessionHandle, queryRunner);
- LOG.info("Running evaluation query " + testQuery);
+ log.info("Running evaluation query " + testQuery);
queryRunner.setQueryName("model_test_" + modelID);
QueryHandle testQueryHandle = queryRunner.runQuery(testQuery);
@@ -483,7 +480,7 @@ public class LensMLImpl implements LensML {
// Save test report
persistTestReport(testReport);
- LOG.info("Saved test report " + testReport.getReportID());
+ log.info("Saved test report " + testReport.getReportID());
return testReport;
}
@@ -494,12 +491,12 @@ public class LensMLImpl implements LensML {
* @throws LensException the lens exception
*/
private void persistTestReport(MLTestReport testReport) throws LensException {
- LOG.info("saving test report " + testReport.getReportID());
+ log.info("saving test report " + testReport.getReportID());
try {
ModelLoader.saveTestReport(conf, testReport);
- LOG.info("Saved report " + testReport.getReportID());
+ log.info("Saved report " + testReport.getReportID());
} catch (IOException e) {
- LOG.error("Error saving report " + testReport.getReportID() + " reason: " + e.getMessage());
+ log.error("Error saving report " + testReport.getReportID() + " reason: " + e.getMessage(), e);
}
}
@@ -529,7 +526,7 @@ public class LensMLImpl implements LensML {
}
return reports;
} catch (IOException e) {
- LOG.error("Error reading report list for " + algorithm, e);
+ log.error("Error reading report list for " + algorithm, e);
return null;
}
}
@@ -566,9 +563,9 @@ public class LensMLImpl implements LensML {
public void deleteModel(String algorithm, String modelID) throws LensException {
try {
ModelLoader.deleteModel(conf, algorithm, modelID);
- LOG.info("DELETED model " + modelID + " algorithm=" + algorithm);
+ log.info("DELETED model " + modelID + " algorithm=" + algorithm);
} catch (IOException e) {
- LOG.error(
+ log.error(
"Error deleting model file. algorithm=" + algorithm + " model=" + modelID + " reason: " + e.getMessage(), e);
throw new LensException("Unable to delete model " + modelID + " for algorithm " + algorithm, e);
}
@@ -582,9 +579,9 @@ public class LensMLImpl implements LensML {
public void deleteTestReport(String algorithm, String reportID) throws LensException {
try {
ModelLoader.deleteTestReport(conf, algorithm, reportID);
- LOG.info("DELETED report=" + reportID + " algorithm=" + algorithm);
+ log.info("DELETED report=" + reportID + " algorithm=" + algorithm);
} catch (IOException e) {
- LOG.error("Error deleting report " + reportID + " algorithm=" + algorithm + " reason: " + e.getMessage(), e);
+ log.error("Error deleting report " + reportID + " algorithm=" + algorithm + " reason: " + e.getMessage(), e);
throw new LensException("Unable to delete report " + reportID + " for algorithm " + algorithm, e);
}
}
@@ -599,7 +596,7 @@ public class LensMLImpl implements LensML {
try {
algo = getAlgoForName(algorithm);
} catch (LensException e) {
- LOG.error("Error getting algo description : " + algorithm, e);
+ log.error("Error getting algo description : " + algorithm, e);
return null;
}
if (algo instanceof BaseSparkAlgo) {
@@ -693,15 +690,15 @@ public class LensMLImpl implements LensML {
return;
}
- LOG.info("Registering UDF for session " + sessionHandle.getPublicId().toString());
+ log.info("Registering UDF for session " + sessionHandle.getPublicId().toString());
String regUdfQuery = "CREATE TEMPORARY FUNCTION " + HiveMLUDF.UDF_NAME + " AS '" + HiveMLUDF.class
.getCanonicalName() + "'";
queryRunner.setQueryName("register_predict_udf_" + sessionHandle.getPublicId().toString());
QueryHandle udfQuery = queryRunner.runQuery(regUdfQuery);
- LOG.info("udf query handle is " + udfQuery);
+ log.info("udf query handle is " + udfQuery);
predictUdfStatus.put(sessionHandle, true);
- LOG.info("Predict UDF registered for session " + sessionHandle.getPublicId().toString());
+ log.info("Predict UDF registered for session " + sessionHandle.getPublicId().toString());
}
protected boolean isUdfRegisterd(LensSessionHandle sessionHandle) {
@@ -719,12 +716,12 @@ public class LensMLImpl implements LensML {
List<LensSessionHandle> sessions = new ArrayList<LensSessionHandle>(predictUdfStatus.keySet());
for (LensSessionHandle sessionHandle : sessions) {
if (!sessionService.isOpen(sessionHandle)) {
- LOG.info("Session closed, removing UDF status: " + sessionHandle);
+ log.info("Session closed, removing UDF status: " + sessionHandle);
predictUdfStatus.remove(sessionHandle);
}
}
} catch (Exception exc) {
- LOG.warn("Error clearing UDF statuses", exc);
+ log.warn("Error clearing UDF statuses", exc);
}
}
}