You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/09 15:47:16 UTC
[GitHub] [tvm] cconvey opened a new pull request, #11248: [tir] remove unused member variable
cconvey opened a new pull request, #11248:
URL: https://github.com/apache/tvm/pull/11248
Remove unused member variable
`tvm::tir::PackedCallLegalizer::tvm_value_index_`.
This also fixes a GCC 7.5 compiler warning.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cconvey commented on a diff in pull request #11248: [tir] remove unused member variable
Posted by GitBox <gi...@apache.org>.
cconvey commented on code in PR #11248:
URL: https://github.com/apache/tvm/pull/11248#discussion_r868163890
##########
src/tir/transforms/legalize_packed_calls.cc:
##########
@@ -111,8 +111,7 @@ class PackedCallLegalizer : public StmtExprMutator {
private:
IRModule mod_;
- InputMap inputs_; // Store the inputs to the primfunc that don't need to be packed.
- int tvm_value_index_; // Index of the actual tvm_value variable
+ InputMap inputs_; // Store the inputs to the primfunc that don't need to be packed.
Review Comment:
I think this line only changed because clang-format removed some white-space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cconvey commented on pull request #11248: [tir] remove unused member variable
Posted by GitBox <gi...@apache.org>.
cconvey commented on PR #11248:
URL: https://github.com/apache/tvm/pull/11248#issuecomment-1121441493
@Hzfengsy @spectrometerHBH : Ready for commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] spectrometerHBH merged pull request #11248: [tir] remove unused member variable
Posted by GitBox <gi...@apache.org>.
spectrometerHBH merged PR #11248:
URL: https://github.com/apache/tvm/pull/11248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org