You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/11/18 02:22:13 UTC
[GitHub] [phoenix] kadirozde opened a new pull request #973: PHOENIX-6211 Paged scan filters
kadirozde opened a new pull request #973:
URL: https://github.com/apache/phoenix/pull/973
I will write a design doc for this. Please feel free to give me feedback or ask questions meanwhile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-749252804
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 14s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 15m 28s | master passed |
| +1 :green_heart: | compile | 0m 58s | master passed |
| +1 :green_heart: | checkstyle | 1m 52s | master passed |
| +1 :green_heart: | javadoc | 0m 46s | master passed |
| +0 :ok: | spotbugs | 3m 14s | phoenix-core in master has 972 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 3s | the patch passed |
| +1 :green_heart: | compile | 0m 56s | the patch passed |
| +1 :green_heart: | javac | 0m 56s | the patch passed |
| -1 :x: | checkstyle | 1m 54s | phoenix-core: The patch generated 301 new + 4839 unchanged - 129 fixed = 5140 total (was 4968) |
| -1 :x: | whitespace | 0m 0s | The patch 10 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed |
| -1 :x: | spotbugs | 3m 25s | phoenix-core generated 1 new + 969 unchanged - 3 fixed = 970 total (was 972) |
||| _ Other Tests _ |
| -1 :x: | unit | 211m 37s | phoenix-core in the patch failed. |
| -1 :x: | asflicense | 0m 23s | The patch generated 1 ASF License warnings. |
| | | 254m 26s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Boxed value is unboxed and then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:[line 183] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/19/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 81cbb5644bc7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 1dcb749 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/19/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/19/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/19/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/19/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/19/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/19/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 6160 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/19/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r545476573
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewTTLIT.java
##########
@@ -1406,6 +1407,7 @@ public void testWithVariousSQLsForMultipleViews() throws Exception {
}
}
+ @Ignore("Fails with StaleRegionBoundaryCacheException. Mutations on a SCN connection could be the reason")
Review comment:
@jpisaac - are the test fixes already in so that @kadirozde can rebase on them, or still just local to you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] jpisaac commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
jpisaac commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r544503466
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewTTLIT.java
##########
@@ -1406,6 +1407,7 @@ public void testWithVariousSQLsForMultipleViews() throws Exception {
}
}
+ @Ignore("Fails with StaleRegionBoundaryCacheException. Mutations on a SCN connection could be the reason")
Review comment:
@gjacoby126 @kadirozde I have a fix for these test failures. It was failing in BaseScannerRegionObserver.preScannerOpen by throwing throwIfScanOutOfRegion when deletion of LocalIndexes are involved. All the ViewTTLIT tests are passing after the fix on my local machine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-749823646
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 49s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 17m 40s | master passed |
| +1 :green_heart: | compile | 1m 21s | master passed |
| +1 :green_heart: | checkstyle | 2m 12s | master passed |
| +1 :green_heart: | javadoc | 0m 58s | master passed |
| +0 :ok: | spotbugs | 3m 49s | phoenix-core in master has 973 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 50s | the patch passed |
| +1 :green_heart: | compile | 0m 58s | the patch passed |
| +1 :green_heart: | javac | 0m 58s | the patch passed |
| -1 :x: | checkstyle | 1m 54s | phoenix-core: The patch generated 305 new + 4853 unchanged - 133 fixed = 5158 total (was 4986) |
| -1 :x: | whitespace | 0m 0s | The patch 10 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed |
| -1 :x: | spotbugs | 3m 27s | phoenix-core generated 1 new + 970 unchanged - 3 fixed = 971 total (was 973) |
||| _ Other Tests _ |
| -1 :x: | unit | 184m 24s | phoenix-core in the patch failed. |
| -1 :x: | asflicense | 0m 25s | The patch generated 1 ASF License warnings. |
| | | 232m 19s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Boxed value is unboxed and then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:[line 183] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/21/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux f8a9ac6215d5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 9e58989 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/21/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/21/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/21/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/21/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/21/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/21/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 6154 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/21/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-734051982
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 21s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 6s | master passed |
| +1 :green_heart: | compile | 1m 3s | master passed |
| +1 :green_heart: | checkstyle | 2m 5s | master passed |
| +1 :green_heart: | javadoc | 0m 47s | master passed |
| +0 :ok: | spotbugs | 3m 12s | phoenix-core in master has 966 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 23s | the patch passed |
| +1 :green_heart: | compile | 0m 59s | the patch passed |
| +1 :green_heart: | javac | 0m 59s | the patch passed |
| -1 :x: | checkstyle | 1m 53s | phoenix-core: The patch generated 236 new + 4813 unchanged - 86 fixed = 5049 total (was 4899) |
| -1 :x: | whitespace | 0m 0s | The patch 9 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 45s | the patch passed |
| -1 :x: | spotbugs | 3m 21s | phoenix-core generated 3 new + 964 unchanged - 2 fixed = 967 total (was 966) |
||| _ Other Tests _ |
| -1 :x: | unit | 181m 45s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. |
| | | 223m 58s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.filter.PhoenixPageFilter.getNextRowKey() may expose internal representation by returning PhoenixPageFilter.nextRowKey At PhoenixPageFilter.java:by returning PhoenixPageFilter.nextRowKey At PhoenixPageFilter.java:[line 74] |
| | org.apache.phoenix.filter.PhoenixPageFilter.getRowKeyAtStop() may expose internal representation by returning PhoenixPageFilter.rowKeyAtStop At PhoenixPageFilter.java:by returning PhoenixPageFilter.rowKeyAtStop At PhoenixPageFilter.java:[line 71] |
| | org.apache.phoenix.filter.PhoenixPageFilter.stopImmediatelyForTesting should be package protected At PhoenixPageFilter.java: At PhoenixPageFilter.java:[line 43] |
| Failed junit tests | phoenix.end2end.ViewTTLIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/9/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 7050f6c91edd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 457a67c |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/9/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/9/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/9/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/9/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/9/testReport/ |
| Max. process+thread count | 6117 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/9/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-757400110
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 16m 14s | master passed |
| +1 :green_heart: | compile | 0m 58s | master passed |
| +1 :green_heart: | checkstyle | 1m 47s | master passed |
| +1 :green_heart: | javadoc | 0m 48s | master passed |
| +0 :ok: | spotbugs | 3m 12s | phoenix-core in master has 956 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 22s | the patch passed |
| +1 :green_heart: | compile | 0m 58s | the patch passed |
| +1 :green_heart: | javac | 0m 58s | the patch passed |
| -1 :x: | checkstyle | 1m 50s | phoenix-core: The patch generated 317 new + 4854 unchanged - 133 fixed = 5171 total (was 4987) |
| -1 :x: | whitespace | 0m 0s | The patch 10 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed |
| -1 :x: | spotbugs | 3m 25s | phoenix-core generated 2 new + 953 unchanged - 3 fixed = 955 total (was 956) |
||| _ Other Tests _ |
| -1 :x: | unit | 184m 18s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. |
| | | 228m 19s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Should org.apache.phoenix.index.GlobalIndexChecker$GlobalIndexScanner be a _static_ inner class? At GlobalIndexChecker.java:inner class? At GlobalIndexChecker.java:[lines 128-608] |
| | Boxed value is unboxed and then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:[line 183] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux d800b0a70da3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 9c346ed |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/testReport/ |
| Max. process+thread count | 5980 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] kadirozde commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r543593516
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java
##########
@@ -1343,6 +1346,36 @@ public int prepareIndexMutations(Put put, Delete del, Map<byte[], List<Mutation>
return indexMutations.size();
}
+ static boolean adjustScanFilter(Scan scan) {
+ // For rebuilds we use count (*) as query for regular tables which ends up setting the FKOF on scan
Review comment:
ok
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
##########
@@ -241,6 +231,12 @@ public void preScannerOpen(org.apache.hadoop.hbase.coprocessor.ObserverContext<R
// last possible moment. You need to swap the start/stop and make the
// start exclusive and the stop inclusive.
ScanUtil.setupReverseScan(scan);
+ if (!(scan.getFilter() instanceof PagedFilter)) {
+ byte[] pageSizeMsBytes = scan.getAttribute(BaseScannerRegionObserver.SERVER_PAGE_SIZE_MS);
+ if (pageSizeMsBytes != null) {
+ scan.setFilter(new PagedFilter(scan.getFilter(), Bytes.toLong(pageSizeMsBytes)/2));
Review comment:
Good suggestion.
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java
##########
@@ -1351,26 +1384,18 @@ protected RegionScanner getLocalScanner() throws IOException {
Scan incrScan = new Scan(scan);
incrScan.setTimeRange(minTimestamp, scan.getTimeRange().getMax());
incrScan.setRaw(true);
- incrScan.setMaxVersions();
+ incrScan.readAllVersions();
incrScan.getFamilyMap().clear();
incrScan.setCacheBlocks(false);
for (byte[] family : scan.getFamilyMap().keySet()) {
incrScan.addFamily(family);
}
- // For rebuilds we use count (*) as query for regular tables which ends up setting the FKOF on scan
- // This filter doesn't give us all columns and skips to the next row as soon as it finds 1 col
- // For rebuilds we need all columns and all versions
- if (scan.getFilter() instanceof FirstKeyOnlyFilter) {
- incrScan.setFilter(null);
- } else if (scan.getFilter() != null) {
- // Override the filter so that we get all versions
- incrScan.setFilter(new AllVersionsIndexRebuildFilter(scan.getFilter()));
- }
+ adjustScanFilter(incrScan);
if(nextStartKey != null) {
incrScan.setStartRow(nextStartKey);
}
List<KeyRange> keys = new ArrayList<>();
- try(RegionScanner scanner = region.getScanner(incrScan)) {
+ try(RegionScanner scanner = new PagedRegionScanner(region, region.getScanner(incrScan), incrScan)) {
Review comment:
ok
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java
##########
@@ -1223,21 +1232,66 @@ public static void getDummyResult(List<Cell> result) {
getDummyResult(EMPTY_BYTE_ARRAY, result);
}
+ public static Tuple getDummyTuple(byte[] rowKey) {
+ List<Cell> result = new ArrayList<Cell>(1);
+ getDummyResult(rowKey, result);
+ return new ResultTuple(Result.create(result));
+ }
+
+ public static Tuple getDummyTuple() {
+ List<Cell> result = new ArrayList<Cell>(1);
+ getDummyResult(result);
+ return new ResultTuple(Result.create(result));
+ }
+
+ public static Tuple getDummyTuple(Tuple tuple) {
+ ImmutableBytesWritable ptr = new ImmutableBytesWritable();
+ tuple.getKey(ptr);
+ return getDummyTuple(ptr.copyBytes());
+ }
+
+ public static boolean isDummy(Cell cell) {
+ return CellUtil.matchingColumn(cell, EMPTY_BYTE_ARRAY, EMPTY_BYTE_ARRAY);
+ }
+
public static boolean isDummy(Result result) {
- // Check if the result is a dummy result
if (result.rawCells().length != 1) {
return false;
}
Cell cell = result.rawCells()[0];
- return CellUtil.matchingColumn(cell, EMPTY_BYTE_ARRAY, EMPTY_BYTE_ARRAY);
+ return isDummy(cell);
}
public static boolean isDummy(List<Cell> result) {
- // Check if the result is a dummy result
if (result.size() != 1) {
return false;
}
Cell cell = result.get(0);
- return CellUtil.matchingColumn(cell, EMPTY_BYTE_ARRAY, EMPTY_BYTE_ARRAY);
+ return isDummy(cell);
+ }
+
+ public static boolean isDummy(Tuple tuple) {
+ if (tuple instanceof ResultTuple) {
+ isDummy(((ResultTuple) tuple).getResult());
+ }
+ return false;
+ }
+
+ public static PagedFilter getPhoenixPageFilter(Scan scan) {
+ Filter filter = scan.getFilter();
Review comment:
PagedFilter is added on the server side by coprocs after the client prepares the scan, in order to wrap the filter set by the client. It is not used by the client. The method name here should be renamed to getPhoenixPagedFilter().
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixTTLRegionObserver.java
##########
@@ -41,35 +43,41 @@
import org.slf4j.LoggerFactory;
import java.io.IOException;
+import java.sql.SQLException;
import java.util.Iterator;
import java.util.List;
+import java.util.Optional;
-import static org.apache.phoenix.coprocessor.BaseScannerRegionObserver.EMPTY_COLUMN_FAMILY_NAME;
-import static org.apache.phoenix.coprocessor.BaseScannerRegionObserver.EMPTY_COLUMN_QUALIFIER_NAME;
+import static org.apache.phoenix.util.ScanUtil.getDummyResult;
+import static org.apache.phoenix.util.ScanUtil.getPageSizeMs;
+import static org.apache.phoenix.util.ScanUtil.isDummy;
/**
* Coprocessor that checks whether the row is expired based on the TTL spec.
*/
-public class PhoenixTTLRegionObserver extends BaseRegionObserver {
+public class PhoenixTTLRegionObserver extends BaseScannerRegionObserver implements RegionCoprocessor {
private static final Logger LOG = LoggerFactory.getLogger(PhoenixTTLRegionObserver.class);
private MetricsPhoenixTTLSource metricSource;
- @Override public void start(CoprocessorEnvironment e) throws IOException {
- super.start(e);
- metricSource = MetricsPhoenixCoprocessorSourceFactory.getInstance().getPhoenixTTLSource();
+ @Override
+ public Optional<RegionObserver> getRegionObserver() {
+ return Optional.of(this);
}
- @Override public void stop(CoprocessorEnvironment e) throws IOException {
- super.stop(e);
+ @Override
+ public void start(CoprocessorEnvironment e) throws IOException {
+ metricSource = MetricsPhoenixCoprocessorSourceFactory.getInstance().getPhoenixTTLSource();
Review comment:
We have changed the super from BaseRegionObserver to BaseScannerRegionObserver which does not have start() or something equivalent.
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/schema/tuple/ResultTuple.java
##########
@@ -26,6 +27,9 @@
import org.apache.hadoop.hbase.util.Bytes;
import org.apache.phoenix.hbase.index.util.GenericKeyValueBuilder;
import org.apache.phoenix.util.PhoenixKeyValueUtil;
+import org.apache.phoenix.util.ScanUtil;
Review comment:
Ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] kadirozde commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r545508156
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/OrderedResultIterator.java
##########
@@ -245,23 +256,33 @@ public int compare(ImmutableBytesWritable o1, ImmutableBytesWritable o2) {
@Override
public Tuple next() throws SQLException {
- return getResultIterator().next();
+ getResultIterator();
+ if (!resultIteratorReady) {
+ return dummyTuple;
+ }
+ return resultIterator.next();
}
private PeekingResultIterator getResultIterator() throws SQLException {
- if (resultIterator != null) {
+ if (resultIteratorReady) {
Review comment:
The results have not been ordered yet. When the results are ordered then the result iterator will be ready to iterate over them. I will add a comment for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] jpisaac commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
jpisaac commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r546858710
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewTTLIT.java
##########
@@ -1406,6 +1407,7 @@ public void testWithVariousSQLsForMultipleViews() throws Exception {
}
}
+ @Ignore("Fails with StaleRegionBoundaryCacheException. Mutations on a SCN connection could be the reason")
Review comment:
[0001-Fixes-for-local-index-scans-and-additional-tests.patch.txt](https://github.com/apache/phoenix/files/5725843/0001-Fixes-for-local-index-scans-and-additional-tests.patch.txt)
@kadirozde @gjacoby126 I have attached the changes for the local index changes and some additional tests and added some comments on the PhoenixTTLRegionObserver
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r545485500
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/OffsetResultIterator.java
##########
@@ -32,17 +36,27 @@
public class OffsetResultIterator extends DelegateResultIterator {
private int rowCount;
private int offset;
+ private long pageSizeMs = Long.MAX_VALUE;
public OffsetResultIterator(ResultIterator delegate, Integer offset) {
super(delegate);
this.offset = offset == null ? -1 : offset;
}
+ public OffsetResultIterator(ResultIterator delegate, Integer offset, long pageSizeMs) {
+ this(delegate, offset);
+ this.pageSizeMs = pageSizeMs;
+ }
@Override
public Tuple next() throws SQLException {
+ long startTime = EnvironmentEdgeManager.currentTimeMillis();
while (rowCount < offset) {
- if (super.next() == null) { return null; }
+ Tuple tuple = super.next();
+ if (tuple == null) { return null; }
rowCount++;
+ if (EnvironmentEdgeManager.currentTimeMillis() - startTime >= pageSizeMs) {
Review comment:
I'm unclear why we're enforcing the time limits both in the FIlter/coprocs and also at the client level in the Iterators/Tuples. Do we need the latter in queries processed primarily on the client side? I'd expect the Iterator to be checking the Tuple returned to the client to see if it was the magic Dummy result, rather than checking the time itself.
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/OrderedResultIterator.java
##########
@@ -245,23 +256,33 @@ public int compare(ImmutableBytesWritable o1, ImmutableBytesWritable o2) {
@Override
public Tuple next() throws SQLException {
- return getResultIterator().next();
+ getResultIterator();
+ if (!resultIteratorReady) {
+ return dummyTuple;
+ }
+ return resultIterator.next();
}
private PeekingResultIterator getResultIterator() throws SQLException {
- if (resultIterator != null) {
+ if (resultIteratorReady) {
Review comment:
what does Ready mean in this context?
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PagedRegionScanner.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.coprocessor;
+
+import java.io.IOException;
+import java.util.List;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.regionserver.Region;
+import org.apache.hadoop.hbase.regionserver.RegionScanner;
+import org.apache.phoenix.filter.PagedFilter;
+
+import static org.apache.phoenix.util.ScanUtil.getDummyResult;
+import static org.apache.phoenix.util.ScanUtil.getPhoenixPagedFilter;
+
+public class PagedRegionScanner extends BaseRegionScanner {
+ protected Region region;
+ protected Scan scan;
+ protected PagedFilter pageFilter;
+ public PagedRegionScanner(Region region, RegionScanner scanner, Scan scan) {
+ super(scanner);
+ this.region = region;
+ this.scan = scan;
+ pageFilter = getPhoenixPagedFilter(scan);
+ if (pageFilter != null) {
+ pageFilter.init();
+ }
+ }
+
+ private boolean next(List<Cell> results, boolean raw) throws IOException {
+ boolean hasMore = raw ? delegate.nextRaw(results) : delegate.next(results);
Review comment:
if we throw an exception at either line 47 or line 56, do we clean up our state properly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] kadirozde commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r545506749
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/OffsetResultIterator.java
##########
@@ -32,17 +36,27 @@
public class OffsetResultIterator extends DelegateResultIterator {
private int rowCount;
private int offset;
+ private long pageSizeMs = Long.MAX_VALUE;
public OffsetResultIterator(ResultIterator delegate, Integer offset) {
super(delegate);
this.offset = offset == null ? -1 : offset;
}
+ public OffsetResultIterator(ResultIterator delegate, Integer offset, long pageSizeMs) {
+ this(delegate, offset);
+ this.pageSizeMs = pageSizeMs;
+ }
@Override
public Tuple next() throws SQLException {
+ long startTime = EnvironmentEdgeManager.currentTimeMillis();
while (rowCount < offset) {
- if (super.next() == null) { return null; }
+ Tuple tuple = super.next();
+ if (tuple == null) { return null; }
rowCount++;
+ if (EnvironmentEdgeManager.currentTimeMillis() - startTime >= pageSizeMs) {
Review comment:
OffsetResultIterator is also used on the server side. When it is used on the client side, pageSizeMs is set to Long.MAX_VALUE in the constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-732952029
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 23s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 38s | master passed |
| +1 :green_heart: | compile | 1m 1s | master passed |
| +1 :green_heart: | checkstyle | 1m 44s | master passed |
| +1 :green_heart: | javadoc | 0m 48s | master passed |
| +0 :ok: | spotbugs | 3m 34s | phoenix-core in master has 966 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 22s | the patch passed |
| +1 :green_heart: | compile | 1m 3s | the patch passed |
| +1 :green_heart: | javac | 1m 3s | the patch passed |
| -1 :x: | checkstyle | 1m 47s | phoenix-core: The patch generated 225 new + 4445 unchanged - 82 fixed = 4670 total (was 4527) |
| -1 :x: | whitespace | 0m 0s | The patch 9 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 52s | the patch passed |
| -1 :x: | spotbugs | 3m 45s | phoenix-core generated 3 new + 964 unchanged - 2 fixed = 967 total (was 966) |
||| _ Other Tests _ |
| -1 :x: | unit | 201m 58s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. |
| | | 245m 25s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.filter.PhoenixPageFilter.getNextRowKey() may expose internal representation by returning PhoenixPageFilter.nextRowKey At PhoenixPageFilter.java:by returning PhoenixPageFilter.nextRowKey At PhoenixPageFilter.java:[line 74] |
| | org.apache.phoenix.filter.PhoenixPageFilter.getRowKeyAtStop() may expose internal representation by returning PhoenixPageFilter.rowKeyAtStop At PhoenixPageFilter.java:by returning PhoenixPageFilter.rowKeyAtStop At PhoenixPageFilter.java:[line 71] |
| | org.apache.phoenix.filter.PhoenixPageFilter.stopImmediatelyForTesting should be package protected At PhoenixPageFilter.java: At PhoenixPageFilter.java:[line 43] |
| Failed junit tests | phoenix.end2end.index.PartialIndexRebuilderIT |
| | phoenix.end2end.ViewTTLIT |
| | phoenix.end2end.RowValueConstructorIT |
| | phoenix.end2end.ProductMetricsIT |
| | phoenix.end2end.ReverseScanIT |
| | phoenix.end2end.DistinctPrefixFilterIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/7/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 2e22d51350ea 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / f1a0860 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/7/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/7/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/7/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/7/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/7/testReport/ |
| Max. process+thread count | 6194 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/7/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-733523095
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 39s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 15m 26s | master passed |
| +1 :green_heart: | compile | 1m 14s | master passed |
| +1 :green_heart: | checkstyle | 2m 2s | master passed |
| +1 :green_heart: | javadoc | 0m 57s | master passed |
| +0 :ok: | spotbugs | 3m 16s | phoenix-core in master has 966 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 59s | the patch passed |
| +1 :green_heart: | compile | 0m 53s | the patch passed |
| +1 :green_heart: | javac | 0m 53s | the patch passed |
| -1 :x: | checkstyle | 2m 32s | phoenix-core: The patch generated 229 new + 4569 unchanged - 83 fixed = 4798 total (was 4652) |
| -1 :x: | whitespace | 0m 0s | The patch 9 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 43s | the patch passed |
| -1 :x: | spotbugs | 3m 9s | phoenix-core generated 3 new + 964 unchanged - 2 fixed = 967 total (was 966) |
||| _ Other Tests _ |
| -1 :x: | unit | 107m 49s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 27s | The patch does not generate ASF License warnings. |
| | | 149m 56s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.filter.PhoenixPageFilter.getNextRowKey() may expose internal representation by returning PhoenixPageFilter.nextRowKey At PhoenixPageFilter.java:by returning PhoenixPageFilter.nextRowKey At PhoenixPageFilter.java:[line 74] |
| | org.apache.phoenix.filter.PhoenixPageFilter.getRowKeyAtStop() may expose internal representation by returning PhoenixPageFilter.rowKeyAtStop At PhoenixPageFilter.java:by returning PhoenixPageFilter.rowKeyAtStop At PhoenixPageFilter.java:[line 71] |
| | org.apache.phoenix.filter.PhoenixPageFilter.stopImmediatelyForTesting should be package protected At PhoenixPageFilter.java: At PhoenixPageFilter.java:[line 43] |
| Failed junit tests | phoenix.end2end.ProductMetricsIT |
| | phoenix.end2end.RowValueConstructorIT |
| | phoenix.end2end.ViewTTLIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/8/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 4943b7703dd0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / f1f92aa |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/8/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/8/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/8/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/8/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/8/testReport/ |
| Max. process+thread count | 6951 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/8/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-756529442
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 23s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 16m 28s | master passed |
| +1 :green_heart: | compile | 1m 7s | master passed |
| +1 :green_heart: | checkstyle | 1m 47s | master passed |
| +1 :green_heart: | javadoc | 0m 48s | master passed |
| +0 :ok: | spotbugs | 3m 9s | phoenix-core in master has 956 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 41s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| -1 :x: | checkstyle | 1m 52s | phoenix-core: The patch generated 314 new + 4854 unchanged - 133 fixed = 5168 total (was 4987) |
| -1 :x: | whitespace | 0m 0s | The patch 10 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 48s | the patch passed |
| -1 :x: | spotbugs | 3m 29s | phoenix-core generated 2 new + 953 unchanged - 3 fixed = 955 total (was 956) |
||| _ Other Tests _ |
| -1 :x: | unit | 196m 46s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. |
| | | 241m 39s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Should org.apache.phoenix.index.GlobalIndexChecker$GlobalIndexScanner be a _static_ inner class? At GlobalIndexChecker.java:inner class? At GlobalIndexChecker.java:[lines 128-608] |
| | Boxed value is unboxed and then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:[line 183] |
| Failed junit tests | phoenix.rpc.UpdateCacheIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/23/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 9c2223f1a4a8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / ca4f784 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/23/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/23/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/23/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/23/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/23/testReport/ |
| Max. process+thread count | 5746 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/23/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] kadirozde commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r553523321
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PagedRegionScanner.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.coprocessor;
+
+import java.io.IOException;
+import java.util.List;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.regionserver.Region;
+import org.apache.hadoop.hbase.regionserver.RegionScanner;
+import org.apache.phoenix.filter.PagedFilter;
+
+import static org.apache.phoenix.util.ScanUtil.getDummyResult;
+import static org.apache.phoenix.util.ScanUtil.getPhoenixPagedFilter;
+
+public class PagedRegionScanner extends BaseRegionScanner {
+ protected Region region;
+ protected Scan scan;
+ protected PagedFilter pageFilter;
+ public PagedRegionScanner(Region region, RegionScanner scanner, Scan scan) {
+ super(scanner);
+ this.region = region;
+ this.scan = scan;
+ pageFilter = getPhoenixPagedFilter(scan);
+ if (pageFilter != null) {
+ pageFilter.init();
+ }
+ }
+
+ private boolean next(List<Cell> results, boolean raw) throws IOException {
+ try {
+ boolean hasMore = raw ? delegate.nextRaw(results) : delegate.next(results);
+ if (pageFilter == null) {
+ return hasMore;
+ }
+ if (!hasMore) {
Review comment:
I will add comments to clarify this. PagedRegionScanner works with PagedFilter to make sure that the time between two rows returned by the HBase region scanner should not exceed the configured page size in ms (on PagedFilter). When the page size is reached (because there are too many cells/rows to be filtered out), PagedFilter stops the HBase region scanner and sets its state to STOPPED. In this case, the HBase region scanner next() returns false and PagedFilter#isStopped() returns true. PagedRegionScanner is responsible for detecting PagedFilter has stopped the scanner, and then closing the current HBase region scanner, starting a new one to resume the scan operation and returning a dummy result to signal to Phoenix client to resume the scan operation by skipping this dummy result and calling ResultScanner#next().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r538855230
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java
##########
@@ -1343,6 +1346,36 @@ public int prepareIndexMutations(Put put, Delete del, Map<byte[], List<Mutation>
return indexMutations.size();
}
+ static boolean adjustScanFilter(Scan scan) {
+ // For rebuilds we use count (*) as query for regular tables which ends up setting the FKOF on scan
Review comment:
nit: please spell out FirstKeyOnlyFilter. Took me a minute to figure it out. :-)
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java
##########
@@ -244,7 +247,7 @@ public GlobalIndexRegionScanner(final RegionScanner innerScanner,
new IndexVerificationResultRepository(indexMaintainer.getIndexTableName(), hTableFactory);
nextStartKey = null;
minTimestamp = scan.getTimeRange().getMin();
- useSkipScanFilter = HbaseCompatCapabilities.isRawFilterSupported();
+ isRawFilterSupported = HbaseCompatCapabilities.isRawFilterSupported();
Review comment:
Good rename
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixTTLRegionObserver.java
##########
@@ -41,35 +43,41 @@
import org.slf4j.LoggerFactory;
import java.io.IOException;
+import java.sql.SQLException;
import java.util.Iterator;
import java.util.List;
+import java.util.Optional;
-import static org.apache.phoenix.coprocessor.BaseScannerRegionObserver.EMPTY_COLUMN_FAMILY_NAME;
-import static org.apache.phoenix.coprocessor.BaseScannerRegionObserver.EMPTY_COLUMN_QUALIFIER_NAME;
+import static org.apache.phoenix.util.ScanUtil.getDummyResult;
+import static org.apache.phoenix.util.ScanUtil.getPageSizeMs;
+import static org.apache.phoenix.util.ScanUtil.isDummy;
/**
* Coprocessor that checks whether the row is expired based on the TTL spec.
*/
-public class PhoenixTTLRegionObserver extends BaseRegionObserver {
+public class PhoenixTTLRegionObserver extends BaseScannerRegionObserver implements RegionCoprocessor {
private static final Logger LOG = LoggerFactory.getLogger(PhoenixTTLRegionObserver.class);
private MetricsPhoenixTTLSource metricSource;
- @Override public void start(CoprocessorEnvironment e) throws IOException {
- super.start(e);
- metricSource = MetricsPhoenixCoprocessorSourceFactory.getInstance().getPhoenixTTLSource();
+ @Override
+ public Optional<RegionObserver> getRegionObserver() {
+ return Optional.of(this);
}
- @Override public void stop(CoprocessorEnvironment e) throws IOException {
- super.stop(e);
+ @Override
+ public void start(CoprocessorEnvironment e) throws IOException {
+ metricSource = MetricsPhoenixCoprocessorSourceFactory.getInstance().getPhoenixTTLSource();
Review comment:
why don't we need to call super.start()? (and are removing the existing call to super.stop()?
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewTTLIT.java
##########
@@ -1406,6 +1407,7 @@ public void testWithVariousSQLsForMultipleViews() throws Exception {
}
}
+ @Ignore("Fails with StaleRegionBoundaryCacheException. Mutations on a SCN connection could be the reason")
Review comment:
@jpisaac what are the implications of ignoring these tests?
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/schema/tuple/ResultTuple.java
##########
@@ -26,6 +27,9 @@
import org.apache.hadoop.hbase.util.Bytes;
import org.apache.phoenix.hbase.index.util.GenericKeyValueBuilder;
import org.apache.phoenix.util.PhoenixKeyValueUtil;
+import org.apache.phoenix.util.ScanUtil;
Review comment:
nit: seems like several unnecessary imports?
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
##########
@@ -241,6 +231,12 @@ public void preScannerOpen(org.apache.hadoop.hbase.coprocessor.ObserverContext<R
// last possible moment. You need to swap the start/stop and make the
// start exclusive and the stop inclusive.
ScanUtil.setupReverseScan(scan);
+ if (!(scan.getFilter() instanceof PagedFilter)) {
+ byte[] pageSizeMsBytes = scan.getAttribute(BaseScannerRegionObserver.SERVER_PAGE_SIZE_MS);
+ if (pageSizeMsBytes != null) {
+ scan.setFilter(new PagedFilter(scan.getFilter(), Bytes.toLong(pageSizeMsBytes)/2));
Review comment:
Why divided by 2? To allow for round trip time back to client? Good to have a comment.
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java
##########
@@ -1351,26 +1384,18 @@ protected RegionScanner getLocalScanner() throws IOException {
Scan incrScan = new Scan(scan);
incrScan.setTimeRange(minTimestamp, scan.getTimeRange().getMax());
incrScan.setRaw(true);
- incrScan.setMaxVersions();
+ incrScan.readAllVersions();
incrScan.getFamilyMap().clear();
incrScan.setCacheBlocks(false);
for (byte[] family : scan.getFamilyMap().keySet()) {
incrScan.addFamily(family);
}
- // For rebuilds we use count (*) as query for regular tables which ends up setting the FKOF on scan
- // This filter doesn't give us all columns and skips to the next row as soon as it finds 1 col
- // For rebuilds we need all columns and all versions
- if (scan.getFilter() instanceof FirstKeyOnlyFilter) {
- incrScan.setFilter(null);
- } else if (scan.getFilter() != null) {
- // Override the filter so that we get all versions
- incrScan.setFilter(new AllVersionsIndexRebuildFilter(scan.getFilter()));
- }
+ adjustScanFilter(incrScan);
if(nextStartKey != null) {
incrScan.setStartRow(nextStartKey);
}
List<KeyRange> keys = new ArrayList<>();
- try(RegionScanner scanner = region.getScanner(incrScan)) {
+ try(RegionScanner scanner = new PagedRegionScanner(region, region.getScanner(incrScan), incrScan)) {
Review comment:
tiny nit: space between try and (. (checkstyle will complain)
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java
##########
@@ -1223,21 +1232,66 @@ public static void getDummyResult(List<Cell> result) {
getDummyResult(EMPTY_BYTE_ARRAY, result);
}
+ public static Tuple getDummyTuple(byte[] rowKey) {
+ List<Cell> result = new ArrayList<Cell>(1);
+ getDummyResult(rowKey, result);
+ return new ResultTuple(Result.create(result));
+ }
+
+ public static Tuple getDummyTuple() {
+ List<Cell> result = new ArrayList<Cell>(1);
+ getDummyResult(result);
+ return new ResultTuple(Result.create(result));
+ }
+
+ public static Tuple getDummyTuple(Tuple tuple) {
+ ImmutableBytesWritable ptr = new ImmutableBytesWritable();
+ tuple.getKey(ptr);
+ return getDummyTuple(ptr.copyBytes());
+ }
+
+ public static boolean isDummy(Cell cell) {
+ return CellUtil.matchingColumn(cell, EMPTY_BYTE_ARRAY, EMPTY_BYTE_ARRAY);
+ }
+
public static boolean isDummy(Result result) {
- // Check if the result is a dummy result
if (result.rawCells().length != 1) {
return false;
}
Cell cell = result.rawCells()[0];
- return CellUtil.matchingColumn(cell, EMPTY_BYTE_ARRAY, EMPTY_BYTE_ARRAY);
+ return isDummy(cell);
}
public static boolean isDummy(List<Cell> result) {
- // Check if the result is a dummy result
if (result.size() != 1) {
return false;
}
Cell cell = result.get(0);
- return CellUtil.matchingColumn(cell, EMPTY_BYTE_ARRAY, EMPTY_BYTE_ARRAY);
+ return isDummy(cell);
+ }
+
+ public static boolean isDummy(Tuple tuple) {
+ if (tuple instanceof ResultTuple) {
+ isDummy(((ResultTuple) tuple).getResult());
+ }
+ return false;
+ }
+
+ public static PagedFilter getPhoenixPageFilter(Scan scan) {
+ Filter filter = scan.getFilter();
Review comment:
What if the scan's filter is a FilterList that contains a PagedFilter?
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixTTLRegionObserver.java
##########
@@ -204,17 +213,22 @@ public PhoenixTTLRegionScanner(RegionCoprocessorEnvironment env, Scan scan,
private boolean doNext(List<Cell> result, boolean raw) throws IOException {
try {
+ long startTime = EnvironmentEdgeManager.currentTimeMillis();
boolean hasMore;
do {
hasMore = raw ? scanner.nextRaw(result) : scanner.next(result);
if (result.isEmpty()) {
break;
}
+ if (isDummy(result)) {
+ return true;
+ }
numRowsScanned++;
if (maskIfExpired && checkRowNotExpired(result)) {
break;
}
+ //TODO 6211 The following logic does not sound correct
Review comment:
@jpisaac can you please comment on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-756438499
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 4s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 15m 46s | master passed |
| +1 :green_heart: | compile | 0m 59s | master passed |
| +1 :green_heart: | checkstyle | 1m 47s | master passed |
| +1 :green_heart: | javadoc | 0m 49s | master passed |
| +0 :ok: | spotbugs | 3m 10s | phoenix-core in master has 972 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 20s | the patch passed |
| +1 :green_heart: | compile | 0m 57s | the patch passed |
| +1 :green_heart: | javac | 0m 57s | the patch passed |
| -1 :x: | checkstyle | 1m 51s | phoenix-core: The patch generated 314 new + 4854 unchanged - 133 fixed = 5168 total (was 4987) |
| -1 :x: | whitespace | 0m 0s | The patch 10 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 48s | the patch passed |
| -1 :x: | spotbugs | 3m 24s | phoenix-core generated 1 new + 969 unchanged - 3 fixed = 970 total (was 972) |
||| _ Other Tests _ |
| -1 :x: | unit | 171m 51s | phoenix-core in the patch failed. |
| -1 :x: | asflicense | 0m 23s | The patch generated 1 ASF License warnings. |
| | | 214m 50s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Boxed value is unboxed and then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:[line 183] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/22/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 5171ee7193f3 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 132aed1 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/22/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/22/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/22/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/22/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/22/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/22/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 5744 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/22/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-739571967
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 11s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| -1 :x: | mvninstall | 2m 36s | root in master failed. |
| -1 :x: | compile | 0m 12s | phoenix-core in master failed. |
| -1 :x: | checkstyle | 0m 5s | The patch fails to run checkstyle in phoenix-core |
| -1 :x: | javadoc | 0m 9s | phoenix-core in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix-core in master failed. |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 0m 21s | root in the patch failed. |
| -1 :x: | compile | 0m 8s | phoenix-core in the patch failed. |
| -1 :x: | javac | 0m 8s | phoenix-core in the patch failed. |
| -1 :x: | checkstyle | 0m 6s | The patch fails to run checkstyle in phoenix-core |
| -1 :x: | whitespace | 0m 0s | The patch 9 line(s) with tabs. |
| -1 :x: | javadoc | 0m 8s | phoenix-core in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix-core in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 8s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. |
| | | 6m 10s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 81d04c229299 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 7d9f78d |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/artifact/yetus-general-check/output/branch-compile-phoenix-core.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/artifact/yetus-general-check/output/buildtool-branch-checkstyle-phoenix-core.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/artifact/yetus-general-check/output/branch-javadoc-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/artifact/yetus-general-check/output/branch-spotbugs-phoenix-core.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/artifact/yetus-general-check/output/buildtool-patch-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/artifact/yetus-general-check/output/whitespace-tabs.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/artifact/yetus-general-check/output/patch-javadoc-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/testReport/ |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/14/console |
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-739692931
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 19s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| -1 :x: | mvninstall | 2m 34s | root in master failed. |
| -1 :x: | compile | 0m 13s | phoenix-core in master failed. |
| -1 :x: | checkstyle | 0m 6s | The patch fails to run checkstyle in phoenix-core |
| -1 :x: | javadoc | 0m 9s | phoenix-core in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix-core in master failed. |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 0m 22s | root in the patch failed. |
| -1 :x: | compile | 0m 8s | phoenix-core in the patch failed. |
| -1 :x: | javac | 0m 8s | phoenix-core in the patch failed. |
| -1 :x: | checkstyle | 0m 6s | The patch fails to run checkstyle in phoenix-core |
| -1 :x: | whitespace | 0m 0s | The patch 9 line(s) with tabs. |
| -1 :x: | javadoc | 0m 8s | phoenix-core in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix-core in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 8s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. |
| | | 6m 12s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 1f08d5858f1d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 7d9f78d |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/artifact/yetus-general-check/output/branch-compile-phoenix-core.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/artifact/yetus-general-check/output/buildtool-branch-checkstyle-phoenix-core.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/artifact/yetus-general-check/output/branch-javadoc-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/artifact/yetus-general-check/output/branch-spotbugs-phoenix-core.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/artifact/yetus-general-check/output/buildtool-patch-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/artifact/yetus-general-check/output/whitespace-tabs.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/artifact/yetus-general-check/output/patch-javadoc-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/testReport/ |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/15/console |
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-741357423
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 9s | master passed |
| +1 :green_heart: | compile | 1m 5s | master passed |
| +1 :green_heart: | checkstyle | 1m 45s | master passed |
| +1 :green_heart: | javadoc | 0m 50s | master passed |
| +0 :ok: | spotbugs | 3m 22s | phoenix-core in master has 966 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 18s | the patch passed |
| +1 :green_heart: | compile | 1m 2s | the patch passed |
| +1 :green_heart: | javac | 1m 2s | the patch passed |
| -1 :x: | checkstyle | 1m 49s | phoenix-core: The patch generated 290 new + 4837 unchanged - 129 fixed = 5127 total (was 4966) |
| -1 :x: | whitespace | 0m 0s | The patch 9 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed |
| -1 :x: | spotbugs | 3m 36s | phoenix-core generated 1 new + 963 unchanged - 3 fixed = 964 total (was 966) |
||| _ Other Tests _ |
| -1 :x: | unit | 208m 26s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. |
| | | 250m 50s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Boxed value is unboxed and then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:[line 183] |
| Failed junit tests | phoenix.end2end.SystemTablesCreationOnConnectionIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/17/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux da02a82bfb20 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 7b549c9 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/17/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/17/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/17/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/17/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/17/testReport/ |
| Max. process+thread count | 6214 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/17/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] kadirozde commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r553524128
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewTTLIT.java
##########
@@ -2596,4 +2606,119 @@ private void deleteIndexData(boolean useGlobalConnection,
return testCases;
}
+
+ @Test
+ public void testPR() throws Exception {
Review comment:
I will remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-749317567
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 16s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 15m 59s | master passed |
| +1 :green_heart: | compile | 0m 57s | master passed |
| +1 :green_heart: | checkstyle | 1m 50s | master passed |
| +1 :green_heart: | javadoc | 0m 46s | master passed |
| +0 :ok: | spotbugs | 3m 12s | phoenix-core in master has 972 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 14s | the patch passed |
| +1 :green_heart: | compile | 1m 6s | the patch passed |
| +1 :green_heart: | javac | 1m 6s | the patch passed |
| -1 :x: | checkstyle | 1m 55s | phoenix-core: The patch generated 301 new + 4839 unchanged - 129 fixed = 5140 total (was 4968) |
| -1 :x: | whitespace | 0m 0s | The patch 10 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 45s | the patch passed |
| -1 :x: | spotbugs | 3m 24s | phoenix-core generated 1 new + 969 unchanged - 3 fixed = 970 total (was 972) |
||| _ Other Tests _ |
| -1 :x: | unit | 193m 4s | phoenix-core in the patch failed. |
| -1 :x: | asflicense | 0m 23s | The patch generated 1 ASF License warnings. |
| | | 236m 39s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Boxed value is unboxed and then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:[line 183] |
| Failed junit tests | phoenix.rpc.UpdateCacheIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/20/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux aced8831f87e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 1dcb749 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/20/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/20/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/20/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/20/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/20/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/20/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 6231 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/20/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] kadirozde commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r546866032
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PagedRegionScanner.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.coprocessor;
+
+import java.io.IOException;
+import java.util.List;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.regionserver.Region;
+import org.apache.hadoop.hbase.regionserver.RegionScanner;
+import org.apache.phoenix.filter.PagedFilter;
+
+import static org.apache.phoenix.util.ScanUtil.getDummyResult;
+import static org.apache.phoenix.util.ScanUtil.getPhoenixPagedFilter;
+
+public class PagedRegionScanner extends BaseRegionScanner {
+ protected Region region;
+ protected Scan scan;
+ protected PagedFilter pageFilter;
+ public PagedRegionScanner(Region region, RegionScanner scanner, Scan scan) {
+ super(scanner);
+ this.region = region;
+ this.scan = scan;
+ pageFilter = getPhoenixPagedFilter(scan);
+ if (pageFilter != null) {
+ pageFilter.init();
+ }
+ }
+
+ private boolean next(List<Cell> results, boolean raw) throws IOException {
+ boolean hasMore = raw ? delegate.nextRaw(results) : delegate.next(results);
Review comment:
I will add exception handling here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-755798226
@kadirozde - other than above comments lgtm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-739427359
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| -1 :x: | mvninstall | 2m 48s | root in master failed. |
| -1 :x: | compile | 0m 12s | phoenix-core in master failed. |
| -1 :x: | checkstyle | 0m 6s | The patch fails to run checkstyle in phoenix-core |
| -1 :x: | javadoc | 0m 9s | phoenix-core in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix-core in master failed. |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 0m 22s | root in the patch failed. |
| -1 :x: | compile | 0m 8s | phoenix-core in the patch failed. |
| -1 :x: | javac | 0m 8s | phoenix-core in the patch failed. |
| -1 :x: | checkstyle | 0m 5s | The patch fails to run checkstyle in phoenix-core |
| -1 :x: | whitespace | 0m 0s | The patch 9 line(s) with tabs. |
| -1 :x: | javadoc | 0m 8s | phoenix-core in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix-core in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 8s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. |
| | | 6m 10s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 2b94e1d509a6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 7d9f78d |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/artifact/yetus-general-check/output/branch-compile-phoenix-core.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/artifact/yetus-general-check/output/buildtool-branch-checkstyle-phoenix-core.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/artifact/yetus-general-check/output/branch-javadoc-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/artifact/yetus-general-check/output/branch-spotbugs-phoenix-core.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/artifact/yetus-general-check/output/buildtool-patch-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/artifact/yetus-general-check/output/whitespace-tabs.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/artifact/yetus-general-check/output/patch-javadoc-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/testReport/ |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/12/console |
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-745624666
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 16s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 34s | master passed |
| +1 :green_heart: | compile | 1m 19s | master passed |
| +1 :green_heart: | checkstyle | 2m 25s | master passed |
| +1 :green_heart: | javadoc | 0m 55s | master passed |
| +0 :ok: | spotbugs | 3m 36s | phoenix-core in master has 967 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 10m 37s | the patch passed |
| +1 :green_heart: | compile | 1m 8s | the patch passed |
| +1 :green_heart: | javac | 1m 8s | the patch passed |
| -1 :x: | checkstyle | 2m 9s | phoenix-core: The patch generated 295 new + 4839 unchanged - 129 fixed = 5134 total (was 4968) |
| -1 :x: | whitespace | 0m 0s | The patch 9 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 52s | the patch passed |
| -1 :x: | spotbugs | 3m 39s | phoenix-core generated 1 new + 964 unchanged - 3 fixed = 965 total (was 967) |
||| _ Other Tests _ |
| -1 :x: | unit | 169m 41s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. |
| | | 215m 26s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Boxed value is unboxed and then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:[line 183] |
| Failed junit tests | phoenix.end2end.SystemTablesCreationOnConnectionIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/18/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux a32a398c5af6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / f039e52 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/18/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/18/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/18/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/18/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/18/testReport/ |
| Max. process+thread count | 6304 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/18/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] kadirozde closed pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
kadirozde closed pull request #973:
URL: https://github.com/apache/phoenix/pull/973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-739565200
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| -1 :x: | mvninstall | 2m 34s | root in master failed. |
| -1 :x: | compile | 0m 13s | phoenix-core in master failed. |
| -1 :x: | checkstyle | 0m 5s | The patch fails to run checkstyle in phoenix-core |
| -1 :x: | javadoc | 0m 9s | phoenix-core in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix-core in master failed. |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 0m 22s | root in the patch failed. |
| -1 :x: | compile | 0m 8s | phoenix-core in the patch failed. |
| -1 :x: | javac | 0m 8s | phoenix-core in the patch failed. |
| -1 :x: | checkstyle | 0m 5s | The patch fails to run checkstyle in phoenix-core |
| -1 :x: | whitespace | 0m 0s | The patch 9 line(s) with tabs. |
| -1 :x: | javadoc | 0m 8s | phoenix-core in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix-core in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 8s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. |
| | | 5m 55s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 1a19a064f034 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 7d9f78d |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/artifact/yetus-general-check/output/branch-compile-phoenix-core.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/artifact/yetus-general-check/output/buildtool-branch-checkstyle-phoenix-core.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/artifact/yetus-general-check/output/branch-javadoc-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/artifact/yetus-general-check/output/branch-spotbugs-phoenix-core.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/artifact/yetus-general-check/output/buildtool-patch-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/artifact/yetus-general-check/output/whitespace-tabs.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/artifact/yetus-general-check/output/patch-javadoc-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/testReport/ |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/13/console |
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] jpisaac commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
jpisaac commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r544507112
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixTTLRegionObserver.java
##########
@@ -204,17 +213,22 @@ public PhoenixTTLRegionScanner(RegionCoprocessorEnvironment env, Scan scan,
private boolean doNext(List<Cell> result, boolean raw) throws IOException {
try {
+ long startTime = EnvironmentEdgeManager.currentTimeMillis();
boolean hasMore;
do {
hasMore = raw ? scanner.nextRaw(result) : scanner.next(result);
if (result.isEmpty()) {
break;
}
+ if (isDummy(result)) {
+ return true;
+ }
numRowsScanned++;
if (maskIfExpired && checkRowNotExpired(result)) {
break;
}
+ //TODO 6211 The following logic does not sound correct
Review comment:
@gjacoby126 @kadirozde if this comment was related to the test failures, then as I indicated we have a fix for it. The test failures were happening when deleting from local indexes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-734662882
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 0s | master passed |
| +1 :green_heart: | compile | 1m 3s | master passed |
| +1 :green_heart: | checkstyle | 1m 50s | master passed |
| +1 :green_heart: | javadoc | 0m 49s | master passed |
| +0 :ok: | spotbugs | 3m 8s | phoenix-core in master has 966 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 12s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed |
| +1 :green_heart: | javac | 0m 59s | the patch passed |
| -1 :x: | checkstyle | 1m 53s | phoenix-core: The patch generated 232 new + 4813 unchanged - 86 fixed = 5045 total (was 4899) |
| -1 :x: | whitespace | 0m 1s | The patch 9 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed |
| -1 :x: | spotbugs | 3m 23s | phoenix-core generated 2 new + 964 unchanged - 2 fixed = 966 total (was 966) |
||| _ Other Tests _ |
| -1 :x: | unit | 154m 58s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. |
| | | 201m 31s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.filter.PhoenixPageFilter.getNextRowKey() may expose internal representation by returning PhoenixPageFilter.nextRowKey At PhoenixPageFilter.java:by returning PhoenixPageFilter.nextRowKey At PhoenixPageFilter.java:[line 73] |
| | org.apache.phoenix.filter.PhoenixPageFilter.getRowKeyAtStop() may expose internal representation by returning PhoenixPageFilter.rowKeyAtStop At PhoenixPageFilter.java:by returning PhoenixPageFilter.rowKeyAtStop At PhoenixPageFilter.java:[line 70] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/10/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 11f2b08e4c47 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 457a67c |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/10/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/10/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/10/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/10/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/10/testReport/ |
| Max. process+thread count | 6152 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/10/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] kadirozde commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r545508156
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/OrderedResultIterator.java
##########
@@ -245,23 +256,33 @@ public int compare(ImmutableBytesWritable o1, ImmutableBytesWritable o2) {
@Override
public Tuple next() throws SQLException {
- return getResultIterator().next();
+ getResultIterator();
+ if (!resultIteratorReady) {
+ return dummyTuple;
+ }
+ return resultIterator.next();
}
private PeekingResultIterator getResultIterator() throws SQLException {
- if (resultIterator != null) {
+ if (resultIteratorReady) {
Review comment:
The results have been ordered yet. When the results are ordered then the result iterator will be ready to iterate over them. I will add a comment for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r553021396
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PagedRegionScanner.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.coprocessor;
+
+import java.io.IOException;
+import java.util.List;
+
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.regionserver.Region;
+import org.apache.hadoop.hbase.regionserver.RegionScanner;
+import org.apache.phoenix.filter.PagedFilter;
+
+import static org.apache.phoenix.util.ScanUtil.getDummyResult;
+import static org.apache.phoenix.util.ScanUtil.getPhoenixPagedFilter;
+
+public class PagedRegionScanner extends BaseRegionScanner {
+ protected Region region;
+ protected Scan scan;
+ protected PagedFilter pageFilter;
+ public PagedRegionScanner(Region region, RegionScanner scanner, Scan scan) {
+ super(scanner);
+ this.region = region;
+ this.scan = scan;
+ pageFilter = getPhoenixPagedFilter(scan);
+ if (pageFilter != null) {
+ pageFilter.init();
+ }
+ }
+
+ private boolean next(List<Cell> results, boolean raw) throws IOException {
+ try {
+ boolean hasMore = raw ? delegate.nextRaw(results) : delegate.next(results);
+ if (pageFilter == null) {
+ return hasMore;
+ }
+ if (!hasMore) {
Review comment:
@kadirozde - A little confused here: shouldn't we just be resetting the page filter start time if we DON'T have more to read and setting up the scan to resume later if we DO have more to read? the hasMore check is backwards from what I'd expect.
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewTTLIT.java
##########
@@ -2596,4 +2606,119 @@ private void deleteIndexData(boolean useGlobalConnection,
return testCases;
}
+
+ @Test
+ public void testPR() throws Exception {
Review comment:
From speaking with @kadirozde and @jpisaac offline it appears this test was included by mistake and should be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-735034062
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 4s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 21s | master passed |
| +1 :green_heart: | compile | 1m 2s | master passed |
| +1 :green_heart: | checkstyle | 1m 51s | master passed |
| +1 :green_heart: | javadoc | 0m 47s | master passed |
| +0 :ok: | spotbugs | 3m 8s | phoenix-core in master has 966 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 1s | the patch passed |
| +1 :green_heart: | compile | 0m 59s | the patch passed |
| +1 :green_heart: | javac | 0m 59s | the patch passed |
| -1 :x: | checkstyle | 1m 52s | phoenix-core: The patch generated 199 new + 4834 unchanged - 65 fixed = 5033 total (was 4899) |
| -1 :x: | whitespace | 0m 0s | The patch 9 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 22s | phoenix-core generated 0 new + 964 unchanged - 2 fixed = 964 total (was 966) |
||| _ Other Tests _ |
| -1 :x: | unit | 156m 15s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 22s | The patch does not generate ASF License warnings. |
| | | 197m 24s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/11/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux d213c3ba9db2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 993ad5e |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/11/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/11/artifact/yetus-general-check/output/whitespace-tabs.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/11/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/11/testReport/ |
| Max. process+thread count | 6256 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/11/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] kadirozde commented on a change in pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #973:
URL: https://github.com/apache/phoenix/pull/973#discussion_r546874922
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewTTLIT.java
##########
@@ -1406,6 +1407,7 @@ public void testWithVariousSQLsForMultipleViews() throws Exception {
}
}
+ @Ignore("Fails with StaleRegionBoundaryCacheException. Mutations on a SCN connection could be the reason")
Review comment:
@jpisaac, Thank you very much. I will apply your patch soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-729402100
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 14s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 13m 11s | master passed |
| +1 :green_heart: | compile | 0m 58s | master passed |
| +1 :green_heart: | checkstyle | 2m 14s | master passed |
| +1 :green_heart: | javadoc | 0m 44s | master passed |
| +0 :ok: | spotbugs | 2m 54s | phoenix-core in master has 962 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 31s | the patch passed |
| +1 :green_heart: | compile | 0m 52s | the patch passed |
| +1 :green_heart: | javac | 0m 52s | the patch passed |
| -1 :x: | checkstyle | 2m 20s | phoenix-core: The patch generated 212 new + 4119 unchanged - 71 fixed = 4331 total (was 4190) |
| -1 :x: | whitespace | 0m 0s | The patch 9 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 44s | the patch passed |
| -1 :x: | spotbugs | 3m 4s | phoenix-core generated 2 new + 960 unchanged - 2 fixed = 962 total (was 962) |
||| _ Other Tests _ |
| -1 :x: | unit | 97m 32s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. |
| | | 139m 29s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.filter.PhoenixPageFilter.getRowKeyAtStop() may expose internal representation by returning PhoenixPageFilter.rowKeyAtStop At PhoenixPageFilter.java:by returning PhoenixPageFilter.rowKeyAtStop At PhoenixPageFilter.java:[line 72] |
| | org.apache.phoenix.filter.PhoenixPageFilter.stopImmediatelyForTesting should be package protected At PhoenixPageFilter.java: At PhoenixPageFilter.java:[line 45] |
| Failed junit tests | phoenix.end2end.ProductMetricsIT |
| | phoenix.end2end.index.GlobalMutableTxIndexIT |
| | phoenix.end2end.ReverseScanIT |
| | phoenix.end2end.StatsEnabledSplitSystemCatalogIT |
| | phoenix.end2end.SortMergeJoinMoreIT |
| | phoenix.tx.ParameterizedTransactionIT |
| | phoenix.end2end.ViewIT |
| | phoenix.end2end.RowValueConstructorIT |
| | phoenix.tx.TransactionIT |
| | phoenix.end2end.join.HashJoinNoIndexIT |
| | phoenix.end2end.DistinctPrefixFilterIT |
| | phoenix.end2end.join.HashJoinLocalIndexIT |
| | phoenix.end2end.IndexScrutinyToolIT |
| | phoenix.end2end.join.SubqueryIT |
| | phoenix.end2end.AlterMultiTenantTableWithViewsIT |
| | phoenix.end2end.index.PartialIndexRebuilderIT |
| | phoenix.end2end.index.GlobalImmutableTxIndexIT |
| | phoenix.end2end.join.SortMergeJoinNoSpoolingIT |
| | phoenix.end2end.TenantSpecificTablesDDLIT |
| | phoenix.end2end.TransactionalViewIT |
| | phoenix.tx.TxCheckpointIT |
| | phoenix.end2end.index.LocalIndexIT |
| | phoenix.end2end.SkipScanQueryIT |
| | phoenix.end2end.index.MutableIndexIT |
| | phoenix.tx.FlappingTransactionIT |
| | phoenix.end2end.join.SortMergeJoinNoIndexIT |
| | phoenix.end2end.DerivedTableIT |
| | phoenix.end2end.index.MutableIndexFailureIT |
| | phoenix.execute.PartialCommitIT |
| | phoenix.end2end.index.MutableIndexFailureWithNamespaceIT |
| | phoenix.end2end.join.SubqueryUsingSortMergeJoinIT |
| | phoenix.end2end.AlterTableWithViewsIT |
| | phoenix.end2end.join.HashJoinGlobalIndexIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 9203aaa6937a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 243ac64 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/1/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/1/testReport/ |
| Max. process+thread count | 6883 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-731699386
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 18s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 36s | master passed |
| +1 :green_heart: | compile | 1m 1s | master passed |
| +1 :green_heart: | checkstyle | 1m 42s | master passed |
| +1 :green_heart: | javadoc | 0m 48s | master passed |
| +0 :ok: | spotbugs | 3m 11s | phoenix-core in master has 966 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 7s | the patch passed |
| +1 :green_heart: | compile | 1m 2s | the patch passed |
| +1 :green_heart: | javac | 1m 2s | the patch passed |
| -1 :x: | checkstyle | 1m 44s | phoenix-core: The patch generated 190 new + 4348 unchanged - 72 fixed = 4538 total (was 4420) |
| -1 :x: | whitespace | 0m 0s | The patch 9 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 44s | the patch passed |
| -1 :x: | spotbugs | 3m 27s | phoenix-core generated 3 new + 964 unchanged - 2 fixed = 967 total (was 966) |
||| _ Other Tests _ |
| -1 :x: | unit | 170m 42s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. |
| | | 212m 19s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.filter.PhoenixPageFilter.getNextRowKey() may expose internal representation by returning PhoenixPageFilter.nextRowKey At PhoenixPageFilter.java:by returning PhoenixPageFilter.nextRowKey At PhoenixPageFilter.java:[line 74] |
| | org.apache.phoenix.filter.PhoenixPageFilter.getRowKeyAtStop() may expose internal representation by returning PhoenixPageFilter.rowKeyAtStop At PhoenixPageFilter.java:by returning PhoenixPageFilter.rowKeyAtStop At PhoenixPageFilter.java:[line 71] |
| | org.apache.phoenix.filter.PhoenixPageFilter.stopImmediatelyForTesting should be package protected At PhoenixPageFilter.java: At PhoenixPageFilter.java:[line 43] |
| Failed junit tests | phoenix.end2end.index.PartialIndexRebuilderIT |
| | phoenix.end2end.ViewTTLIT |
| | phoenix.end2end.RowValueConstructorIT |
| | phoenix.end2end.ProductMetricsIT |
| | phoenix.end2end.ReverseScanIT |
| | phoenix.end2end.DistinctPrefixFilterIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 4ab938caf15b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / f1a0860 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/6/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/6/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/6/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/6/testReport/ |
| Max. process+thread count | 6295 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/6/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-757400110
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 16m 14s | master passed |
| +1 :green_heart: | compile | 0m 58s | master passed |
| +1 :green_heart: | checkstyle | 1m 47s | master passed |
| +1 :green_heart: | javadoc | 0m 48s | master passed |
| +0 :ok: | spotbugs | 3m 12s | phoenix-core in master has 956 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 22s | the patch passed |
| +1 :green_heart: | compile | 0m 58s | the patch passed |
| +1 :green_heart: | javac | 0m 58s | the patch passed |
| -1 :x: | checkstyle | 1m 50s | phoenix-core: The patch generated 317 new + 4854 unchanged - 133 fixed = 5171 total (was 4987) |
| -1 :x: | whitespace | 0m 0s | The patch 10 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed |
| -1 :x: | spotbugs | 3m 25s | phoenix-core generated 2 new + 953 unchanged - 3 fixed = 955 total (was 956) |
||| _ Other Tests _ |
| -1 :x: | unit | 184m 18s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. |
| | | 228m 19s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Should org.apache.phoenix.index.GlobalIndexChecker$GlobalIndexScanner be a _static_ inner class? At GlobalIndexChecker.java:inner class? At GlobalIndexChecker.java:[lines 128-608] |
| | Boxed value is unboxed and then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:[line 183] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/973 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux d800b0a70da3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 9c346ed |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/testReport/ |
| Max. process+thread count | 5980 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org