You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2025/12/29 09:36:17 UTC

[I] [C++] Fix ToStringWithoutContextLines to check for :\d+ pattern before removing lines [arrow]

HyukjinKwon opened a new issue, #48673:
URL: https://github.com/apache/arrow/issues/48673

   ### Describe the enhancement requested
   
   https://github.com/apache/arrow/blob/7ebc88c8fae62ed97bc30865c845c8061132af7e/cpp/src/arrow/status.cc#L131-L134
   
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] Fix ToStringWithoutContextLines to check for :\d+ pattern before removing lines [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #48673:
URL: https://github.com/apache/arrow/issues/48673#issuecomment-3817045225

   Issue resolved by pull request 48674
   https://github.com/apache/arrow/pull/48674


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] Fix ToStringWithoutContextLines to check for :\d+ pattern before removing lines [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #48673: [C++] Fix ToStringWithoutContextLines to check for :\d+ pattern before removing lines
URL: https://github.com/apache/arrow/issues/48673


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] Fix ToStringWithoutContextLines to check for :\d+ pattern before removing lines [arrow]

Posted by "goldigd05 (via GitHub)" <gi...@apache.org>.
goldigd05 commented on issue #48673:
URL: https://github.com/apache/arrow/issues/48673#issuecomment-3708524503

   Great 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] Fix ToStringWithoutContextLines to check for :\d+ pattern before removing lines [arrow]

Posted by "goldigd05 (via GitHub)" <gi...@apache.org>.
goldigd05 commented on issue #48673:
URL: https://github.com/apache/arrow/issues/48673#issuecomment-3708380516

   Hi, I would like to contribute a fix for `Status::ToStringWithoutContextLines()`.
   
   Currently, this function removes context lines using a heuristic based on colons (`:`),
   which may accidentally remove parts of the original error message.
   
   My fix approach:
   1. Update `AddContextLine()` to prefix context lines with `[context]`.
   2. Update `ToStringWithoutContextLines()` to strip only lines that start with `[context]`.
   3. Add a unit test to ensure that original error messages are preserved while context lines are removed.
   
   This change ensures that:
   - Original error messages remain intact.
   - Only the extra context added via `AddContextLine()` is removed.
   - Works even if the error message contains colons.
   
   I am happy to submit a PR implementing this approach. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] Fix ToStringWithoutContextLines to check for :\d+ pattern before removing lines [arrow]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on issue #48673:
URL: https://github.com/apache/arrow/issues/48673#issuecomment-3708426894

   Oh I actually already created a PR for it :-).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org