You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2021/12/03 04:22:18 UTC

[GitHub] [ratis] guohao-rosicky edited a comment on pull request #549: RATIS-1454. NettyServerStreamRpc get request resolving concurrency se…

guohao-rosicky edited a comment on pull request #549:
URL: https://github.com/apache/ratis/pull/549#issuecomment-985203931


   > @guohao-rosicky , thanks, I read these netty API docs earlier. Some questions:
   > 
   > * Is there a problem you observed?  If yes, could you show the datails?
   > * The calls might have shared the same context.  We need to verify it.
   > * Somehow the attr method ( https://netty.io/4.1/api/io/netty/channel/ChannelHandlerContext.html#attr-io.netty.util.AttributeKey- ) is deprecated.  So, it is not clear what is the correct way to use it.
   
   @szetszwo
   
   1. There is a potential problem, but it has not been discovered
   2. I used the `ChannelHandlerContext.name ()` this is the only name each context
   3. I use `ctx.channel().attr()` and will not deprecated this method


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org