You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@marvin.apache.org by GitBox <gi...@apache.org> on 2020/10/25 20:37:36 UTC
[GitHub] [incubator-marvin] lucasbmiguel opened a new pull request #56: Allowing the predictor endpoint to return JSON within result
lucasbmiguel opened a new pull request #56:
URL: https://github.com/apache/incubator-marvin/pull/56
Currently, anything that's returned from the engine predictor.py `execute` method, during a POST to /predictor, will be converted to a string. This request introduces the ability for engines to return complex JSON types on HTTP requests for /predictor.
#### How to test:
- Create a new engine and modify the `execute` method of your predictor.py to return a dict with multiple fields.
- Start your engine http server and perform a client POST request to the /predictor endpoint
#### Expected result
You should see a response that contains a JSON inside the "result" field of the top-level response.
Similar to:
```
{
"result": {
"myPrediction": "predictedValue",
"additionalInfo": "toCarry",
"justANumber": 9
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] lucasbmiguel commented on pull request #56: Allowing the predictor endpoint to return JSON within result
Posted by GitBox <gi...@apache.org>.
lucasbmiguel commented on pull request #56:
URL: https://github.com/apache/incubator-marvin/pull/56#issuecomment-716208406
This fixes (https://issues.apache.org/jira/projects/MARVIN/issues/MARVIN-77)[MARVIN-77]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] lucasbmiguel removed a comment on pull request #56: Allowing the predictor endpoint to return JSON within result
Posted by GitBox <gi...@apache.org>.
lucasbmiguel removed a comment on pull request #56:
URL: https://github.com/apache/incubator-marvin/pull/56#issuecomment-716208343
This fixes MARVIN-77
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] lucasbmiguel commented on pull request #56: Allowing the predictor endpoint to return JSON within result
Posted by GitBox <gi...@apache.org>.
lucasbmiguel commented on pull request #56:
URL: https://github.com/apache/incubator-marvin/pull/56#issuecomment-716208297
This, fixes MARVIN-77
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] lucasbmiguel edited a comment on pull request #56: Allowing the predictor endpoint to return JSON within result
Posted by GitBox <gi...@apache.org>.
lucasbmiguel edited a comment on pull request #56:
URL: https://github.com/apache/incubator-marvin/pull/56#issuecomment-716208406
This fixes [MARVIN-77](https://issues.apache.org/jira/projects/MARVIN/issues/MARVIN-77)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] lucasbmiguel removed a comment on pull request #56: Allowing the predictor endpoint to return JSON within result
Posted by GitBox <gi...@apache.org>.
lucasbmiguel removed a comment on pull request #56:
URL: https://github.com/apache/incubator-marvin/pull/56#issuecomment-716208297
This, fixes MARVIN-77
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] lucasbmiguel commented on pull request #56: Allowing the predictor endpoint to return JSON within result
Posted by GitBox <gi...@apache.org>.
lucasbmiguel commented on pull request #56:
URL: https://github.com/apache/incubator-marvin/pull/56#issuecomment-716208343
This fixes MARVIN-77
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] asfgit merged pull request #56: Allowing the predictor endpoint to return JSON within result
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #56:
URL: https://github.com/apache/incubator-marvin/pull/56
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-marvin] lucasbmiguel edited a comment on pull request #56: Allowing the predictor endpoint to return JSON within result
Posted by GitBox <gi...@apache.org>.
lucasbmiguel edited a comment on pull request #56:
URL: https://github.com/apache/incubator-marvin/pull/56#issuecomment-716208406
This fixes [https://issues.apache.org/jira/projects/MARVIN/issues/MARVIN-77](MARVIN-77)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org